GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — [v18.x] Warning for import assertions by aduh95 · Pull Request #55873 · nodejs/node

Conversation

aduh95 commented Nov 15, 2024

Copy link

Copy Markdown

Contributor

Fixes: #55869

$ ./node --input-type=module -e 'import "data:application/json,{}" assert { type: "json" }'
(node:96221) V8: file:///Users/duhamean/Documents/node-v18.x/[eval1]:1 'assert' is deprecated in import statements and support will be removed in a future version; use 'with' instead
(Use `node --trace-warnings ...` to show where the warning was created)
$ echo $?
0
$ ./node --input-type=module -e 'import "data:application/json,{}" with { type: "json" }'
$ echo $?
0

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

viceice reacted with heart emoji

All reactions

❤️ 1 reaction

nodejs-github-bot commented Nov 15, 2024

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

v18.x v8 engine Issues and PRs related to the V8 dependency. labels

Nov 15, 2024

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 15, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 15, 2024

This comment was marked as outdated.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 15, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 15, 2024

This comment was marked as outdated.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 16, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 16, 2024

This comment was marked as outdated.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 16, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 16, 2024

This comment was marked as outdated.

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 16, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 16, 2024

This comment was marked as outdated.

aduh95 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed release-agenda Issues and PRs to discuss during Release team meetings. labels

Feb 10, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 10, 2025

nodejs-github-bot commented Feb 10, 2025

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65125/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This comment was marked as outdated.

aduh95 force-pushed the warning-for-import-assertions branch from 912aecc to cc907e4 Compare

February 10, 2025 21:35

aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 10, 2025

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Feb 10, 2025

nodejs-github-bot commented Feb 10, 2025

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65131/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 10, 2025

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6406/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 10, 2025

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6406/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 10, 2025

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6406/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 12, 2025

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65150/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 12, 2025

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65151/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 12, 2025

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65153/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 12, 2025

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65164/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Feb 13, 2025

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65170/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 and others added 3 commits

February 13, 2025 11:41


          test: do not use deprecated import assertions

e74fcc7

PR-URL: nodejs#55873
Fixes: nodejs#55869
Reviewed-By: Richard Lau <[email protected]>


          deps: V8: backport ae5a4db8ad86

80c8a66

Original commit message:

    [import-attributes] Deprecate 'assert' for removal in 12.6

    See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ

    Bug: v8:10958
    Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
    Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
    Auto-Submit: Shu-yu Guo <[email protected]>
    Commit-Queue: Shu-yu Guo <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92044}

Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: nodejs#55873
Fixes: nodejs#55869
Reviewed-By: Richard Lau <[email protected]>


          deps: V8: cherry-pick 26fd1dfa9cd6

45a1f2b

Original commit message:

    [import-attributes] Deprecate 'assert' for dynamic import as well

    Bug: v8:10958
    Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
    Commit-Queue: Shu-yu Guo <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92123}

Refs: v8/v8@26fd1df
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: nodejs#55873
Fixes: nodejs#55869
Reviewed-By: Richard Lau <[email protected]>

aduh95 force-pushed the warning-for-import-assertions branch from cc907e4 to 45a1f2b Compare

February 13, 2025 10:42

aduh95 commented Feb 13, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

Landed in 06c523d...d03a235

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 merged commit 45a1f2b into nodejs:v18.x-staging

Feb 13, 2025

aduh95 added a commit that referenced this pull request

Feb 13, 2025


          test: do not use deprecated import assertions

d47e8cb

PR-URL: #55873
Fixes: #55869
Reviewed-By: Richard Lau <[email protected]>

aduh95 added a commit that referenced this pull request

Feb 13, 2025


          deps: V8: backport ae5a4db8ad86

53bb21b

Original commit message:

    [import-attributes] Deprecate 'assert' for removal in 12.6

    See https://groups.google.com/a/chromium.org/g/blink-dev/c/ZHvzLaJZRvo/m/FgNDBjrtBQAJ

    Bug: v8:10958
    Change-Id: I4d21c9f7aad1024b198b4a1cdfb4792a011da464
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5055681
    Reviewed-by: Rezvan Mahdavi Hezaveh <[email protected]>
    Auto-Submit: Shu-yu Guo <[email protected]>
    Commit-Queue: Shu-yu Guo <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92044}

Refs: v8/v8@ae5a4db
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #55873
Fixes: #55869
Reviewed-By: Richard Lau <[email protected]>

aduh95 added a commit that referenced this pull request

Feb 13, 2025


          deps: V8: cherry-pick 26fd1dfa9cd6

d03a235

Original commit message:

    [import-attributes] Deprecate 'assert' for dynamic import as well

    Bug: v8:10958
    Change-Id: I7847bdb5d2c79f057f4e1df99f8f5889788f09cb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5249778
    Commit-Queue: Shu-yu Guo <[email protected]>
    Reviewed-by: Leszek Swirski <[email protected]>
    Cr-Commit-Position: refs/heads/main@{#92123}

Refs: v8/v8@26fd1df
Co-authored-by: Antoine du Hamel <[email protected]>
PR-URL: #55873
Fixes: #55869
Reviewed-By: Richard Lau <[email protected]>

aduh95 deleted the warning-for-import-assertions branch

February 13, 2025 10:43

github-actions Bot mentioned this pull request

Feb 18, 2025

2025-02-20, Version 18.20.7 'Hydrogen' (LTS) #57122

Merged

Reviewers

richardlau

richardlau approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

v8 engine

Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

aduh95 commented Nov 15, 2024

Uh oh!

nodejs-github-bot commented Nov 15, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Feb 10, 2025

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Feb 10, 2025

Uh oh!

nodejs-github-bot commented Feb 10, 2025

Uh oh!

nodejs-github-bot commented Feb 10, 2025

Uh oh!

nodejs-github-bot commented Feb 10, 2025

Uh oh!

nodejs-github-bot commented Feb 12, 2025

Uh oh!

nodejs-github-bot commented Feb 12, 2025

Uh oh!

nodejs-github-bot commented Feb 12, 2025

Uh oh!

nodejs-github-bot commented Feb 12, 2025

Uh oh!

nodejs-github-bot commented Feb 13, 2025

Uh oh!

aduh95 commented Feb 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

aduh95 commented Feb 13, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.