GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — v20.18.1 proposal by marco-ippolito · Pull Request #55879 · nodejs/node

Conversation

marco-ippolito commented Nov 16, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

2024-11-20, Version 20.18.1 'Iron' (LTS), @marco-ippolito

Notable Changes

[7a8992b2d6] - doc: add abmusse to collaborators (Abdirahim Musse) #55086

Commits

[085c3441fe] - assert: show the diff when deep comparing data with a custom message (Giovanni) #54759
[01f0b0e7b4] - benchmark: adjust config for deepEqual object (Rafael Gonzaga) #55254
[a45537269b] - benchmark: rewrite detect-esm-syntax benchmark (Joyee Cheung) #55238
[1a0d8ef64f] - benchmark: add no-warnings to process.has bench (Rafael Gonzaga) #55159
[2be5d611ce] - benchmark: create benchmark for typescript (Marco Ippolito) #54904
[a2aa4fa477] - benchmark: include ascii to fs/readfile (Rafael Gonzaga) #54988
[09849105fe] - benchmark: add dotenv benchmark (Aviv Keller) #54278
[6b3c24dbad] - buffer: fix out of range for toString (Jason Zhang) #54553
[f25a5b6dc4] - build: use rclone instead of aws CLI (Michaël Zasso) #55617
[0bbeb605de] - build: fix notify-on-review-wanted action (Rafael Gonzaga) #55304
[5b35836732] - build: include .nycrc in coverage workflows (Wuli Zuo) #55210
[f38d1e90e0] - build: notify via slack when review-wanted (Rafael Gonzaga) #55102
[0b985ec4bb] - build: remove -v flag to reduce noise (iwuliz) #55025
[09f75b27a1] - build: display free disk space after build in the test-macOS workflow (iwuliz) #55025
[f25760c4a2] - build: add the option to generate compile_commands.json in vcbuild.bat (Segev Finer) #52279
[746e78c4f3] - Revert "build: upgrade clang-format to v18" (Chengzhong Wu) #54994
[67834ee646] - build: print Running XYZ linter... for py and yml (Aviv Keller) #54386
[ae34e276a2] - build: pin doc workflow to Node.js 20 (Richard Lau) #55755
[d0e871a706] - build,win: add winget config to set up env (Hüseyin Açacak) #54729
[93ac799b6b] - cli: fix spacing for port range error (Aviv Keller) #54495
[3ba2e7bf97] - Revert "console: colorize console error and warn" (Aviv Keller) #54677
[2f678ea53b] - crypto: ensure invalid SubtleCrypto JWK data import results in DataError (Filip Skokan) #55041
[5d28d98542] - deps: update undici to 6.20.0 (Node.js GitHub Bot) #55329
[0c7f2fc421] - deps: update archs files for openssl-3.0.15+quic1 (Node.js GitHub Bot) #55184
[da15e7edf5] - deps: upgrade openssl sources to quictls/openssl-3.0.15+quic1 (Node.js GitHub Bot) #55184
[381f1f9d08] - deps: update archs files for openssl-3.0.14+quic1 (Node.js GitHub Bot) #54336
[48d643f78a] - deps: upgrade openssl sources to quictls/openssl-3.0.14+quic1 (Node.js GitHub Bot) #54336
[7b1796803b] - deps: update timezone to 2024b (Node.js GitHub Bot) #55056
[8f1956c588] - deps: update acorn-walk to 8.3.4 (Node.js GitHub Bot) #54950
[20501a7350] - deps: update corepack to 0.29.4 (Node.js GitHub Bot) #54845
[0f81eafecc] - doc: fix Markdown linter (Antoine du Hamel) #55344
[df713f0a98] - Revert "doc: update test context.assert" (Antoine du Hamel) #55344
[fd6fc61d2c] - doc: add pmarchini to collaborators (Pietro Marchini) #55331
[b963db9ee2] - doc: fix events.once() example using AbortSignal (Ivo Janssen) #55144
[50b13bfb12] - doc: add onboarding details for ambassador program (Marco Ippolito) #55284
[27564b7811] - doc: fix initial default value of autoSelectFamily (Ihor Rohovets) #55245
[9e7be23aa5] - doc: tweak onboarding instructions (Michael Dawson) #55212
[f412a029c3] - doc: update test context.assert (Pietro Marchini) #55186
[2f7828debb] - doc: fix unordered error anchors (Antoine du Hamel) #55242
[d08e4c235b] - doc: mention addons to experimental permission (Rafael Gonzaga) #55166
[d65c2458dc] - doc: use correct dash in stability status (Antoine du Hamel) #55200
[d9839c16cf] - doc: fix link in test/README.md (Livia Medeiros) #55165
[1ad659afa4] - doc: add esm examples to node:net (Alfredo González) #55134
[81ad69d50f] - doc: move the YAML changes element (sendoru) #55112
[7a51a161be] - doc: fix the require resolve algorithm in modules.md (chirsz) #55117
[80edcdf899] - doc: update style guide (Aviv Keller) #53223
[388c754dd2] - doc: add missing : to run()'s globPatterns (Aviv Keller) #55135
[94302b6a76] - doc: add abmusse to collaborators (Abdirahim Musse) #55086
[27ff2da964] - doc: add note about --expose-internals (Aviv Keller) #52861
[df6dc753b7] - doc: remove parseREPLKeyword from REPL documentation (Aviv Keller) #54749
[4baa5c4d10] - doc: change backporting guide with updated info (Aviv Keller) #53746
[9947fc112f] - doc: add missing definitions to internal-api.md (Aviv Keller) #53303
[a4586f0e94] - doc: update documentation for externalizing deps (Michael Dawson) #54792
[70504f8522] - doc: update require(ESM) history and stability status (Antoine du Hamel) #55199
[9d0041ac40] - doc: add release key for aduh95 (Antoine du Hamel) #55349
[0c1666a52a] - events: allow null/undefined eventInitDict (Matthew Aitken) #54643
[453df77f99] - events: return currentTarget when dispatching (Matthew Aitken) #54642
[0decaab9db] - fs: acknowledge signal option in filehandle.createReadStream() (Livia Medeiros) #55148
[00a2fc7166] - lib: move Symbol[Async]Dispose polyfills to internal/util (Antoine du Hamel) #54853
[8e6b606ac4] - lib: remove lib/internal/idna.js (Yagiz Nizipli) #55050
[c96e5cb664] - lib: the REPL should survive deletion of Array.prototype methods (Jordan Harband) #31457
[748ed2e559] - meta: move one or more collaborators to emeritus (Node.js GitHub Bot) #55300
[8b8d35f015] - meta: bump mozilla-actions/sccache-action from 0.0.5 to 0.0.6 (dependabot[bot]) #55225
[d3441ff0c8] - meta: bump actions/checkout from 4.1.7 to 4.2.0 (dependabot[bot]) #55224
[1c20908558] - meta: bump actions/setup-node from 4.0.3 to 4.0.4 (dependabot[bot]) #55223
[8a529abd69] - meta: bump peter-evans/create-pull-request from 7.0.1 to 7.0.5 (dependabot[bot]) #55219
[9053d210ab] - meta: add mailmap entry for abmusse (Abdirahim Musse) #55182
[db2496c125] - meta: add more information about nightly releases (Aviv Keller) #55084
[d2ce003b2f] - meta: add linux to OS labels in collaborator guide (Aviv Keller) #54986
[37b0bea247] - meta: remove never-used workflow trigger (Aviv Keller) #54983
[ae27e2dcd7] - meta: add links to alternative issue trackers (Aviv Keller) #54401
[6e5d524b0f] - module: remove duplicated import (Aviv Keller) #54942
[3a682cca03] - path: remove repetitive conditional operator in posix.resolve (Wiyeong Seo) #54835
[ac1cb8dfdb] - perf_hooks: add missing type argument to getEntriesByName (Luke Taher) #54767
[85b3edc83b] - repl: catch \v and \r in new-line detection (Aviv Keller) #54512
[df1f04999e] - src: decode native error messages as UTF-8 (Joyee Cheung) #55024
[86d718177a] - src: update clang-tidy and focus on modernization (Yagiz Nizipli) #53757
[7d01b6a9c5] - src: cleanup per env handles directly without a list (Chengzhong Wu) #54993
[a730cdb622] - src: remove duplicate code setting AF_INET (He Yang) #54939
[f10d9ad283] - stream: treat null asyncIterator as undefined (Jason Zhang) #55119
[6027084245] - test: make test-loaders-workers-spawned less flaky (Antoine du Hamel) #55172
[66a87d19bd] - test: update multiple assert tests to use node:test (James M Snell) #54585
[5105188c47] - test: update wpt test for encoding (devstone) #55151
[81bcec0b82] - test: deflake test/pummel/test-timers.js (jakecastelli) #55098
[82c402265a] - test: deflake test-http-remove-header-stays-removed (Luigi Pinca) #55004
[78021701ed] - test: fix test-tls-junk-closes-server (Michael Dawson) #55089
[c908b8a2d8] - test: fix more tests that fail when path contains a space (Antoine du Hamel) #55088
[afc1628e73] - test: fix assertSnapshot when path contains a quote (Antoine du Hamel) #55087
[7c88739b83] - test: fix some tests when path contains % (Antoine du Hamel) #55082
[eb4d468671] - Revert "test: mark test-fs-watch-non-recursive flaky on Windows" (Luigi Pinca) #55079
[bc7b5249d4] - test: make test-runner-assert more robust (Aviv Keller) #55036
[6c2a1386f7] - test: update tls test to support OpenSSL32 (Michael Dawson) #55030
[96406610fa] - test: fix test-vm-context-dont-contextify when path contains a space (Antoine du Hamel) #55026
[39a80eed4f] - test: adjust tls-set-ciphers for OpenSSL32 (Michael Dawson) #55016
[bd8fd4fceb] - test: add util.stripVTControlCharacters test (RedYetiDev) #54865
[333b5a02d0] - test: improve coverage for timer promises schedular (Aviv Keller) #53370
[f48992f433] - test: remove unused common utilities (RedYetiDev) #54825
[93a098c56d] - test: deflake test-http-header-overflow (Luigi Pinca) #54978
[f849cf677d] - test: fix soucre to source (Aviv Keller) #55038
[1a007ea814] - test: add asserts to validate test assumptions (Michael Dawson) #54997
[6f53c096f8] - test: move test-http-max-sockets to parallel (Luigi Pinca) #54977
[aba9dc775e] - test: remove test-http-max-sockets flaky designation (Luigi Pinca) #54976
[ee5624bffe] - test: adjust key sizes to support OpenSSL32 (Michael Dawson) #54972
[5c11a61140] - test: update test to support OpenSSL32 (Michael Dawson) #54968
[62f21470e4] - test: update DOM events web platform tests (Matthew Aitken) #54642
[426851705c] - test_runner: assert entry is a valid object (Edigleysson Silva (Edy)) #55231
[b1cad519d7] - test_runner: use test: symbol on second print of parent test (RedYetiDev) #54956
[63c8f3d436] - test_runner: replace ansi clear with ansi reset (Pietro Marchini) #55013
[0b3fb344f7] - tools: add polyfilled option to prefer-primordials rule (Antoine du Hamel) #55318
[8981309bd9] - tools: make choco install script more readable (Aviv Keller) #54002
[7310abeae1] - tools: bump Rollup from 4.18.1 to 4.22.4 for lint-md (dependabot[bot]) #55093
[083311e8af] - tools: remove redudant code from eslint require rule (Aviv Keller) #54892
[ae4b2aece1] - tools: update error message for ICU in license-builder (Aviv Keller) #54742
[3ebd31684d] - tools: update github_reporter to 1.7.1 (Node.js GitHub Bot) #54951
[397be8a10e] - tty: fix links for terminal colors (Aviv Keller) #54596
[a3c2ef9e98] - util: update ansi regex (Aviv Keller) #54865
[efdccc88a2] - watch: preserve output when gracefully restarted (Théo LUDWIG) #54323
[226836c5ac] - worker: throw InvalidStateError in postMessage after close (devstone) #55206
[f39ff4d14b] - worker: handle --input-type more consistently (Antoine du Hamel) #54979
[30383ffb9a] - zlib: throw brotli initialization error from c++ (Yagiz Nizipli) #54698

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

aduh95 and others added 4 commits

October 11, 2024 10:20


          doc: add release key for aduh95

9d0041a

PR-URL: #55349
Refs: nodejs/Release#999
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Richard Lau <[email protected]>


          build: pin doc workflow to Node.js 20

ae34e27

To save time, the `.github/workflows/doc.yml` workflow runs
with a pre-built Node.js. The switch of `lts/*` to Node.js 22 has
broken this workflow for Node.js 20 and 18 due to a mismatch
in globals. Pin the version of Node.js back to 20.

PR-URL: #55755
Fixes: #55754
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          buffer: fix out of range for toString

6b3c24d

Co-authored-by: Michaël Zasso <[email protected]>
PR-URL: #54553
Backport-PR-URL: #55213
Fixes: #52298
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Refs: #54553


          doc: update require(ESM) history and stability status

70504f8

PR-URL: #55199
Backport-PR-URL: #55265
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Guy Bedford <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>

nodejs-github-bot commented Nov 16, 2024

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/actions
@nodejs/security-wg
@nodejs/tsc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added meta

Issues and PRs related to the general management of the project.

v20.x labels

Nov 16, 2024

marco-ippolito added release Issues and PRs related to Node.js releases. and removed meta Issues and PRs related to the general management of the project. labels

Nov 16, 2024

marco-ippolito marked this pull request as ready for review

November 16, 2024 13:34

This was referenced Nov 16, 2024

feat(git-node): use a single git push command nodejs/node-core-utils#870

Merged

fix(git-node): do not assume release commit will conflict nodejs/node-core-utils#871

Merged

marco-ippolito added needs-ci

PRs that need a full CI run.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Nov 16, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 16, 2024

nodejs-github-bot commented Nov 16, 2024

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63581/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 commented Nov 16, 2024

Copy link

Copy Markdown

Contributor

I think #55170 (comment) is still going to be an issue.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito commented Nov 16, 2024

Copy link

Copy Markdown

Member Author

Should I just drop the npm update?

aduh95 and anonrig reacted with thumbs up emoji

All reactions

👍 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mhdawson and others added 12 commits

November 17, 2024 11:51


          doc: update documentation for externalizing deps

a4586f0

Refs: #54646

- Add instructions to update how process.versions is reported
  as I missed that in a recent addition.

Signed-off-by: Michael Dawson <[email protected]>
PR-URL: #54792
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Akhil Marsonya <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>


          tools: update github_reporter to 1.7.1

3ebd316

PR-URL: #54951
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>


          deps: update corepack to 0.29.4

20501a7

PR-URL: #54845
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          lib: the REPL should survive deletion of Array.prototype methods

c96e5cb

Specifically, `delete Array.prototype.lastIndexOf` immediately crashes
the REPL, as does deletion of a few other Array prototype methods.

PR-URL: #31457
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>


          benchmark: add dotenv benchmark

PR-URL: #54278
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Vinícius Lourenço Claro Cardoso <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>


          meta: add links to alternative issue trackers

ae27e2d

PR-URL: #54401
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>


          doc: add missing definitions to internal-api.md

9947fc1

PR-URL: #53303
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>


          doc: change backporting guide with updated info

4baa5c4

PR-URL: #53746
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>


          cli: fix spacing for port range error

93ac799

PR-URL: #54495
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          build: print Running XYZ linter... for py and yml

67834ee

PR-URL: #54386
Reviewed-By: Luigi Pinca <[email protected]>


          src: remove duplicate code setting AF_INET

a730cdb

`AF_INET` has been repeatedly set three times in the code. this should
be redundant. removed the last two times.

PR-URL: #54939
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>


          path: remove repetitive conditional operator in posix.resolve

3a682cc

PR-URL: #54835
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>


          2024-11-20, Version 20.18.1 'Iron' (LTS)

Notable changes:

doc:
  * add abmusse to collaborators (Abdirahim Musse) #55086

PR-URL: #55879

marco-ippolito force-pushed the v20.18.1-proposal branch from 4216e6d to 7017811 Compare

November 18, 2024 09:28

marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 18, 2024

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Nov 18, 2024

This comment was marked as outdated.

avivkeller mentioned this pull request

Nov 18, 2024

https://github.com/nodejs/node/pull/54677 should be backported to NodeJS 20 Branch #55726

Closed

This comment was marked as outdated.

nodejs-github-bot commented Nov 19, 2024 •

edited by marco-ippolito

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63627/ 🟢
CITGM 🐦 : https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3512/ 🟢
RELEASE 📦 : https://ci-release.nodejs.org/job/iojs+release/10615/ 🟢

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito commented Nov 20, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

@nodejs/undici is failing in CITGM looks like OpenSSL

Details

test at test/http2.js:310:1
  [v20] Request should fail if allowH2 is false and server advertises h1 only (12.626939ms)
   AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
   + actual - expected
   
   + '40B8497C4F7F0000:error:0A000460:SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1605:SSL alert number 120\n'
   - 'Client network socket disconnected before secure TLS connection was established'
       at res.<computed> [as strictEqual] (/home/iojs/tmp/citgm_tmp/e04be0af-bf03-4881-b2fe-dcedb2cb4a60/undici/node_modules/@matteo.collina/tspl/tspl.js:52:35)
       at TestContext.<anonymous> (/home/iojs/tmp/citgm_tmp/e04be0af-bf03-4881-b2fe-dcedb2cb4a60/undici/test/http2.js:348:9)
       at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
       at async Test.run (node:internal/test_runner/test:797:9)
       at async Test.processPendingSubtests (node:internal/test_runner/test:527:7) {
     generatedMessage: true,
     code: 'ERR_ASSERTION',
     actual: '40B8497C4F7F0000:error:0A000460:SSL routines:ssl3_read_bytes:tlsv1 alert no application protocol:../deps/openssl/openssl/ssl/record/rec_layer_s3.c:1605:SSL alert number 120\n',
     expected: 'Client network socket disconnected before secure TLS connection was established',
     operator: 'strictEqual'
   }

@mcollina Pino is also breaking

Details

 FAIL  test/transport/uses-pino-config.test.js
   should be equivalent
   test/transport/uses-pino-config.test.js
   48 |   const result = parseLogs(await readFile(destination))
   49 |
 > 50 |   same(result, [{
      | --^
   51 |     severityText: 'custom',
   52 |     body: 'foo',
   53 |     attributes: {
   --- expected
   +++ actual
   @@ -7,29 +7,4 @@
          "hostname": "test-digitalocean-debian11-x64-1",
        },
      },
   -  Object {
   -    "severityText": "error",
   -    "body": "bar",
   -    "attributes": Object {
   -      "pid": 852784,
   -      "hostname": "test-digitalocean-debian11-x64-1",
   -    },
   -    "error": Object {
   -      "type": "Error",
   -      "message": "bar",
   -      "stack": String(
   -        Error: bar
   -            at Test.<anonymous> (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-
 af21-30d5803c943f/pino/test/transport/uses-pino-config.test.js:44:17)
   -            at TapWrap.runInAsyncScope (node:async_hooks:206:9)
   -            at Test.cb (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21-30d5
 803c943f/pino/node_modules/libtap/lib/test.js:127:40)
   -            at /home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21-30d5803c943f/
 pino/node_modules/libtap/lib/test.js:369:21
   -            at Test.main (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21-30
 d5803c943f/pino/node_modules/libtap/lib/test.js:376:7)
   -            at TapWrap.runInAsyncScope (node:async_hooks:206:9)
   -            at Test.runMain (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21
 -30d5803c943f/pino/node_modules/libtap/lib/base.js:178:15)
   -            at /home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-af21-30d5803c943f/
 pino/node_modules/libtap/lib/test.js:490:13
   -            at TAP.writeSubComment (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-43
 55-af21-30d5803c943f/pino/node_modules/libtap/lib/test.js:561:5)
   -            at Test.<anonymous> (/home/iojs/tmp/citgm_tmp/8bb15848-eb8d-4355-
 af21-30d5803c943f/pino/node_modules/libtap/lib/test.js:489:14)
   -      ),
   -    },
   -  },
    ]

@nodejs/releasers wdyt? CITGM says +81 but I cannot access the previous run

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

metcoder95 commented Nov 20, 2024

Copy link

Copy Markdown

Member

We have this issue in the past and decided to ignore it; the thing is that OpenSSL changes the handling of the non-supported protocol. If we can ensure that will be the message from now on or add a wrapper around, we are good to go.

Otherwise, ignoring the test for now should be ok.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 approved these changes

Nov 20, 2024

View reviewed changes

aduh95 left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to proceed unless maintainers of those projects ask us not to

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

richardlau mentioned this pull request

Nov 20, 2024

Windows GitHub Actions changes required #55929

Closed

marco-ippolito commented Nov 20, 2024

Copy link

Copy Markdown

Member Author

As soon as release CI is ready I will proceed.

richardlau reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito mentioned this pull request

Nov 20, 2024

2024-11-20, Version 23.3.0 (Current), @RafaelGSS #55921

Merged

richardlau approved these changes

Nov 20, 2024

View reviewed changes

marco-ippolito merged commit 7017811 into v20.x

Nov 20, 2024

mertcanaltin approved these changes

Nov 20, 2024

View reviewed changes

marco-ippolito deleted the v20.18.1-proposal branch

November 20, 2024 14:26

marco-ippolito added a commit that referenced this pull request

Nov 20, 2024


          Working on v20.18.2

97291c2

PR-URL: #55879

marco-ippolito added a commit that referenced this pull request

Nov 20, 2024


          2024-11-20, Version 20.18.1 'Iron' (LTS)

81f7c76

Notable changes:

doc:
  * add abmusse to collaborators (Abdirahim Musse) #55086

PR-URL: #55879

marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request

Nov 20, 2024


          Blog: v20.18.1 release post

5567e39

Refs: nodejs/node#55879

marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request

Nov 20, 2024


          Blog: v20.18.1 release post

e0710f3

Refs: nodejs/node#55879

marco-ippolito mentioned this pull request

Nov 20, 2024

Blog: v20.18.1 release post nodejs/nodejs.org#7254

Merged

marco-ippolito added a commit to nodejs/nodejs.org that referenced this pull request

Nov 20, 2024


          Blog: v20.18.1 release post

1369c4b

Refs: nodejs/node#55879

github-merge-queue Bot pushed a commit to nodejs/nodejs.org that referenced this pull request

Nov 20, 2024


          Blog: v20.18.1 release post (#7254)

635f2b3

Refs: nodejs/node#55879

richardlau mentioned this pull request

Nov 20, 2024

Test failures with OpenSSL 3.2.2 #53382

Closed

26 tasks done

bmuenzenmeyer pushed a commit to nodejs/nodejs.org that referenced this pull request

Nov 21, 2024


          Blog: v20.18.1 release post (#7254)

ee33050

Refs: nodejs/node#55879

Reviewers

richardlau

richardlau approved these changes

aduh95

aduh95 approved these changes

RafaelGSS

RafaelGSS approved these changes

+1 more reviewer

mertcanaltin

mertcanaltin approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci

PRs that need a full CI run.

release

Issues and PRs related to Node.js releases.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

20 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

marco-ippolito commented Nov 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

2024-11-20, Version 20.18.1 'Iron' (LTS), @marco-ippolito

Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Nov 16, 2024

Uh oh!

nodejs-github-bot commented Nov 16, 2024

Uh oh!

aduh95 commented Nov 16, 2024

Uh oh!

marco-ippolito commented Nov 16, 2024

Uh oh!

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

nodejs-github-bot commented Nov 19, 2024 • edited by marco-ippolito Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marco-ippolito commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metcoder95 commented Nov 20, 2024

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

marco-ippolito commented Nov 20, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

marco-ippolito commented Nov 16, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Nov 19, 2024 •

edited by marco-ippolito

Loading

Uh oh!

There was an error while loading. Please reload this page.

marco-ippolito commented Nov 20, 2024 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.