GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — quic: more implementation by jasnell · Pull Request #56328 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Dec 20, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There's a lot more to do to get things fully working but this makes more incremental progress.

Several key bits:

  • This adds the --experimental-quic CLI flag and the node:quic module behind it.
  • This also starts to add the quic.md documentation
  • Look at test-quic-handshake for a basic idea of the current state of the API. It's still rough but it's enough to start getting feedback.

Key question for reviewers: Looking at the API documented in quic.md and demonstrated in test-quic-handshake, what API do you want to see here? This is focusing ONLY on the QUIC API at this point and does NOT touch on the http3 API.

For the server-side, the API is essentially:

const { QuicEndpoint } = require('node:quic');
const keys = getKeysSomehow();
const certs = getCertsSomehow();
const endpoint = new QuicEndpoint();
endpoint.listen((session) => {
  session.onstream = (stream) => {
    stream.setOutbound(Buffer.from('hello world'));
    stream.closed.then(() => {
      session.close();
    });
    readStreamSomehow(stream);
  });
}, { keys, certs });

For the client side it is essentially:

const { QuicEndpoint } = require('node:quic');
const endpoint = new QuicEndpoint();
const session = endpoint.connect('123.123.123.123:8888');
const stream = session.openUnidirectionalStream({
  body: Buffer.from('hello there');
});
await stream.closed;
endpoint.close();
session.close();

The API still feels rather awkward. For review, contrast with what Deno is doing here: https://github.com/denoland/deno/pull/21942/files#diff-1645ba9a2a2aac4440671da62b81ab9a723f50faffff0d0e8d016a1f991961a3

At this point there are bugs in the implementation still, yes, but let's focus on the API design at the moment. Please focus review comments on that.

A couple of bits to consider for the reivew...

In this API design, the QuicEndpoint represents the local binding the local UDP port. It supports being both a server and client at the same time. Use can be a bit awkward though so we need to carefully review. Specifically, a single QuicEndpoint can support any number of QuicSessions (both client and server at the same time). This gives maximum flexibility but means a more complicated API. For example, let's take a closer look at the client side example:

const endpoint = new QuicEndpoint();
const session = endpoint.connect('123.123.123.123:8888');

// We're opening the stream here before the session handshake has had a chance to start.
// The actual underlying QUIC stream will be opened as soon as the TLS handshake completes.
// This is good in that it allows us to optimistically provide data to the pending stream so that
// the underlying implementation can start sending data as early and as quickly as possible.
session.openUnidirectionalStream({ body: Buffer.from('hello there'); });

// However, if I close the session or endpoint here, then the pending stream will be canceled.
// That is, while the `open...Stream(...)` variations have a pending effect, close() and destroy()
// do not.

// `session.close()` is defined as a graceful close. In other words, it should destroy the session
// only after all open streams are closed. Should pending streams count as opened streams?
// Should close() wait to close the session only when the pending stream has been opened
// then closed? I think the answer is yes but let's confirm.

await Promise.all([endpoint.close(), session.close()]);

The key question here is: does it make sense to expose QuicEndpoint like this? If we look at the Deno API, as an alternative, we see something like:

const conn = await Deno.connectQuic({
      hostname: "localhost",
      port: listener.addr.port,
      alpnProtocols: ["deno-test"],
    });
const stream = await conn.createUnidirectionalStream();
const writer = stream.writable.getWriter();
const enc = new TextEncoder();
await writer.write(enc.encode('hello there'));
await conn.close({ closeCode: 0, reason: '' });

In Deno's API, they've effectively hidden QuicEndpoint under their notion of QuicConn. While it might be the case that the same underlying UDP port is used when ever connectQuic(...) is called, if it is that ends up being an internal implementation detail and not something that is exposed to users. Which approach is better? Exposing QuicEndpoint the way that I am means we have more flexibility but also more complexity that may not be worth it?

Alternatively, we could go with a simplified API where every call to connect(...) uses a separate QuicEndpoint, so, for instance:

import { connect } from 'node:quic';

const client = connect('123.123.123.123:8888');
client.openUnidirectionalStream({ body: Buffer.from('hello there'); });
await client.close();

We could still allow for direct reuse of QuicEndpoint in this model by allowing a QuicEndpoint instance to be passed as an option to connect(...), like:

import { connect, QuicEndpoint } from 'node:quic';

const endpoint = new QuicEndpoint();

const conn1 = connect('123.123.123.123:1234', { endpoint });
const conn2 = connect('123.123.123.123:4321', { endpoint });

await Promise.all([ conn1.close(), conn2.close() ]);

// notice I'm not closing the endpoint here...  The sessions will have been closed/destroyed...
// should the endpoint be closed here? If I don't close it, should the node.js process hang because
// the endpoint is still actively bound to the local udp port?

But the question here, whenever client connections are sharing a single endpoint is (a) when should the endpoint be closed, (b) should it ever be closed automatically?, (c) should it be unref'd so that if there are no active sessions but the client-side endpoint has not yet been closed, should it keep the node.js process from exiting?

Basically, looking for feedback on the API design so if you have other ideas for what color to paint the bikeshed, now is the time to discuss it.

@Qard @mcollina @anonrig @nodejs/quic

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ShenHongFei, bricss, and remorses reacted with thumbs up emoji bricss and espoal reacted with hooray emoji ShenHongFei, H4ad, tonivj5, bricss, pimterry, and arturgawlik reacted with heart emoji bricss and tonivj5 reacted with rocket emoji
All reactions
  • 👍 3 reactions
  • 🎉 2 reactions
  • ❤️ 6 reactions
  • 🚀 2 reactions
@nodejs-github-bot

nodejs-github-bot commented Dec 20, 2024

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/loaders
  • @nodejs/net
  • @nodejs/startup
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Dec 20, 2024
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnell force-pushed the get-quic-working-part2 branch from 4c96c67 to bfaf60f Compare December 20, 2024 19:14
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnell force-pushed the get-quic-working-part2 branch from bfaf60f to c90a6d7 Compare December 20, 2024 19:47
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell changed the title quic: handle control streams correctly quic: more implementation Dec 20, 2024
@jasnell
jasnell force-pushed the get-quic-working-part2 branch 2 times, most recently from 0175f17 to 2570ff3 Compare December 20, 2024 20:58
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@codecov

This comment was marked as outdated.

Sign in to view
@jasnell
jasnell marked this pull request as draft December 21, 2024 18:06
@pimterry

pimterry commented Dec 24, 2024

Copy link
Copy Markdown
Member

This is very exciting! Nice work @jasnell, it's great to see the progress here. Some thoughts:

It feels like this API is sort-of upside-down, compared to others we have. Elsewhere (dgram and net + derivatives) you create a client/session, and you then specify the local binding (e,g. socket.connect({ ... localPort ... }) or dgramSocket.bind(...)) via various parameters in setup. Here you create a representation of the local endpoint first, and then you build the client/server from that. I understand it makes sense from an internal implementation POV and for advanced cases, but it doesn't feel consistent with other APIs or the mental model that (imo) most users will have.

There's also no representation of a 'server' in this API. There's only the endpoint itself (not quite the same). This means there's no good place to hang APIs to manage the state tied to the listening process - e.g. there seems to be no 'stop listening' API right now other than closing the endpoint completely (which also kills client connections), and there's no way to independently listen to any server events other than the initially registered callback. I suspect as this API develops, not having a server representation in the model will become inconvenient.

I think initially users will reasonably expect something with roughly the shape & semantics of the simple example above:

import { connect } from 'node:quic';

const client = connect('123.123.123.123:8888'); // <-- Implicit create an endpoint
client.openUnidirectionalStream({ body: Buffer.from('hello there'); });
await client.close();

And I also think something roughly equivalent applies on the server-side too:

import { createServer } from 'node:quic';

const keys = getKeysSomehow();
const certs = getCertsSomehow();

const server = createServer({ keys, certs }, (session) => {
  session.onstream = (stream) => {
    stream.setOutbound(Buffer.from('hello world'));
    stream.closed.then(() => {
      session.close();
    });
    readStreamSomehow(stream);
  };
});

await server.listen('123.123.123.123:8888'); // <-- Implicit create an endpoint
// ...
await server.close();

Supporting advanced use cases too is good but I really think a lot of people are going to come to this expecting that kind of API to be available, and making that possible will be hugely helpful.

That's not to say that the endpoint model doesn't add something, it's just that AFAICT for the most common use cases it'll be slightly confusing extra complexity initially. Do we have any good examples of when & how direct endpoint control will be useful for users? How common is the use case where sharing one endpoint between multiple client connections and/or a server is important?

For cases that do need endpoint control, I'd suggest exposing that optionally but flipping the API, so that an endpoint becomes a parameter of clients/servers rather than being the source of them (similar to the last example in the description). That means for advanced use cases, this would look (very roughly) like:

import { QuicEndpoint, connect, createServer } from 'node:quic';

const endpoint = new QuicEndpoint();

const client = connect('123.123.123.123:8888', { endpoint });
client.openUnidirectionalStream({ body: Buffer.from('hello there'); });
await client.close();

const server = createServer();
server.listen('123.123.123.123:8888', { endpoint });

The internal endpoint model remains the same I think, this is intended mostly as a shift in how that's exposed and where the methods go, with implicit endpoint creation whenever it's not specified.

Regarding closing endpoints, I think in the simple case users definitely won't expect to close this themselves (because the endpoint is invisible) so tidy auto-closing is unavoidable. Even in the advanced case, I can see reasons to want both auto or manual endpoint closing. How about:

  • We add an autoClose boolean for endpoints. If set, when the last session and server (i.e. listen binding) is closed, so the Endpoint becomes unused, close it automatically.
  • Set autoClose to true when implicitly creating an endpoint in connect/listen, but default to false when creating a QuicEndpoint manually.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell
jasnell force-pushed the get-quic-working-part2 branch 12 times, most recently from 4fb584b to 945054a Compare December 28, 2024 05:16
@jasnell

jasnell commented Dec 28, 2024 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

The API has been updated based on discussions with multiple folks and a review of what deno is doing with their quic api...

For a server it is now....

import { listen } from 'node:quic';

async function consume(stream) {
  for await (const chunk of stream.readable) {
    ///...
  }
  await stream.session.close();
}

listen((server) => {
  server.onstream = async (stream) => {
    consume(stream);
  };
});

For a client it is essentially...

import { connect } from 'node:quic';

const client = await connect('123.123.123.123:8888');
client.createUnidirectionalStream({ body: Buffer.from('hello world') });
await client.close();

There's a lot more to it, of course, but this is the start.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell
jasnell force-pushed the get-quic-working-part2 branch from 945054a to f483935 Compare December 28, 2024 07:25
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. quic Issues and PRs related to the QUIC transport implementation. and removed needs-ci PRs that need a full CI run. labels Jan 3, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Jan 3, 2025 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64325/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell added a commit that referenced this pull request Jan 6, 2025
@jasnell
src, quic: refine more of the quic implementation
062ae6f 
Signed-off-by: James M Snell <[email protected]>
PR-URL: #56328
Reviewed-By: Yagiz Nizipli <[email protected]>
@jasnell

jasnell commented Jan 6, 2025

Copy link
Copy Markdown
Member Author

Landed in 062ae6f
trivikr and pimterry reacted with rocket emoji
All reactions
  • 🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Jan 6, 2025
@achingbrain

achingbrain commented Jan 13, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Sorry this comment is a little late (please let me know if I should open a new issue), but can the QuicStream class please have a .writable property like the streams from the WebTransport API?

That is, at the moment I have to pass a .body option of ArrayBuffer/ArrayBufferView/Blob to createBidirectionalStream/createUnidirectionalStream which means I have to assemble all data in-memory ahead of time instead of streaming it as it arrives.

My (hopefully uncontentious) proposal would be for bidi streams to have a writable property:

import { connect } from 'node:quic';

const client = await connect('123.123.123.123:8888');
const stream = await client.createBidirectionalStream();
const writer = stream.writable.getWriter();
writer.write(Buffer.from('hello world'));
await writer.close();

and for uni streams to be a writable (again, lifted straight from the WebTransport API):

import { connect } from 'node:quic';

const client = await connect('123.123.123.123:8888');
const stream = await client.createUnidirectionalStream();
const writer = stream.getWriter();
writer.write(Buffer.from('hello world'));
await writer.close();

Thanks so much for landing this, it's really exciting to see progress on QUIC!

(I'm happy to have a go at a PR implementing the above, if it's helpful)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos pushed a commit that referenced this pull request Jan 13, 2025
@jasnell @targos
src, quic: refine more of the quic implementation
c74603f 
Signed-off-by: James M Snell <[email protected]>
PR-URL: #56328
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jan 28, 2025
2025-01-30, Version 23.7.0 (Current) #56800
Merged
@aduh95 aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 30, 2025
aduh95
aduh95 reviewed Jan 30, 2025
View reviewed changes
Comment thread src/node_builtins.cc
"internal/quic/quic", "internal/quic/symbols", "internal/quic/stats",
"internal/quic/state",
#endif // !NODE_OPENSSL_HAS_QUIC
"quic", // Experimental.

@aduh95 aduh95 Jan 30, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we expose it only when Node.js is compiled with QUIC support, and the runtime flag --experimental-quic is passed? It looks like it's being listed in node -p 'require("node:module").builtinModules', which is confusing

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ljharb and RafaelGSS reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
targos pushed a commit that referenced this pull request Feb 2, 2025
@jasnell @targos
src, quic: refine more of the quic implementation
a9d80d4 
Signed-off-by: James M Snell <[email protected]>
PR-URL: #56328
Reviewed-By: Yagiz Nizipli <[email protected]>
@github-actions github-actions Bot mentioned this pull request Feb 11, 2025
2025-02-13, Version 23.8.0 (Current) #57005
Merged
nodejs-github-bot added a commit that referenced this pull request Feb 11, 2025
@nodejs-github-bot
2025-02-12, Version 23.8.0 (Current)
4fe8da4 
Notable changes:

crypto:
  * (SEMVER-MINOR) support --use-system-ca on Windows (Joyee Cheung) #56833
  * (SEMVER-MINOR) added support for reading certificates from macOS system store (Tim Jacomb) #56599
deps:
  * update timezone to 2025a (Node.js GitHub Bot) #56876
  * (SEMVER-MINOR) update ada to v3.0.1 (Yagiz Nizipli) #56452
deps,tools:
  * (SEMVER-MINOR) add zstd 1.5.6 (Jan Krems) #52100
sqlite:
  * (SEMVER-MINOR) allow returning `ArrayBufferView`s from user-defined functions (René) #56790
src:
  * set signal inspector io thread name (RafaelGSS) #56416
  * set thread name for main thread and v8 worker (RafaelGSS) #56416
  * set worker thread name using worker.name (RafaelGSS) #56416
  * use a default thread name for inspector (RafaelGSS) #56416
src, quic:
  * (SEMVER-MINOR) refine more of the quic implementation (James M Snell) #56328
test:
  * (SEMVER-MINOR) add WPT for URLPattern (Yagiz Nizipli) #56452
url:
  * (SEMVER-MINOR) add URLPattern implementation (Yagiz Nizipli) #56452
zlib:
  * (SEMVER-MINOR) add zstd support (Jan Krems) #52100

PR-URL: #57005
tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Feb 25, 2025
ECG Bot @tmeijn
build(deps): update node to v23.8.0
c6210ee 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [node](https://nodejs.org) ([source](https://github.com/nodejs/node)) | minor | `23.7.0` -> `23.8.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>nodejs/node (node)</summary>

### [`v23.8.0`](https://github.com/nodejs/node/releases/tag/v23.8.0): 2025-02-13, Version 23.8.0 (Current), @&#8203;targos

[Compare Source](nodejs/node@v23.7.0...v23.8.0)

##### Notable Changes

##### Support for using system CA certificates store on macOS and Windows

This version adds the `--use-system-ca` command-line flag, which instructs Node.js
to use the trusted CA certificates present in the system store along with
the `--use-bundled-ca`, `--use-openssl-ca` options.

This option is available on macOS and Windows for now.

Contributed by Tim Jacomb in [#&#8203;56599](nodejs/node#56599)
and Joyee Cheung in [#&#8203;56833](nodejs/node#56833).

##### Introduction of the URL Pattern API

An implementation of the [URL Pattern API](https://developer.mozilla.org/en-US/docs/Web/API/URL_Pattern_API)
is now available.

The `URLPattern` constructor is exported from the `node:url` module and will be
available as a global in Node.js 24.

Contributed by Yagiz Nizipli and Daniel Lemire in [#&#8203;56452](nodejs/node#56452).

##### Support for the zstd compression algorithm

Node.js now includes support for the Zstandard (zstd) compression algorithm.
Various APIs have been added to the `node:zlib` module for both compression and decompression
of zstd streams.

Contributed by Jan Krems in [#&#8203;52100](nodejs/node#52100).

##### Node.js thread names

Threads created by the Node.js process are now named to improve the debugging experience.
Worker threads will use the `name` option that can be passed to the `Worker` constructor.

Contributed by Rafael Gonzaga in [#&#8203;56416](nodejs/node#56416).

##### Timezone data has been updated to 2025a

Included changes:

-   Paraguay adopts permanent -03 starting spring 2024.
-   Improve pre-1991 data for the Philippines.

##### Other Notable Changes

-   \[[`39997867cf`](nodejs/node@39997867cf)] - **(SEMVER-MINOR)** **sqlite**: allow returning `ArrayBufferView`s from user-defined functions (René) [#&#8203;56790](nodejs/node#56790)

##### Commits

-   \[[`0ee9c34d63`](nodejs/node@0ee9c34d63)] - **benchmark**: add simple parse and test benchmarks for URLPattern (James M Snell) [#&#8203;56882](nodejs/node#56882)
-   \[[`b3f2045d14`](nodejs/node@b3f2045d14)] - **build**: gyp exclude libm linking on macOS (deepak1556) [#&#8203;56901](nodejs/node#56901)
-   \[[`e0dd9aefd6`](nodejs/node@e0dd9aefd6)] - **build**: remove explicit linker call to libm on macOS (deepak1556) [#&#8203;56901](nodejs/node#56901)
-   \[[`52399da780`](nodejs/node@52399da780)] - **build**: link with Security.framework in GN build (Cheng) [#&#8203;56895](nodejs/node#56895)
-   \[[`582b9221c9`](nodejs/node@582b9221c9)] - **build**: do not put commands in sources variables (Cheng) [#&#8203;56885](nodejs/node#56885)
-   \[[`ea61b956e9`](nodejs/node@ea61b956e9)] - **build**: add double quotes around <(python) (Luigi Pinca) [#&#8203;56826](nodejs/node#56826)
-   \[[`14236ef778`](nodejs/node@14236ef778)] - **build**: add build option suppress_all_error_on_warn (Michael Dawson) [#&#8203;56647](nodejs/node#56647)
-   \[[`dfd3f430f3`](nodejs/node@dfd3f430f3)] - **build,win**: enable ccache (Stefan Stojanovic) [#&#8203;56847](nodejs/node#56847)
-   \[[`3e207bd9ec`](nodejs/node@3e207bd9ec)] - **(SEMVER-MINOR)** **crypto**: support --use-system-ca on Windows (Joyee Cheung) [#&#8203;56833](nodejs/node#56833)
-   \[[`fe2694a992`](nodejs/node@fe2694a992)] - **crypto**: fix X509\* leak in --use-system-ca (Joyee Cheung) [#&#8203;56832](nodejs/node#56832)
-   \[[`60039a2c36`](nodejs/node@60039a2c36)] - **crypto**: add api to get openssl security level (Michael Dawson) [#&#8203;56601](nodejs/node#56601)
-   \[[`39a474f7c0`](nodejs/node@39a474f7c0)] - **(SEMVER-MINOR)** **crypto**: added support for reading certificates from macOS system store (Tim Jacomb) [#&#8203;56599](nodejs/node#56599)
-   \[[`144bee8067`](nodejs/node@144bee8067)] - **deps**: update zlib to 1.3.0.1-motley-788cb3c (Node.js GitHub Bot) [#&#8203;56655](nodejs/node#56655)
-   \[[`7fd39e3a79`](nodejs/node@7fd39e3a79)] - **deps**: update sqlite to 3.49.0 (Node.js GitHub Bot) [#&#8203;56654](nodejs/node#56654)
-   \[[`d698cb5434`](nodejs/node@d698cb5434)] - **deps**: update amaro to 0.3.2 (marco-ippolito) [#&#8203;56916](nodejs/node#56916)
-   \[[`dbd09067c0`](nodejs/node@dbd09067c0)] - **deps**: V8: cherry-pick [`9ab4059`](nodejs/node@9ab40592f697) (Levi Zim) [#&#8203;56781](nodejs/node#56781)
-   \[[`ee33ef3aa6`](nodejs/node@ee33ef3aa6)] - **deps**: update cjs-module-lexer to 2.0.0 (Michael Dawson) [#&#8203;56855](nodejs/node#56855)
-   \[[`c0542557d0`](nodejs/node@c0542557d0)] - **deps**: update timezone to 2025a (Node.js GitHub Bot) [#&#8203;56876](nodejs/node#56876)
-   \[[`d67cb1f9bb`](nodejs/node@d67cb1f9bb)] - **deps**: update simdjson to 3.12.0 (Node.js GitHub Bot) [#&#8203;56874](nodejs/node#56874)
-   \[[`70b04b4314`](nodejs/node@70b04b4314)] - **deps**: update googletest to [`e235eb3`](nodejs/node@e235eb3) (Node.js GitHub Bot) [#&#8203;56873](nodejs/node#56873)
-   \[[`e11cda003f`](nodejs/node@e11cda003f)] - **(SEMVER-MINOR)** **deps**: update ada to v3.0.1 (Yagiz Nizipli) [#&#8203;56452](nodejs/node#56452)
-   \[[`8743ef525d`](nodejs/node@8743ef525d)] - **deps**: update simdjson to 3.11.6 (Node.js GitHub Bot) [#&#8203;56250](nodejs/node#56250)
-   \[[`0f553e5575`](nodejs/node@0f553e5575)] - **deps**: update amaro to 0.3.1 (Node.js GitHub Bot) [#&#8203;56785](nodejs/node#56785)
-   \[[`380a8d8d2f`](nodejs/node@380a8d8d2f)] - **(SEMVER-MINOR)** **deps,tools**: add zstd 1.5.6 (Jan Krems) [#&#8203;52100](nodejs/node#52100)
-   \[[`66898a7c3b`](nodejs/node@66898a7c3b)] - **doc**: update history of stream.Readable.toWeb() (Jimmy Leung) [#&#8203;56928](nodejs/node#56928)
-   \[[`9e29416e12`](nodejs/node@9e29416e12)] - **doc**: make MDN links to global classes more consistent (Antoine du Hamel) [#&#8203;56924](nodejs/node#56924)
-   \[[`6bc270728a`](nodejs/node@6bc270728a)] - **doc**: make MDN links to global classes more consistent in `assert.md` (Antoine du Hamel) [#&#8203;56920](nodejs/node#56920)
-   \[[`00da003171`](nodejs/node@00da003171)] - **doc**: make MDN links to global classes more consistent (Antoine du Hamel) [#&#8203;56923](nodejs/node#56923)
-   \[[`d90198793a`](nodejs/node@d90198793a)] - **doc**: make MDN links to global classes more consistent in `util.md` (Antoine du Hamel) [#&#8203;56922](nodejs/node#56922)
-   \[[`5f4377a759`](nodejs/node@5f4377a759)] - **doc**: make MDN links to global classes more consistent in `buffer.md` (Antoine du Hamel) [#&#8203;56921](nodejs/node#56921)
-   \[[`7353266b50`](nodejs/node@7353266b50)] - **doc**: improve type stripping documentation (Marco Ippolito) [#&#8203;56916](nodejs/node#56916)
-   \[[`888d2acc3a`](nodejs/node@888d2acc3a)] - **doc**: specificy support for erasable ts syntax (Marco Ippolito) [#&#8203;56916](nodejs/node#56916)
-   \[[`3c082d43bc`](nodejs/node@3c082d43bc)] - **doc**: update post sec release process (Rafael Gonzaga) [#&#8203;56907](nodejs/node#56907)
-   \[[`f0bf35d3c5`](nodejs/node@f0bf35d3c5)] - **doc**: update websocket link to avoid linking to self (Chengzhong Wu) [#&#8203;56897](nodejs/node#56897)
-   \[[`373dbb0e6c`](nodejs/node@373dbb0e6c)] - **doc**: mark `--env-file-if-exists` flag as experimental (Juan José) [#&#8203;56893](nodejs/node#56893)
-   \[[`d436888cc8`](nodejs/node@d436888cc8)] - **doc**: fix typo in cjs example of `util.styleText` (Deokjin Kim) [#&#8203;56769](nodejs/node#56769)
-   \[[`91638eeb4a`](nodejs/node@91638eeb4a)] - **doc**: clarify sqlite user-defined function behaviour (René) [#&#8203;56786](nodejs/node#56786)
-   \[[`bab9c4d331`](nodejs/node@bab9c4d331)] - **events**: getMaxListeners detects 0 listeners (Matthew Aitken) [#&#8203;56807](nodejs/node#56807)
-   \[[`ccaf7fe737`](nodejs/node@ccaf7fe737)] - **fs**: make `FileHandle.readableWebStream` always create byte streams (Ian Kerins) [#&#8203;55461](nodejs/node#55461)
-   \[[`974cec7a0a`](nodejs/node@974cec7a0a)] - **http**: be more generational GC friendly (ywave620) [#&#8203;56767](nodejs/node#56767)
-   \[[`be00058712`](nodejs/node@be00058712)] - **inspector**: add Network.Initiator in inspector protocol (Chengzhong Wu) [#&#8203;56805](nodejs/node#56805)
-   \[[`31293a4b09`](nodejs/node@31293a4b09)] - **inspector**: fix GN build (Cheng) [#&#8203;56798](nodejs/node#56798)
-   \[[`91a302356b`](nodejs/node@91a302356b)] - **inspector**: fix StringUtil::CharacterCount for unicodes (Chengzhong Wu) [#&#8203;56788](nodejs/node#56788)
-   \[[`3b305f25f2`](nodejs/node@3b305f25f2)] - **lib**: filter node:quic from builtinModules when flag not used (James M Snell) [#&#8203;56870](nodejs/node#56870)
-   \[[`f06ee4c54a`](nodejs/node@f06ee4c54a)] - **meta**: bump `actions/upload-artifact` from 4.4.3 to 4.6.0 (dependabot\[bot]) [#&#8203;56861](nodejs/node#56861)
-   \[[`d230bc3b3c`](nodejs/node@d230bc3b3c)] - **meta**: bump `actions/setup-node` from 4.1.0 to 4.2.0 (dependabot\[bot]) [#&#8203;56868](nodejs/node#56868)
-   \[[`d4ecfa745e`](nodejs/node@d4ecfa745e)] - **meta**: move one or more collaborators to emeritus (Node.js GitHub Bot) [#&#8203;56889](nodejs/node#56889)
-   \[[`698c56bb94`](nodejs/node@698c56bb94)] - **meta**: add [@&#8203;nodejs/url](https://github.com/nodejs/url) as codeowner (Chengzhong Wu) [#&#8203;56783](nodejs/node#56783)
-   \[[`a274b28857`](nodejs/node@a274b28857)] - **module**: fix require.resolve() crash on non-string paths (Aditi) [#&#8203;56942](nodejs/node#56942)
-   \[[`4e3052aeee`](nodejs/node@4e3052aeee)] - **quic**: fixup errant LocalVector usage (James M Snell) [#&#8203;56564](nodejs/node#56564)
-   \[[`dfc61f7bb7`](nodejs/node@dfc61f7bb7)] - **readline**: fix unresolved promise on abortion (Daniel Venable) [#&#8203;54030](nodejs/node#54030)
-   \[[`9e60501f5e`](nodejs/node@9e60501f5e)] - **sqlite**: fix coverity warnings related to backup() (Colin Ihrig) [#&#8203;56961](nodejs/node#56961)
-   \[[`1913a4aabc`](nodejs/node@1913a4aabc)] - **sqlite**: restore changes from [#&#8203;55373](nodejs/node#55373) (Colin Ihrig) [#&#8203;56908](nodejs/node#56908)
-   \[[`8410c955b7`](nodejs/node@8410c955b7)] - **sqlite**: fix use-after-free in StatementSync due to premature GC (Divy Srivastava) [#&#8203;56840](nodejs/node#56840)
-   \[[`01d732d629`](nodejs/node@01d732d629)] - **sqlite**: handle conflicting SQLite and JS errors (Colin Ihrig) [#&#8203;56787](nodejs/node#56787)
-   \[[`39997867cf`](nodejs/node@39997867cf)] - **(SEMVER-MINOR)** **sqlite**: allow returning `ArrayBufferView`s from user-defined functions (René) [#&#8203;56790](nodejs/node#56790)
-   \[[`8dc637681a`](nodejs/node@8dc637681a)] - **sqlite, test**: expose sqlite online backup api (Edy Silva) [#&#8203;56253](nodejs/node#56253)
-   \[[`cfea53eccc`](nodejs/node@cfea53eccc)] - **src**: use `args.This()` in zlib (Michaël Zasso) [#&#8203;56988](nodejs/node#56988)
-   \[[`6b398d6d0b`](nodejs/node@6b398d6d0b)] - **src**: replace `SplitString` with built-in (Yagiz Nizipli) [#&#8203;54990](nodejs/node#54990)
-   \[[`fbb32e0a08`](nodejs/node@fbb32e0a08)] - **src**: add nullptr handling for `NativeKeyObject` (Burkov Egor) [#&#8203;56900](nodejs/node#56900)
-   \[[`83ff7be9fd`](nodejs/node@83ff7be9fd)] - **src**: disallow copy/move fns/constructors (Yagiz Nizipli) [#&#8203;56811](nodejs/node#56811)
-   \[[`63611d0331`](nodejs/node@63611d0331)] - **src**: add a hard dependency v8\_inspector_headers (Chengzhong Wu) [#&#8203;56805](nodejs/node#56805)
-   \[[`3d957d135c`](nodejs/node@3d957d135c)] - **src**: improve error handling in encoding_binding.cc (James M Snell) [#&#8203;56915](nodejs/node#56915)
-   \[[`9e9ac3ccd8`](nodejs/node@9e9ac3ccd8)] - **src**: avoid copy by using std::views::keys (Yagiz Nizipli) [#&#8203;56080](nodejs/node#56080)
-   \[[`086cdc297a`](nodejs/node@086cdc297a)] - **src**: remove obsolete NoArrayBufferZeroFillScope (James M Snell) [#&#8203;56913](nodejs/node#56913)
-   \[[`915d7aeb37`](nodejs/node@915d7aeb37)] - **src**: set signal inspector io thread name (RafaelGSS) [#&#8203;56416](nodejs/node#56416)
-   \[[`f4b086d29d`](nodejs/node@f4b086d29d)] - **src**: set thread name for main thread and v8 worker (RafaelGSS) [#&#8203;56416](nodejs/node#56416)
-   \[[`3579143630`](nodejs/node@3579143630)] - **src**: set worker thread name using worker.name (RafaelGSS) [#&#8203;56416](nodejs/node#56416)
-   \[[`736ff5de6d`](nodejs/node@736ff5de6d)] - **src**: use a default thread name for inspector (RafaelGSS) [#&#8203;56416](nodejs/node#56416)
-   \[[`be8e2b4d8f`](nodejs/node@be8e2b4d8f)] - **src**: improve error handling in permission.cc (James M Snell) [#&#8203;56904](nodejs/node#56904)
-   \[[`d6cf0911ee`](nodejs/node@d6cf0911ee)] - **src**: improve error handling in node_sqlite (James M Snell) [#&#8203;56891](nodejs/node#56891)
-   \[[`521fed1bac`](nodejs/node@521fed1bac)] - **src**: improve error handling in node_os by removing ToLocalChecked (James M Snell) [#&#8203;56888](nodejs/node#56888)
-   \[[`c9a99df8e7`](nodejs/node@c9a99df8e7)] - **src**: improve error handling in node_url (James M Snell) [#&#8203;56886](nodejs/node#56886)
-   \[[`5c82ef3ace`](nodejs/node@5c82ef3ace)] - **src**: add memory retainer traits for external types (Chengzhong Wu) [#&#8203;56881](nodejs/node#56881)
-   \[[`edb194b2d5`](nodejs/node@edb194b2d5)] - **src**: prevent URLPattern property accessors from crashing on invalid this (James M Snell) [#&#8203;56877](nodejs/node#56877)
-   \[[`9624049414`](nodejs/node@9624049414)] - **src**: pull in more electron boringssl adjustments (James M Snell) [#&#8203;56858](nodejs/node#56858)
-   \[[`f8910e384d`](nodejs/node@f8910e384d)] - **src**: make multiple improvements to node_url_pattern (James M Snell) [#&#8203;56871](nodejs/node#56871)
-   \[[`94a0237b18`](nodejs/node@94a0237b18)] - **src**: clean up some obsolete crypto methods (James M Snell) [#&#8203;56792](nodejs/node#56792)
-   \[[`b240ca67b9`](nodejs/node@b240ca67b9)] - **src**: add check for Bignum in GroupOrderSize (Burkov Egor) [#&#8203;56702](nodejs/node#56702)
-   \[[`45692e9c7c`](nodejs/node@45692e9c7c)] - **src, deps**: port electron's boringssl workarounds (James M Snell) [#&#8203;56812](nodejs/node#56812)
-   \[[`a9d80d43cb`](nodejs/node@a9d80d43cb)] - **(SEMVER-MINOR)** **src, quic**: refine more of the quic implementation (James M Snell) [#&#8203;56328](nodejs/node#56328)
-   \[[`93d0beb6c8`](nodejs/node@93d0beb6c8)] - **src,test**: expand test coverage for urlpattern and fix error (James M Snell) [#&#8203;56878](nodejs/node#56878)
-   \[[`5a9732e1d0`](nodejs/node@5a9732e1d0)] - **test**: improve timeout duration for debugger events (Yagiz Nizipli) [#&#8203;56970](nodejs/node#56970)
-   \[[`60c8fc07ff`](nodejs/node@60c8fc07ff)] - **test**: remove unnecessary syscall to cpuinfo (Yagiz Nizipli) [#&#8203;56968](nodejs/node#56968)
-   \[[`40cdf756e6`](nodejs/node@40cdf756e6)] - **test**: update webstorage wpt (Yagiz Nizipli) [#&#8203;56963](nodejs/node#56963)
-   \[[`de77371a9e`](nodejs/node@de77371a9e)] - **test**: execute shell directly for refresh() (Yagiz Nizipli) [#&#8203;55051](nodejs/node#55051)
-   \[[`f4254b8e70`](nodejs/node@f4254b8e70)] - **test**: automatically sync wpt urlpattern tests (Jonas) [#&#8203;56949](nodejs/node#56949)
-   \[[`a473d3f57a`](nodejs/node@a473d3f57a)] - **test**: update snapshots for amaro v0.3.2 (Marco Ippolito) [#&#8203;56916](nodejs/node#56916)
-   \[[`abca97f7e2`](nodejs/node@abca97f7e2)] - **test**: change jenkins reporter (Carlos Espa) [#&#8203;56808](nodejs/node#56808)
-   \[[`7c9fa11127`](nodejs/node@7c9fa11127)] - **test**: fix race condition in test-child-process-bad-stdio (Colin Ihrig) [#&#8203;56845](nodejs/node#56845)
-   \[[`b8b6e68836`](nodejs/node@b8b6e68836)] - **(SEMVER-MINOR)** **test**: add WPT for URLPattern (Yagiz Nizipli) [#&#8203;56452](nodejs/node#56452)
-   \[[`b6d3d52e20`](nodejs/node@b6d3d52e20)] - **test**: adjust check to use OpenSSL sec level (Michael Dawson) [#&#8203;56819](nodejs/node#56819)
-   \[[`3beac87f92`](nodejs/node@3beac87f92)] - **test**: test-crypto-scrypt.js doesn't need internals (Meghan Denny) [#&#8203;56673](nodejs/node#56673)
-   \[[`3af23a10f3`](nodejs/node@3af23a10f3)] - **test**: set `test-fs-cp` as flaky (Stefan Stojanovic) [#&#8203;56799](nodejs/node#56799)
-   \[[`1146f48f67`](nodejs/node@1146f48f67)] - **test**: search cctest files (Chengzhong Wu) [#&#8203;56791](nodejs/node#56791)
-   \[[`86c199b25a`](nodejs/node@86c199b25a)] - **test**: convert test_encoding_binding.cc to a JS test (Chengzhong Wu) [#&#8203;56791](nodejs/node#56791)
-   \[[`bd5484717c`](nodejs/node@bd5484717c)] - **test**: test-crypto-prime.js doesn't need internals (Meghan Denny) [#&#8203;56675](nodejs/node#56675)
-   \[[`f5f54414e4`](nodejs/node@f5f54414e4)] - **test**: temporary remove resource check from fs read-write (Rafael Gonzaga) [#&#8203;56789](nodejs/node#56789)
-   \[[`c8bd2ba0ad`](nodejs/node@c8bd2ba0ad)] - **test**: mark test-without-async-context-frame flaky on windows (James M Snell) [#&#8203;56753](nodejs/node#56753)
-   \[[`2c2e4a4ae0`](nodejs/node@2c2e4a4ae0)] - **test**: remove unnecessary code (Luigi Pinca) [#&#8203;56784](nodejs/node#56784)
-   \[[`4606a5f79b`](nodejs/node@4606a5f79b)] - **test**: mark `test-esm-loader-hooks-inspect-wait` flaky (Richard Lau) [#&#8203;56803](nodejs/node#56803)
-   \[[`38c77e3462`](nodejs/node@38c77e3462)] - **test**: update WPT for url to [`a23788b`](nodejs/node@a23788b77a) (Node.js GitHub Bot) [#&#8203;56779](nodejs/node#56779)
-   \[[`50ebd5fd31`](nodejs/node@50ebd5fd31)] - **test**: remove duplicate error reporter from ci (Carlos Espa) [#&#8203;56739](nodejs/node#56739)
-   \[[`0c3ae25aec`](nodejs/node@0c3ae25aec)] - **test_runner**: print formatted errors on summary (Pietro Marchini) [#&#8203;56911](nodejs/node#56911)
-   \[[`b5a8a812fb`](nodejs/node@b5a8a812fb)] - **tools**: bump eslint version (dependabot\[bot]) [#&#8203;56869](nodejs/node#56869)
-   \[[`e1f86c1b9d`](nodejs/node@e1f86c1b9d)] - **tools**: remove test-asan/ubsan workflows (Michaël Zasso) [#&#8203;56823](nodejs/node#56823)
-   \[[`405a6678b7`](nodejs/node@405a6678b7)] - **tools**: run macOS test workflow with Xcode 16.1 (Michaël Zasso) [#&#8203;56831](nodejs/node#56831)
-   \[[`16529c130f`](nodejs/node@16529c130f)] - **tools**: update sccache and sccache-action (Michaël Zasso) [#&#8203;56815](nodejs/node#56815)
-   \[[`fe004111ea`](nodejs/node@fe004111ea)] - **tools**: fix license-builder for inspector_protocol (Michaël Zasso) [#&#8203;56814](nodejs/node#56814)
-   \[[`bc97a90176`](nodejs/node@bc97a90176)] - **(SEMVER-MINOR)** **url**: add URLPattern implementation (Yagiz Nizipli) [#&#8203;56452](nodejs/node#56452)
-   \[[`77294d8918`](nodejs/node@77294d8918)] - **util**: enforce shouldColorize in styleText array arg (Marco Ippolito) [#&#8203;56722](nodejs/node#56722)
-   \[[`8e6c191601`](nodejs/node@8e6c191601)] - **zlib**: use modern class syntax for zstd classes (Yagiz Nizipli) [#&#8203;56965](nodejs/node#56965)
-   \[[`a3ca7f37a2`](nodejs/node@a3ca7f37a2)] - **zlib**: make all zstd functions experimental (Yagiz Nizipli) [#&#8203;56964](nodejs/node#56964)
-   \[[`4cc7907738`](nodejs/node@4cc7907738)] - **(SEMVER-MINOR)** **zlib**: add zstd support (Jan Krems) [#&#8203;52100](nodejs/node#52100)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS4xNjkuMyIsInVwZGF0ZWRJblZlciI6IjM5LjE2OS4zIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
mcollina pushed a commit to mcollina/node that referenced this pull request Mar 13, 2025
@jasnell @RafaelGSS
src, quic: refine more of the quic implementation
3159b7c 
Signed-off-by: James M Snell <[email protected]>
PR-URL: nodejs#56328
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Apr 8, 2025
v22.x-staging cherry-pick status #57799
Closed
@RafaelGSS

RafaelGSS commented Apr 11, 2025

Copy link
Copy Markdown
Member

This commit didn't land cleanly on v22.x-staging. It requires a manual backport, so I'm adding a backport-requested label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label Apr 11, 2025
@trivikr

trivikr commented Apr 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Future work on QUIC will be specific to Node.js 24+ since it requires OpenSSL 3.5
Refs: #57281 (comment)

This backport can be skipped.

EDIT: I've removed backport-requested label, and added donr-land labels for 18, 20, 22.
jasnell reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr trivikr added dont-land-on-v20.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. and removed backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. labels Apr 11, 2025
@jasnell

jasnell commented Apr 11, 2025

Copy link
Copy Markdown
Member Author

I actually think a backport PR that removes all of the quic stuff from older versions would probably be ideal.
anonrig, trivikr, and bjohansebas reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin mertcanaltin mentioned this pull request Jun 1, 2026
quic: add missing documentation for stream.stopSending() and stream.r… #63681
Closed
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aduh95 aduh95 aduh95 left review comments
@anonrig anonrig anonrig approved these changes
@mcollina mcollina Awaiting requested review from mcollina
@Qard Qard Awaiting requested review from Qard

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. quic Issues and PRs related to the QUIC transport implementation. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@jasnell @nodejs-github-bot @pimterry @achingbrain @RafaelGSS @trivikr @anonrig @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.