GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: reserve NMV 135 for Electron 36 by dsanders11 · Pull Request #57151 · nodejs/node

Conversation

@dsanders11

@dsanders11 dsanders11 commented Feb 20, 2025

Copy link
Copy Markdown
Contributor

Reserving NMV 135 for Electron 36.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@dsanders11
doc: reserve NMV 135 for Electron 36
9791422
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Feb 20, 2025
UlisesGascon
UlisesGascon approved these changes Feb 20, 2025
View reviewed changes
atlowChemi
atlowChemi approved these changes Feb 20, 2025
View reviewed changes
richardlau
richardlau approved these changes Feb 20, 2025
View reviewed changes
jasnell
jasnell approved these changes Feb 21, 2025
View reviewed changes
lpinca
lpinca approved these changes Feb 21, 2025
View reviewed changes
aymen94
aymen94 approved these changes Feb 21, 2025
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Feb 24, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Feb 24, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 47cd034 into nodejs:main Feb 24, 2025
@nodejs-github-bot

nodejs-github-bot commented Feb 24, 2025

Copy link
Copy Markdown
Collaborator

Landed in 47cd034

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@dsanders11
dsanders11 deleted the patch-2 branch February 24, 2025 20:55
@dsanders11 dsanders11 mentioned this pull request Feb 24, 2025
build: bump NMV to 135 electron/electron#45789
Merged
1 task done
@targos targos added dont-land-on-v18.x dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Feb 25, 2025
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@dsanders11 @RafaelGSS
doc: reserve NMV 135 for Electron 36
4f35d9f
PR-URL: #57151
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@dsanders11 @RafaelGSS
doc: reserve NMV 135 for Electron 36
7a86454
PR-URL: #57151
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@dsanders11 @RafaelGSS
doc: reserve NMV 135 for Electron 36
24c460d
PR-URL: #57151
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@richardlau richardlau richardlau approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@dsanders11 @nodejs-github-bot @jasnell @lpinca @UlisesGascon @richardlau @aymen94 @atlowChemi @targos @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.