GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: add a variant of ToV8Value() by Aditi-1400 · Pull Request #57576 · nodejs/node

Conversation

@Aditi-1400

@Aditi-1400 Aditi-1400 commented Mar 21, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Adds a variant of ToV8Value for array of primitives that do not need to throw during conversion - there is essentially no exceptions that can be thrown then you create an array of integers and you are only dealing with the one-size-fit-all abstraction of ToV8Value.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with eyes emoji
All reactions
  • 👀 1 reaction
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 21, 2025
@Aditi-1400
Aditi-1400 force-pushed the primitive-array branch 2 times, most recently from 565d8b1 to fc7eafe Compare March 21, 2025 14:09
jasnell
jasnell reviewed Mar 21, 2025
View reviewed changes
Comment thread src/util-inl.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Mar 21, 2025
View reviewed changes
Comment thread src/util-inl.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell reviewed Mar 21, 2025
View reviewed changes
Comment thread src/util-inl.h Resolved

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Mar 21, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (922ce9d) to head (d037058).
Report is 411 commits behind head on main.

Files with missing lines Patch % Lines
src/util-inl.h 86.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main   #57576    +/-   ##
========================================
  Coverage   90.23%   90.24%            
========================================
  Files         629      630     +1     
  Lines      184939   185080   +141     
  Branches    36232    36229     -3     
========================================
+ Hits       166885   167020   +135     
- Misses      11011    11031    +20     
+ Partials     7043     7029    -14
Files with missing lines Coverage Δ
src/node_v8.cc 81.72% <100.00%> (+1.00%) ⬆️
src/util-inl.h 84.39% <86.66%> (+1.12%) ⬆️

... and 73 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig requested changes Mar 21, 2025
View reviewed changes

@anonrig anonrig left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a better replacement than what we have right now, and lacks real world usage. We shouldn't introduce new functions that we don't use at all.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss and addaleax reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
@Aditi-1400
src: add a variant of ToV8Value() for primitive arrays
d037058 
Adds a variant of ToV8Value for array of primitives that
do not need to throw during conversion - there is essentially
no exceptions that can be thrown then an array
of integers is created.
@Aditi-1400
Aditi-1400 force-pushed the primitive-array branch from fc7eafe to d037058 Compare April 2, 2025 20:04
jasnell
jasnell approved these changes Apr 5, 2025
View reviewed changes
@jasnell
jasnell requested a review from anonrig April 5, 2025 15:36
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
joyeecheung
joyeecheung approved these changes Apr 10, 2025
View reviewed changes
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 10, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 10, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@joyeecheung

joyeecheung commented Apr 16, 2025

Copy link
Copy Markdown
Member

@anonrig Are you still blocking the PR? It's updated significantly and the helper is being used in a function.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Apr 16, 2025
View reviewed changes
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 16, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 16, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 2, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 2, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@joyeecheung joyeecheung added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 7, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 7, 2025
@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 7, 2025
@nodejs-github-bot

nodejs-github-bot commented May 12, 2025 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66764 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request May 12, 2025
@Aditi-1400 @jasnell
src: add a variant of ToV8Value() for primitive arrays
28cbc4c 
Adds a variant of ToV8Value for array of primitives that
do not need to throw during conversion - there is essentially
no exceptions that can be thrown then an array
of integers is created.

PR-URL: #57576
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@jasnell

jasnell commented May 12, 2025

Copy link
Copy Markdown
Member

Landed in 28cbc4c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this May 12, 2025
targos pushed a commit that referenced this pull request May 16, 2025
@Aditi-1400 @targos
src: add a variant of ToV8Value() for primitive arrays
e0355b7 
Adds a variant of ToV8Value for array of primitives that
do not need to throw during conversion - there is essentially
no exceptions that can be thrown then an array
of integers is created.

PR-URL: #57576
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@Aditi-1400 @aduh95
src: add a variant of ToV8Value() for primitive arrays
aa00f59 
Adds a variant of ToV8Value for array of primitives that
do not need to throw during conversion - there is essentially
no exceptions that can be thrown then an array
of integers is created.

PR-URL: #57576
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Joyee Cheung <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@joyeecheung joyeecheung joyeecheung approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@Aditi-1400 @nodejs-github-bot @joyeecheung @jasnell @anonrig @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.