GeezerVison

Copy link

Copy Markdown

Member

bricss reacted with rocket emoji

RafaelGSS force-pushed the improve-error-message-permission-model branch from 802f91c to 3c14972 Compare March 21, 2025 19:05

mcollina approved these changes Mar 21, 2025

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@@            Coverage Diff             @@
##             main   #57585      +/-   ##
==========================================
- Coverage   90.23%   90.23%   -0.01%     
==========================================
  Files         629      630       +1     
  Lines      184947   185136     +189     
  Branches    36229    36237       +8     
==========================================
+ Hits       166882   167052     +170     
- Misses      11017    11047      +30     
+ Partials     7048     7037      -11     

   ⚠  Commits were pushed since the last approving review:
   ⚠  - src,permission: make ERR_ACCESS_DENIED more descriptive
   ⚠  - fixup! src,permission: make ERR_ACCESS_DENIED more descriptive
   ✘  Refusing to run CI on potentially unsafe PR

mcollina approved these changes Apr 1, 2025

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 200 OK

jasnell approved these changes Apr 1, 2025

View reviewed changes

This commit also adds a suggestion flag (if exists)
when ERR_ACCESS_DENIED is thrown, so users don't need
to jump into the documentation to see how to manage
that permission error.

PR-URL: #57585
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This commit also adds a suggestion flag (if exists)
when ERR_ACCESS_DENIED is thrown, so users don't need
to jump into the documentation to see how to manage
that permission error.

PR-URL: #57585
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This commit also adds a suggestion flag (if exists)
when ERR_ACCESS_DENIED is thrown, so users don't need
to jump into the documentation to see how to manage
that permission error.

PR-URL: #57585
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This commit also adds a suggestion flag (if exists)
when ERR_ACCESS_DENIED is thrown, so users don't need
to jump into the documentation to see how to manage
that permission error.

PR-URL: #57585
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This commit also adds a suggestion flag (if exists)
when ERR_ACCESS_DENIED is thrown, so users don't need
to jump into the documentation to see how to manage
that permission error.

PR-URL: #57585
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>

This commit also adds a suggestion flag (if exists)
when ERR_ACCESS_DENIED is thrown, so users don't need
to jump into the documentation to see how to manage
that permission error.

PR-URL: #57585
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: James M Snell <[email protected]>