GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||
GeezerVison is showing github.com — doc: remove Corepack documentation page by aduh95 · Pull Request #57663 · nodejs/node Conversation
Contributor
Following up on #57635, let's remove the page. Adding dont-land labels as a cautionary step to avoid 404 in case there are links in the wild to that page. Landing it on 24.x should be fine as long as it lands before 24.0.0.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
ljharb
approved these changes
|
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #57663 +/- ## ========================================== - Coverage 88.58% 88.56% -0.03% ========================================== Files 704 704 Lines 207774 207774 Branches 40028 40034 +6 ========================================== - Hits 184065 184023 -42 - Misses 15752 15799 +47 + Partials 7957 7952 -5 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Corepack is available in 24.x, and removal of documentation page will create confusion among its existing users. And they may not try experimental features of Node.js again.
The documentation page already links to npm package. We can update it to mention about upcoming removal in v25+ and remove the documentation in v25+.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@trivikr you can add the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That's debatable, we've never shipped any documentation for npm, having one for Corepack is arguably what's inconsistent. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
I added
That's true. There are links to corepack documentation in the wild which point to the latest version of the doc in Node.js. And whoever lands on that page should get to know how they can continue using corepack. A 404 page will lead to loss of trust in any experimental features which Node.js introduces (current and future). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Would that be a bad thing? IMO users should not trust experimental features. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
It's the trust wrt communication, and it can apply to stable features too. Explaining it with an example makes it clear:
When v24 releases on 2025-04-22 with 404 for corepack documentation
The action after losing trust can be any of the following:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
That's not going to happen though, this PR has the
dont-land-on-v24.x
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I liked this suggestion from @MikeMcC399 after my vote though
This will help folks landing on corepack documentation from links shared in the ecosystem.
I think v27+ would be a good midway choice, but v26+ is also okay. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I created an alternative PR at #57813 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I've opened nodejs/nodejs.org#7643 to address #57663 (comment) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
As per discussion between @aduh95 and me on OpenJS Slack channel |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
ee8e115 to
890f739
Compare
PR-URL: nodejs#57663 Reviewed-By: Jordan Harband <[email protected]> Reviewed-By: Darshan Sen <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
890f739 to
f7ca0ae
Compare
|
Landed in f7ca0ae |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.