GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: enable linter in `test/fixtures/source-map/output` by aduh95 · Pull Request #57700 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
tools: enable linter in test/fixtures/source-map/output
08928b4
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 1, 2025
MoLow
MoLow approved these changes Apr 1, 2025
View reviewed changes
jasnell
jasnell approved these changes Apr 1, 2025
View reviewed changes
@codecov

codecov Bot commented Apr 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (caf478b) to head (5944bf6).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57700      +/-   ##
==========================================
- Coverage   90.25%   90.24%   -0.01%     
==========================================
  Files         630      630              
  Lines      184990   184990              
  Branches    36216    36213       -3     
==========================================
- Hits       166954   166950       -4     
+ Misses      11003    10993      -10     
- Partials     7033     7047      +14

see 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 added 4 commits April 1, 2025 13:53
@aduh95
fixup! tools: enable linter in test/fixtures/source-map/output
2d224f4
@aduh95
fixup! fixup! tools: enable linter in test/fixtures/source-map/output
fca609d
@aduh95
fixup! fixup! fixup! tools: enable linter in `test/fixtures/source-ma…
d7618de 
…p/output`
@aduh95
Merge branch 'main' into lint-source-map-output
3aaf5ac
aduh95
aduh95 commented Apr 4, 2025
View reviewed changes
Comment thread eslint.config.mjs Resolved

Uh oh!

There was an error while loading. Please reload this page.
aduh95 added 2 commits April 4, 2025 15:47
@aduh95
Update eslint.config.mjs
eb3dbad
@aduh95
Merge branch 'main' into lint-source-map-output
5944bf6
@aduh95
aduh95 merged commit 87f8d3c into nodejs:main Apr 4, 2025
@aduh95

aduh95 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor Author

Landed in 87f8d3c
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the lint-source-map-output branch April 4, 2025 13:56
imronsman
imronsman reviewed Apr 5, 2025
View reviewed changes
Comment thread eslint.config.mjs
'!test/fixtures/console',
'!test/fixtures/errors',
'!test/fixtures/eval',
'!test/fixtures/source-map',

This comment was marked as off-topic.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/source-map/output
8f709f6 
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/source-map/output
dcba975 
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
tools: enable linter in test/fixtures/source-map/output
b95d7f5 
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/source-map/output
999c232 
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
tools: enable linter in test/fixtures/source-map/output
0b42440 
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
tools: enable linter in test/fixtures/source-map/output
5703147 
PR-URL: #57700
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@MoLow MoLow MoLow approved these changes
+1 more reviewer
@imronsman imronsman imronsman left review comments
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @jasnell @MoLow @imronsman @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.