GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: enable linter in `test/fixtures/errors` by aduh95 · Pull Request #57701 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Apr 1, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
tools: enable linter in test/fixtures/errors
dc1485a
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Apr 1, 2025
MoLow
MoLow approved these changes Apr 1, 2025
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. and removed needs-ci PRs that need a full CI run. labels Apr 1, 2025
@codecov

codecov Bot commented Apr 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (633ba00) to head (9e81b22).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57701   +/-   ##
=======================================
  Coverage   90.24%   90.25%           
=======================================
  Files         630      630           
  Lines      184990   184990           
  Branches    36214    36220    +6     
=======================================
+ Hits       166948   166957    +9     
+ Misses      11001    10997    -4     
+ Partials     7041     7036    -5

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 added 3 commits April 1, 2025 13:38
@aduh95
fixup! tools: enable linter in test/fixtures/errors
1c91671
@aduh95
fixup! fixup! tools: enable linter in test/fixtures/errors
60990d5
@aduh95
Merge branch 'main' into lint-errors-output
9e81b22
@jakecastelli

jakecastelli commented Apr 4, 2025

Copy link
Copy Markdown
Member

Just for the educational purpose - would this commit [Merge branch 'main' into lint-errors-output] cause issue to land?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jakecastelli
jakecastelli approved these changes Apr 4, 2025
View reviewed changes
@aduh95

aduh95 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor Author

would this commit [Merge branch 'main' into lint-errors-output] cause issue to land?

Yes definitely, it can only work if the PR is landed manually – which we have to do anyway because CQ refuses to land PR that touch test files without a full CI re-run, as it can't tell the changes are purely cosmetic.
jakecastelli reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit caf478b into nodejs:main Apr 4, 2025
@aduh95

aduh95 commented Apr 4, 2025

Copy link
Copy Markdown
Contributor Author

Landed in caf478b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the lint-errors-output branch April 4, 2025 13:41
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/errors
1c0b900 
PR-URL: #57701
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/errors
b9043c9 
PR-URL: #57701
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
tools: enable linter in test/fixtures/errors
9400160 
PR-URL: #57701
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95 @RafaelGSS
tools: enable linter in test/fixtures/errors
e0e4251 
PR-URL: #57701
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
tools: enable linter in test/fixtures/errors
5c24124 
PR-URL: #57701
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
tools: enable linter in test/fixtures/errors
80d58c3 
PR-URL: #57701
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoLow MoLow MoLow approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @jakecastelli @MoLow @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.