GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: mark type stripping as release candidate by marco-ippolito · Pull Request #57705 · nodejs/node

Conversation

@marco-ippolito

@marco-ippolito marco-ippolito commented Apr 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs: nodejs/typescript#24

The design of this feature is pretty much stable and we have just been working on bug fixing and aesthetic improvements like error messages.
There is 1 issue open right now, and not many issues opened in general so I feel pretty confident in marking this as release candidate

cc @nodejs/typescript

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@marco-ippolito
doc: mark type stripping as release candidate
1ea0681
@nodejs-github-bot

nodejs-github-bot commented Apr 1, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/typescript
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label Apr 1, 2025
@marco-ippolito marco-ippolito added the strip-types Issues and PRs related to TypeScript type stripping. label Apr 1, 2025
mcollina
mcollina approved these changes Apr 1, 2025
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
targos
targos approved these changes Apr 1, 2025
View reviewed changes
MoLow
MoLow approved these changes Apr 1, 2025
View reviewed changes
@marco-ippolito marco-ippolito added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 1, 2025
JakobJingleheimer
JakobJingleheimer approved these changes Apr 1, 2025
View reviewed changes
jasnell
jasnell approved these changes Apr 1, 2025
View reviewed changes
ljharb
ljharb approved these changes Apr 1, 2025
View reviewed changes
JungMinu
JungMinu approved these changes Apr 1, 2025
View reviewed changes
bjohansebas
bjohansebas approved these changes Apr 1, 2025
View reviewed changes
Lxxyx
Lxxyx approved these changes Apr 2, 2025
View reviewed changes
@marco-ippolito marco-ippolito added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 2, 2025
GeoffreyBooth
GeoffreyBooth approved these changes Apr 2, 2025
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 3, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 3984bc1 into nodejs:main Apr 3, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2025

Copy link
Copy Markdown
Collaborator

Landed in 3984bc1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@marco-ippolito @RafaelGSS
doc: mark type stripping as release candidate
1bed9b4 
PR-URL: #57705
Refs: nodejs/typescript#24
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@marco-ippolito @RafaelGSS
doc: mark type stripping as release candidate
d066d1f 
PR-URL: #57705
Refs: nodejs/typescript#24
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
richardlau pushed a commit that referenced this pull request Sep 20, 2025
@marco-ippolito @richardlau
doc: mark type stripping as release candidate
a93a8b5 
PR-URL: #57705
Refs: nodejs/typescript#24
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Minwoo Jung <[email protected]>
Reviewed-By: Zijian Liu <[email protected]>
Reviewed-By: Geoffrey Booth <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 22, 2025
2025-09-24, Version 22.20.0 'Jod' (LTS) #59973
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@mcollina mcollina mcollina approved these changes
@jasnell jasnell jasnell approved these changes
@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@JungMinu JungMinu JungMinu approved these changes
@MoLow MoLow MoLow approved these changes
@Lxxyx Lxxyx Lxxyx approved these changes
+2 more reviewers
@targos targos targos approved these changes
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. strip-types Issues and PRs related to TypeScript type stripping.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

12 participants

@marco-ippolito @nodejs-github-bot @ljharb @mcollina @jasnell @GeoffreyBooth @targos @JakobJingleheimer @JungMinu @MoLow @Lxxyx @bjohansebas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.