GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fixup fs SyncCall to propagate errors correctly by jasnell · Pull Request #57711 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Apr 1, 2025

Copy link
Copy Markdown
Member

Propagate errors correctly in the SyncCall utility.

Previously the test case would trigger a crash.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jasnell
jasnell requested review from aduh95 and anonrig April 1, 2025 16:55
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Apr 1, 2025
@jasnell
src: fixup fs SyncCall to propagate errors correctly
75ebfdd 
Propagate errors correctly in the SyncCall utility.

Previously the test case would trigger a crash.
@jasnell
jasnell force-pushed the jasnell/fs-sync-crash-fix branch from a76b761 to 75ebfdd Compare April 1, 2025 17:30
@codecov

codecov Bot commented Apr 1, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (1c2d98d) to head (3ce4763).
Report is 301 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 71.42% 3 Missing and 3 partials ⚠️
src/node_file-inl.h 80.00% 0 Missing and 2 partials ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57711   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         630      630           
  Lines      185073   185092   +19     
  Branches    36222    36231    +9     
=======================================
+ Hits       166990   167018   +28     
+ Misses      11044    11037    -7     
+ Partials     7039     7037    -2
Files with missing lines Coverage Δ
src/node_file.h 78.43% <ø> (ø)
src/node_file-inl.h 87.27% <80.00%> (-0.75%) ⬇️
src/node_file.cc 76.59% <71.42%> (-0.15%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes Apr 1, 2025
View reviewed changes
Comment thread test/parallel/test-fs-writesync-crash.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@jasnell @aduh95
Update test/parallel/test-fs-writesync-crash.js
3ce4763 
Co-authored-by: Antoine du Hamel <[email protected]>
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 2, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Apr 3, 2025 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66012/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
anonrig
anonrig approved these changes Apr 3, 2025
View reviewed changes
jasnell added a commit that referenced this pull request Apr 3, 2025
@jasnell
src: fixup fs SyncCall to propagate errors correctly
538c813 
Propagate errors correctly in the SyncCall utility.

Previously the test case would trigger a crash.

PR-URL: #57711
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@jasnell

jasnell commented Apr 3, 2025

Copy link
Copy Markdown
Member Author

Landed in 538c813
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 3, 2025
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@jasnell @RafaelGSS
src: fixup fs SyncCall to propagate errors correctly
2472fd9 
Propagate errors correctly in the SyncCall utility.

Previously the test case would trigger a crash.

PR-URL: #57711
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@jasnell @RafaelGSS
src: fixup fs SyncCall to propagate errors correctly
e144b69 
Propagate errors correctly in the SyncCall utility.

Previously the test case would trigger a crash.

PR-URL: #57711
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@aduh95 aduh95 added the backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. label May 6, 2025
@aduh95

aduh95 commented May 6, 2025

Copy link
Copy Markdown
Contributor

Test is crashing on v22.x-staging with this change
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@anonrig anonrig anonrig approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. backport-requested-v22.x PRs awaiting manual backport to the v22.x-staging branch. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@jasnell @nodejs-github-bot @aduh95 @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.