GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — lib: fix default AbortController.abort() message by nektro · Pull Request #57735 · nodejs/node

Conversation

@nektro

@nektro nektro commented Apr 2, 2025

Copy link
Copy Markdown
Contributor

did not previously match spec
https://dom.spec.whatwg.org/#dom-abortsignal-abort
https://webidl.spec.whatwg.org/#aborterror

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 2, 2025
@codecov

codecov Bot commented Apr 2, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.24%. Comparing base (5a2614f) to head (1ab2db6).
⚠️ Report is 3741 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57735      +/-   ##
==========================================
+ Coverage   90.23%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185074   184982      -92     
  Branches    36221    36218       -3     
==========================================
- Hits       166994   166946      -48     
+ Misses      11036    10990      -46     
- Partials     7044     7046       +2
Files with missing lines Coverage Δ
lib/internal/abort_controller.js 98.14% <100.00%> (ø)

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Apr 3, 2025
View reviewed changes

@RaisinTen RaisinTen left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you need to update the expected error messages in the tests

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nektro and BridgeAR reacted with thumbs up emoji
All reactions
  • 👍 2 reactions
lpinca
lpinca approved these changes Apr 3, 2025
View reviewed changes
@KhafraDev

KhafraDev commented Apr 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Where does the spec dictate that the description must be the error message?

For example I'm pretty sure if we implemented URLMismatchError its message wouldn't be "Deprecated.".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@KhafraDev KhafraDev added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 3, 2025
@nektro

nektro commented Apr 3, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

taking another look, https://webidl.spec.whatwg.org/#js-creating-throwing-exceptions for DOMException says message is implementation defined.

initially opened this because while investigating other code we noticed Safari, Firefox, Bun use the default description from the spec
Node's message was the default one sans only the period
Chrome's message is signal is aborted without reason
Ladybird's message is Aborted without reason
workerd's message is the default one sans only the period
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nektro
lib: fix default AbortController.abort() message
1ab2db6 
did not previously match spec
https://dom.spec.whatwg.org/#dom-abortsignal-abort
https://webidl.spec.whatwg.org/#aborterror

Co-authored-by: pfg <[email protected]>
@nektro
nektro force-pushed the patch-5 branch from 063a033 to 1ab2db6 Compare April 3, 2025 21:50
@legendecas

legendecas commented Apr 7, 2025

Copy link
Copy Markdown
Member

See https://nodejs.org/api/errors.html#errorcode, error message can be changed in any versions of Node.js. I don't think this is necessarily a semver major change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@legendecas legendecas mentioned this pull request Apr 7, 2025
doc: list DOMException as a potential error raised by Node.js #57783
Merged
@KhafraDev

KhafraDev commented Apr 7, 2025

Copy link
Copy Markdown
Member

Mostly being careful because this will break things, mostly tests https://github.com/search?q=%22This+operation+was+aborted%22&type=code
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
nodejs-github-bot pushed a commit that referenced this pull request Apr 9, 2025
@legendecas
doc: list DOMException as a potential error raised by Node.js
d6b062c 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@legendecas @RafaelGSS
doc: list DOMException as a potential error raised by Node.js
a4e305a 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@legendecas @RafaelGSS
doc: list DOMException as a potential error raised by Node.js
a5ef2e8 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
31d167e 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@legendecas @RafaelGSS
doc: list DOMException as a potential error raised by Node.js
602bf9f 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
0877fb2 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
81720df 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2025
@legendecas @aduh95
doc: list DOMException as a potential error raised by Node.js
01cad99 
PR-URL: #57783
Refs: #57735
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Jason Zhang <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
@nektro

nektro commented Sep 6, 2025

Copy link
Copy Markdown
Contributor Author

bump
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label Jul 28, 2026
@avivkeller avivkeller closed this Aug 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version. stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@nektro @KhafraDev @legendecas @lpinca @RaisinTen @nodejs-github-bot @avivkeller
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.