GeezerVison

Copy link

Copy Markdown

Member

MikeMcC399 and styfle reacted with thumbs up emoji

ljharb approved these changes Apr 4, 2025

View reviewed changes

lpinca approved these changes Apr 4, 2025

View reviewed changes

trivikr force-pushed the corepack-removal-version branch from 683c103 to 1a83409 Compare April 4, 2025 16:32

MikeMcC399 reviewed Apr 4, 2025

View reviewed changes

trivikr requested review from MikeMcC399 and aduh95 and removed request for MikeMcC399 April 4, 2025 16:46

styfle approved these changes Apr 4, 2025

View reviewed changes

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

BridgeAR approved these changes Apr 4, 2025

View reviewed changes

gurgunday approved these changes Apr 5, 2025

View reviewed changes

RaisinTen approved these changes Apr 5, 2025

View reviewed changes

MikeMcC399 reviewed Apr 5, 2025

View reviewed changes

UlisesGascon approved these changes Apr 5, 2025

View reviewed changes

jasnell approved these changes Apr 5, 2025

View reviewed changes

bjohansebas approved these changes Apr 6, 2025

View reviewed changes

nodejs-github-bot deleted the corepack-removal-version branch April 7, 2025 15:53

PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>

PR-URL: #57747
Reviewed-By: Jordan Harband <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: James M Snell <[email protected]>

## 요약

#257에서 컨테이너를 `node:26-bookworm-slim`으로 올렸지만 CI의 test 작업은 여전히 Node.js 24로 실행되고 있었습니다.
이 PR은 `actions/setup-node`의 `node-version`을 `"26"`으로 올려 테스트와 컨테이너의 Node 주 버전을 맞춥니다.
Node.js 25부터 Corepack이 함께 배포되지 않으므로, `Dockerfile`과 같은 `[email protected]`을 먼저 설치한 뒤 `corepack enable`을 실행합니다.

- 근거: [Node.js Corepack 문서](https://nodejs.org/dist/latest/docs/api/corepack.html), [nodejs/node#57747](nodejs/node#57747)
- `package.json`의 `engines`(`>=24`)와 README의 요구 버전은 바꾸지 않았습니다. Node 24도 계속 지원 범위입니다.

## 검증

- `trunk check .github/workflows/ci.yaml` → exit 0
- 이 PR의 CI test 작업이 Node.js 26에서 type check, unit, DB, workerd 검사를 실행하는 것이 실제 검증입니다.

## Decisions taken where the brief was silent

- corepack 버전은 `Dockerfile`과 같은 0.36.0으로 고정했습니다. 두 곳의 버전을 함께 올려야 합니다.