GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: improve error handling in `node_env_var.cc` by aduh95 · Pull Request #57767 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Apr 5, 2025

Copy link
Copy Markdown
Contributor

Refs: #57707 (comment)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@aduh95
src: improve error handling in node_env_var.cc
ff56705
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 5, 2025
@codecov

codecov Bot commented Apr 5, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (214e3d4) to head (ff56705).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57767      +/-   ##
==========================================
+ Coverage   90.24%   90.25%   +0.01%     
==========================================
  Files         630      630              
  Lines      185204   185204              
  Branches    36296    36294       -2     
==========================================
+ Hits       167133   167158      +25     
+ Misses      11003    10990      -13     
+ Partials     7068     7056      -12
Files with missing lines Coverage Δ
src/node_env_var.cc 83.23% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Apr 5, 2025
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Apr 6, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 6, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 6, 2025 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66077/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
targos
targos approved these changes Apr 6, 2025
View reviewed changes
legendecas
legendecas approved these changes Apr 6, 2025
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 7, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 1540fc6 into nodejs:main Apr 7, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

Landed in 1540fc6
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the error-handling-cc branch April 8, 2025 08:24
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
src: improve error handling in node_env_var.cc
d48d24f 
PR-URL: #57767
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
src: improve error handling in node_env_var.cc
2b0f65e 
PR-URL: #57767
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
src: improve error handling in node_env_var.cc
abe4bd7 
PR-URL: #57767
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95 @RafaelGSS
src: improve error handling in node_env_var.cc
310c6d0 
PR-URL: #57767
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 16, 2025
@aduh95
src: improve error handling in node_env_var.cc
6625380 
PR-URL: #57767
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
src: improve error handling in node_env_var.cc
79df31b 
PR-URL: #57767
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
src: improve error handling in node_env_var.cc
4754c69 
PR-URL: #57767
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@legendecas legendecas legendecas approved these changes
+1 more reviewer
@targos targos targos approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@aduh95 @nodejs-github-bot @jasnell @targos @legendecas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.