GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: add codeql nightly by RafaelGSS · Pull Request #57788 · nodejs/node

Conversation

@RafaelGSS

@RafaelGSS RafaelGSS commented Apr 7, 2025

Copy link
Copy Markdown
Member

Refs: #57535

cc: @nodejs/security-wg

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@RafaelGSS
tools: add codeql nightly
783a180 
Refs: nodejs#57535
@RafaelGSS
RafaelGSS requested a review from targos April 7, 2025 22:04
@nodejs-github-bot

nodejs-github-bot commented Apr 7, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS RafaelGSS mentioned this pull request Apr 7, 2025
[StepSecurity] Apply security best practices #57535
Closed
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Apr 7, 2025
@RafaelGSS
fixup! tools: add codeql nightly
a5d3498
jasnell
jasnell approved these changes Apr 7, 2025
View reviewed changes
bjohansebas
bjohansebas approved these changes Apr 8, 2025
View reviewed changes
@targos

targos commented Apr 8, 2025

Copy link
Copy Markdown
Member

What about #57535 (comment) / https://github.com/nodejs/node/actions/runs/13927045256?pr=57535 ?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
fixup! fixup! tools: add codeql nightly
e088e1a
@RafaelGSS

RafaelGSS commented Apr 8, 2025

Copy link
Copy Markdown
Member Author

What about #57535 (comment) / https://github.com/nodejs/node/actions/runs/13927045256?pr=57535 ?

I forgot about it. Just applied.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bnb
bnb reviewed Apr 9, 2025
View reviewed changes
Comment thread .github/workflows/codeql.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
bnb
bnb reviewed Apr 9, 2025
View reviewed changes
Comment thread .github/workflows/codeql.yml Resolved

Uh oh!

There was an error while loading. Please reload this page.
@RafaelGSS
fixup! fixup! fixup! tools: add codeql nightly
f3f5f46
@RafaelGSS

RafaelGSS commented Apr 14, 2025

Copy link
Copy Markdown
Member Author

PTAL @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
marco-ippolito
marco-ippolito approved these changes Apr 14, 2025
View reviewed changes
@RafaelGSS RafaelGSS added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 14, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 14, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 78fd82b into nodejs:main Apr 14, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Landed in 78fd82b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS added a commit that referenced this pull request May 1, 2025
@RafaelGSS
tools: add codeql nightly
3793c8f 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS added a commit that referenced this pull request May 2, 2025
@RafaelGSS
tools: add codeql nightly
3a99975 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@RafaelGSS @aduh95
tools: add codeql nightly
816494c 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@RafaelGSS @aduh95
tools: add codeql nightly
75ac9b5 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
RafaelGSS added a commit that referenced this pull request May 14, 2025
@RafaelGSS
tools: add codeql nightly
dbe525b 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@RafaelGSS @aduh95
tools: add codeql nightly
fdacc92 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@RafaelGSS @aduh95
tools: add codeql nightly
20b57bd 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@RafaelGSS @aduh95
tools: add codeql nightly
342310b 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@RafaelGSS @aduh95
tools: add codeql nightly
234c417 
Refs: #57535
PR-URL: #57788
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnb bnb bnb left review comments
@jasnell jasnell jasnell approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@targos targos Awaiting requested review from targos
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@RafaelGSS @nodejs-github-bot @targos @jasnell @bnb @marco-ippolito @bjohansebas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.