GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test_runner: match minimum file column to 'all files' by islandryu · Pull Request #57848 · nodejs/node

Conversation

@islandryu

@islandryu islandryu commented Apr 12, 2025

Copy link
Copy Markdown
Member

Fixed a problem that all files are omitted when the file name displayed in coverage is too short.

ℹ tests 1
ℹ suites 0
ℹ pass 1
ℹ fail 0
ℹ cancelled 0
ℹ skipped 0
ℹ todo 0
ℹ duration_ms 3.993167
ℹ start of coverage report
ℹ ------------------------------------------------------------------------------------
ℹ file   | line % | branch % | funcs % | uncovered lines
ℹ ------------------------------------------------------------------------------------
ℹ a.js   |  55.77 |   100.00 |    0.00 | 5-7 9-11 13-15 17-19 29-30 40-42 45-47 50-52
ℹ ------------------------------------------------------------------------------------
ℹ …files |  55.77 |   100.00 |    0.00 | 
ℹ ------------------------------------------------------------------------------------
ℹ end of coverage report

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JakobJingleheimer, pmarchini, and bricss reacted with heart emoji
All reactions
  • ❤️ 3 reactions
@islandryu
test_runner: match minimum file column to 'all files'
697228d
@nodejs-github-bot

nodejs-github-bot commented Apr 12, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/test_runner
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem. labels Apr 12, 2025
@codecov

codecov Bot commented Apr 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (86f86a2) to head (697228d).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/test_runner/utils.js 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57848      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185481   185481              
  Branches    36364    36369       +5     
==========================================
+ Hits       167357   167386      +29     
+ Misses      11004    11000       -4     
+ Partials     7120     7095      -25
Files with missing lines Coverage Δ
lib/internal/test_runner/utils.js 58.52% <0.00%> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pmarchini
pmarchini approved these changes Apr 13, 2025
View reviewed changes

@pmarchini pmarchini left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!!!
LGTM!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66238/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pmarchini
pmarchini requested review from cjihrig and jakecastelli April 13, 2025 20:03
cjihrig
cjihrig approved these changes Apr 13, 2025
View reviewed changes
@pmarchini pmarchini added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. commit-queue PRs queued for automated landing through the Commit Queue. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Apr 13, 2025
jakecastelli
jakecastelli approved these changes Apr 14, 2025
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 14, 2025
@nodejs-github-bot
nodejs-github-bot merged commit f89baf2 into nodejs:main Apr 14, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

Landed in f89baf2
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@islandryu @RafaelGSS
test_runner: match minimum file column to 'all files'
b4908e3 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@islandryu @RafaelGSS
test_runner: match minimum file column to 'all files'
7416a7f 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
6025917 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
5ef665f 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@islandryu @RafaelGSS
test_runner: match minimum file column to 'all files'
0a61b78 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
abdaa33 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
cf58fa5 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
b0097db 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@islandryu @aduh95
test_runner: match minimum file column to 'all files'
edb7dd1 
PR-URL: #57848
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@ghost ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@jakecastelli jakecastelli jakecastelli approved these changes
@pmarchini pmarchini pmarchini approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@islandryu @nodejs-github-bot @cjihrig @jakecastelli @pmarchini
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.