GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: fix typo in comments by geeksilva97 · Pull Request #57868 · nodejs/node

Conversation

@geeksilva97

@geeksilva97 geeksilva97 commented Apr 13, 2025

Copy link
Copy Markdown
Contributor

This PR fixes a typo in node_sqlite.cc file

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@geeksilva97
src: fix typo in comments
54433b0
@nodejs-github-bot

nodejs-github-bot commented Apr 13, 2025

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/sqlite
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 13, 2025
@codecov

codecov Bot commented Apr 13, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (09ecd2e) to head (54433b0).
Report is 38 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57868      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         630      630              
  Lines      185502   185670     +168     
  Branches    36366    36401      +35     
==========================================
+ Hits       167402   167552     +150     
+ Misses      11000    10992       -8     
- Partials     7100     7126      +26
Files with missing lines Coverage Δ
src/node_sqlite.cc 80.49% <ø> (ø)

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RaisinTen
RaisinTen approved these changes Apr 14, 2025
View reviewed changes
lpinca
lpinca approved these changes Apr 14, 2025
View reviewed changes
@geeksilva97

geeksilva97 commented Apr 14, 2025

Copy link
Copy Markdown
Contributor Author

I have a silly question. Do I need to run CI here?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
cjihrig
cjihrig approved these changes Apr 14, 2025
View reviewed changes
@cjihrig

cjihrig commented Apr 14, 2025

Copy link
Copy Markdown
Contributor

Do I need to run CI here?

Yes, since this is a change to the source code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geeksilva97

geeksilva97 commented Apr 14, 2025

Copy link
Copy Markdown
Contributor Author

Do I need to run CI here?

Yes, since this is a change to the source code.

great. ty
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 14, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 14, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
jasnell
jasnell approved these changes Apr 14, 2025
View reviewed changes
@jasnell jasnell added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 14, 2025
bjohansebas
bjohansebas approved these changes Apr 14, 2025
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 14, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66267/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Ayase-252
Ayase-252 approved these changes Apr 15, 2025
View reviewed changes
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 15, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 15, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/57868
✔  Done loading data for nodejs/node/pull/57868
----------------------------------- PR info ------------------------------------
Title      src: fix typo in comments (#57868)
Author     Edy Silva <[email protected]> (@geeksilva97)
Branch     geeksilva97:fix-typo-in-comments -> nodejs:main
Labels     c++, author ready, needs-ci, sqlite
Commits    1
 - src: fix typo in comments
Committers 1
 - Edy Silva <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 13 Apr 2025 22:50:39 GMT
   ✔  Approvals: 5
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763129313
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763291828
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764259918
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764666235
   ✔  - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/57868#pullrequestreview-2766864878
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2025-04-14T18:28:00Z: https://ci.nodejs.org/job/node-test-pull-request/66267/
- Querying data for job/node-test-pull-request/66267/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14480877191
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@geeksilva97 geeksilva97 added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Apr 16, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 16, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
himself65
himself65 approved these changes Apr 16, 2025
View reviewed changes
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@geeksilva97 geeksilva97 added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 18, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Apr 18, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/57868
✔  Done loading data for nodejs/node/pull/57868
----------------------------------- PR info ------------------------------------
Title      src: fix typo in comments (#57868)
Author     Edy Silva <[email protected]> (@geeksilva97)
Branch     geeksilva97:fix-typo-in-comments -> nodejs:main
Labels     c++, author ready, needs-ci, sqlite
Commits    1
 - src: fix typo in comments
Committers 1
 - Edy Silva <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 13 Apr 2025 22:50:39 GMT
   ✔  Approvals: 6
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763129313
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57868#pullrequestreview-2763291828
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764259918
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57868#pullrequestreview-2764666235
   ✔  - Qingyu Deng (@Ayase-252): https://github.com/nodejs/node/pull/57868#pullrequestreview-2766864878
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/57868#pullrequestreview-2773217122
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2025-04-18T16:37:24Z: https://ci.nodejs.org/job/node-test-pull-request/66351/
- Querying data for job/node-test-pull-request/66351/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/14539430804
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66352/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Apr 19, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 19, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 63640eb into nodejs:main Apr 19, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 19, 2025

Copy link
Copy Markdown
Collaborator

Landed in 63640eb
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@geeksilva97 @RafaelGSS
src: fix typo in comments
7da7142 
PR-URL: #57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
2025-05-06, Version 24.0.0 (Current) #57609
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@geeksilva97 @RafaelGSS
src: fix typo in comments
227f2cb 
PR-URL: #57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@geeksilva97 @aduh95
src: fix typo in comments
6c602f9 
PR-URL: #57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@geeksilva97 @RafaelGSS
src: fix typo in comments
3f726d5 
PR-URL: #57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@geeksilva97 @aduh95
src: fix typo in comments
508002e 
PR-URL: #57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@geeksilva97 @aduh95
src: fix typo in comments
cbf6741 
PR-URL: #57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@geeksilva97 @aduh95
src: fix typo in comments
ff72f93 
PR-URL: #57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
2025-05-21, Version 22.16.0 'Jod' (LTS) #58388
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@geeksilva97 @aduh95
src: fix typo in comments
010dd91 
PR-URL: #57868
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Qingyu Deng <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
@geeksilva97
geeksilva97 deleted the fix-typo-in-comments branch May 20, 2025 00:46
@ghost ghost mentioned this pull request Jun 8, 2025
### Notable Changes autofix-ci/action#28
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@cjihrig cjihrig cjihrig approved these changes
@Ayase-252 Ayase-252 Ayase-252 approved these changes
@himself65 himself65 himself65 approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@geeksilva97 @nodejs-github-bot @cjihrig @jasnell @lpinca @Ayase-252 @himself65 @RaisinTen @bjohansebas @aduh95
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.