GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: remove unused `shouldRetryAsESM` internal binding by dario-piotrowicz · Pull Request #58265 · nodejs/node

Conversation

@dario-piotrowicz

@dario-piotrowicz dario-piotrowicz commented May 10, 2025

Copy link
Copy Markdown
Member

This PR is removing the shouldRetryAsESM internal binding, which I believe is no longer used.

I believe that the binding stopped being used in #52047.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bricss reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@dario-piotrowicz
src: remove unused shouldRetryAsESM internal binding
dccc227
@dario-piotrowicz
dario-piotrowicz requested a review from joyeecheung May 10, 2025 19:53
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels May 10, 2025
anonrig
anonrig approved these changes May 10, 2025
View reviewed changes
@codecov

codecov Bot commented May 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (578a893) to head (dccc227).
Report is 19 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58265      +/-   ##
==========================================
- Coverage   90.18%   90.17%   -0.01%     
==========================================
  Files         629      629              
  Lines      186639   186617      -22     
  Branches    36654    36655       +1     
==========================================
- Hits       168313   168275      -38     
+ Misses      11134    11114      -20     
- Partials     7192     7228      +36
Files with missing lines Coverage Δ
src/node_contextify.cc 81.20% <ø> (+0.70%) ⬆️

... and 42 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dario-piotrowicz dario-piotrowicz added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 10, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 10, 2025
@nodejs-github-bot

nodejs-github-bot commented May 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66745/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95
aduh95 approved these changes May 10, 2025
View reviewed changes

@aduh95 aduh95 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI agrees

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
dario-piotrowicz reacted with thumbs up emoji dario-piotrowicz reacted with laugh emoji
All reactions
  • 👍 1 reaction
  • 😄 1 reaction
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 10, 2025
lpinca
lpinca approved these changes May 11, 2025
View reviewed changes
RaisinTen
RaisinTen approved these changes May 11, 2025
View reviewed changes
mertcanaltin
mertcanaltin approved these changes May 12, 2025
View reviewed changes

@mertcanaltin mertcanaltin left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jasnell
jasnell approved these changes May 12, 2025
View reviewed changes
UlisesGascon
UlisesGascon approved these changes May 12, 2025
View reviewed changes
marco-ippolito
marco-ippolito approved these changes May 12, 2025
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 12, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 200abfc into nodejs:main May 12, 2025
@nodejs-github-bot

nodejs-github-bot commented May 12, 2025

Copy link
Copy Markdown
Collaborator

Landed in 200abfc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dario-piotrowicz
dario-piotrowicz deleted the dario/remove-shouldRetryAsESM-unused-internal-binding branch May 12, 2025 21:49
targos pushed a commit that referenced this pull request May 16, 2025
@dario-piotrowicz @targos
src: remove unused shouldRetryAsESM internal binding
4db5d0b 
PR-URL: #58265
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@dario-piotrowicz @aduh95
src: remove unused shouldRetryAsESM internal binding
0ce3fee 
PR-URL: #58265
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Darshan Sen <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@anonrig anonrig anonrig approved these changes
@UlisesGascon UlisesGascon UlisesGascon approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes
@RaisinTen RaisinTen RaisinTen approved these changes
@joyeecheung joyeecheung Awaiting requested review from joyeecheung
+1 more reviewer
@mertcanaltin mertcanaltin mertcanaltin approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

10 participants

@dario-piotrowicz @nodejs-github-bot @jasnell @lpinca @anonrig @UlisesGascon @aduh95 @marco-ippolito @mertcanaltin @RaisinTen
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.