GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: remove unnecessary `console.log` from test-repl-null-thrown by dario-piotrowicz · Pull Request #58281 · nodejs/node

Conversation

@dario-piotrowicz

@dario-piotrowicz dario-piotrowicz commented May 11, 2025

Copy link
Copy Markdown
Member

Super minor, but I noticed this rouge console.log and figured that we might just as well get rid of it 🙂

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels May 11, 2025
@dario-piotrowicz dario-piotrowicz changed the title test: remove unnecesssary console.log from test-repl-null-thrown test: remove unnecessary console.log from test-repl-null-thrown May 11, 2025
@dario-piotrowicz
test: remove unnecessary console.log from test-repl-null-thrown
f653cc2
@dario-piotrowicz
dario-piotrowicz force-pushed the dario/test-repl-null-thrown-consolelog branch from e535769 to f653cc2 Compare May 11, 2025 17:29
cjihrig
cjihrig approved these changes May 11, 2025
View reviewed changes
pmarchini
pmarchini approved these changes May 11, 2025
View reviewed changes
@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 11, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 11, 2025
@nodejs-github-bot

nodejs-github-bot commented May 11, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66760/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented May 11, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (4a86be2) to head (f653cc2).
Report is 21 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58281      +/-   ##
==========================================
- Coverage   90.18%   90.17%   -0.01%     
==========================================
  Files         631      631              
  Lines      186687   186689       +2     
  Branches    36663    36669       +6     
==========================================
- Hits       168355   168350       -5     
+ Misses      11124    11120       -4     
- Partials     7208     7219      +11

see 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dario-piotrowicz dario-piotrowicz added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels May 11, 2025
bjohansebas
bjohansebas approved these changes May 12, 2025
View reviewed changes
jasnell
jasnell approved these changes May 12, 2025
View reviewed changes
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 13, 2025
@nodejs-github-bot
nodejs-github-bot merged commit 59a763e into nodejs:main May 13, 2025
@nodejs-github-bot

nodejs-github-bot commented May 13, 2025

Copy link
Copy Markdown
Collaborator

Landed in 59a763e
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dario-piotrowicz
dario-piotrowicz deleted the dario/test-repl-null-thrown-consolelog branch May 13, 2025 18:06
targos pushed a commit that referenced this pull request May 16, 2025
@dario-piotrowicz @targos
test: remove unnecessary console.log from test-repl-null-thrown
40dc092 
PR-URL: #58281
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 20, 2025
2025-05-21, Version 24.1.0 (Current) #58406
Merged
aduh95 pushed a commit that referenced this pull request Jun 10, 2025
@dario-piotrowicz @aduh95
test: remove unnecessary console.log from test-repl-null-thrown
ca8d66c 
PR-URL: #58281
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Pietro Marchini <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Jun 10, 2025
2025-06-24, Version 22.17.0 'Jod' (LTS) #58665
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@cjihrig cjihrig cjihrig approved these changes
@pmarchini pmarchini pmarchini approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@dario-piotrowicz @nodejs-github-bot @jasnell @cjihrig @pmarchini @bjohansebas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.