GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: add instructions to only sign a release by Fishrock123 · Pull Request #5876 · nodejs/node

Conversation

@Fishrock123

@Fishrock123 Fishrock123 commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

Pull Request check-list

  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

doc

Description of change

I didn't know this existed since it wasn't documented, but after some digging into the script itself this totally saved me today after I did release things out-of-order. 😓

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Fishrock123 Fishrock123 added the doc Issues and PRs related to Node.js documentation. label Mar 23, 2016
MylesBorins
MylesBorins reviewed Mar 23, 2016
View reviewed changes
Comment thread doc/releases.md Outdated

@MylesBorins MylesBorins Mar 23, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: may be reasons other than forgetting for signing after the fact. Perhaps it should just note the option and ability to sign after promoting?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MylesBorins

MylesBorins commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

LGTM if you address the nit
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Mar 23, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@jasnell

jasnell commented Mar 23, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Fishrock123
doc: add instructions to only sign a release
55cbd4b
@Fishrock123
Fishrock123 force-pushed the release-sign-only branch from abf7d93 to 55cbd4b Compare March 24, 2016 21:49
@Fishrock123

Fishrock123 commented Mar 24, 2016

Copy link
Copy Markdown
Contributor Author

@thealphanerd updated, ptal.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins

MylesBorins commented Mar 24, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Mar 25, 2016
@Fishrock123 @jasnell
doc: add instructions to only sign a release
be68b68 
PR-URL: #5876
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell

jasnell commented Mar 25, 2016

Copy link
Copy Markdown
Member

Landed in be68b68
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Mar 25, 2016
evanlucas pushed a commit that referenced this pull request Mar 30, 2016
@Fishrock123 @evanlucas
doc: add instructions to only sign a release
0da59ef 
PR-URL: #5876
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added the land-on-v4.x label Mar 30, 2016
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
@Fishrock123 Myles Borins
doc: add instructions to only sign a release
cbed5b8 
PR-URL: #5876
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2016
@Fishrock123 Myles Borins
doc: add instructions to only sign a release
60ddab8 
PR-URL: #5876
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@evanlucas evanlucas mentioned this pull request Mar 31, 2016
v5.10.0 Release Proposal #5970
Closed
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
@Fishrock123 @evanlucas
doc: add instructions to only sign a release
8e790b7 
PR-URL: #5876
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Fishrock123 @MylesBorins @cjihrig @jasnell
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.