GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: fix flaky test-net-socket-timeout by mscdex · Pull Request #5902 · nodejs/node

Conversation

@mscdex

@mscdex mscdex commented Mar 25, 2016

Copy link
Copy Markdown
Contributor

Pull Request check-list

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?

Affected core subsystem(s)

  • test

Description of change

Fixes a flaky test due to short timeouts on slow systems.

Fixes: #5902

Stress test: https://ci.nodejs.org/job/node-stress-single-test/569
CI: https://ci.nodejs.org/job/node-test-pull-request/2064/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mscdex mscdex added net Issues and PRs related to the net subsystem. test Issues and PRs related to Node.js core tests and test infrastructure. arm Issues and PRs related to the ARM architecture. labels Mar 25, 2016
@mscdex
mscdex force-pushed the test-flaky-net-socket-timeout branch from fea5486 to 9d26d1f Compare March 25, 2016 16:02
@bnoordhuis

bnoordhuis commented Mar 25, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex

mscdex commented Mar 25, 2016

Copy link
Copy Markdown
Contributor Author

CI is green except for a couple of unrelated test failures. Stress test passes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell

jasnell commented Mar 26, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex
mscdex force-pushed the test-flaky-net-socket-timeout branch from 9d26d1f to cf87ad5 Compare March 26, 2016 08:22
@mscdex
test: fix flaky test-net-socket-timeout
8b2e437 
Fixes: nodejs#5892
PR-URL: nodejs#5902
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@mscdex
mscdex force-pushed the test-flaky-net-socket-timeout branch from cf87ad5 to 8b2e437 Compare March 26, 2016 08:23
@mscdex
mscdex merged commit 8b2e437 into nodejs:master Mar 26, 2016
@mscdex
mscdex deleted the test-flaky-net-socket-timeout branch March 26, 2016 08:24
evanlucas pushed a commit that referenced this pull request Mar 30, 2016
@mscdex @evanlucas
test: fix flaky test-net-socket-timeout
25244c1 
Fixes: #5892
PR-URL: #5902
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added the lts-watch-v4.x label Mar 30, 2016
@evanlucas evanlucas mentioned this pull request Mar 31, 2016
v5.10.0 Release Proposal #5970
Closed
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
@mscdex @evanlucas
test: fix flaky test-net-socket-timeout
a41fd93 
Fixes: #5892
PR-URL: #5902
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Apr 8, 2016
MylesBorins pushed a commit that referenced this pull request Apr 9, 2016
@mscdex Myles Borins
test: fix flaky test-net-socket-timeout
8462d8f 
Fixes: #5892
PR-URL: #5902
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
V4.4.3 proposal #6149
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. net Issues and PRs related to the net subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@mscdex @bnoordhuis @jasnell @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.