GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gyp: add missing `openssl_fips%` to common.gypi by indutny · Pull Request #5919 · nodejs/node

Conversation

@indutny

@indutny indutny commented Mar 27, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

gyp

Description of change

No comments, it just should be there in some rare cases.

See: atom/node@cba512d

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@indutny
gyp: add missing openssl_fips% to common.gypi
e0d508c 
No comments, it just should be there in some rare cases.

See: atom/node@cba512d
@indutny

indutny commented Mar 27, 2016

Copy link
Copy Markdown
Member Author

cc @zcbenz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@indutny

indutny commented Mar 27, 2016

Copy link
Copy Markdown
Member Author

cc @nodejs/collaborators
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@indutny indutny added the build Issues and PRs related to Node.js builds or CI infrastructure. label Mar 27, 2016
@jbergstroem

jbergstroem commented Mar 27, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/2706/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex

mscdex commented Mar 27, 2016

Copy link
Copy Markdown
Contributor

Perhaps the commit description should target the build subsystem instead of gyp?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jbergstroem

jbergstroem commented Mar 27, 2016

Copy link
Copy Markdown
Member

LGTM. Agree with @mscdex, plus perhaps remove the 'no comment' reference since you link to an example of the problem.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zcbenz

zcbenz commented Mar 27, 2016

Copy link
Copy Markdown
Contributor

Looks good to me, thanks!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@indutny

indutny commented Mar 27, 2016

Copy link
Copy Markdown
Member Author

Landed in 26a4a4b, thank you everyone!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@indutny indutny closed this Mar 27, 2016
@indutny
indutny deleted the feature/atom-3 branch March 27, 2016 15:35
indutny added a commit that referenced this pull request Mar 27, 2016
@indutny
build: add missing openssl_fips% to common.gypi
26a4a4b 
See: atom/node@cba512d

PR-URL: #5919
Reviewed-By: Johan Bergström <[email protected]>
evanlucas pushed a commit that referenced this pull request Mar 30, 2016
@indutny @evanlucas
build: add missing openssl_fips% to common.gypi
f56d6ad 
See: atom/node@cba512d

PR-URL: #5919
Reviewed-By: Johan Bergström <[email protected]>
@MylesBorins

MylesBorins commented Mar 30, 2016

Copy link
Copy Markdown
Contributor

@indutny should this be backported to lts?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@MylesBorins MylesBorins added the lts-watch-v4.x label Mar 30, 2016
@indutny

indutny commented Mar 30, 2016

Copy link
Copy Markdown
Member Author

I would say go for it! 😉
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas evanlucas mentioned this pull request Mar 31, 2016
v5.10.0 Release Proposal #5970
Closed
evanlucas pushed a commit that referenced this pull request Mar 31, 2016
@indutny @evanlucas
build: add missing openssl_fips% to common.gypi
5ee5fa2 
See: atom/node@cba512d

PR-URL: #5919
Reviewed-By: Johan Bergström <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
@indutny Myles Borins
build: add missing openssl_fips% to common.gypi
9a8f922 
See: atom/node@cba512d

PR-URL: #5919
Reviewed-By: Johan Bergström <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Apr 11, 2016
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
V4.4.3 proposal #6149
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@indutny @jbergstroem @mscdex @zcbenz @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.