GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — zlib: Fix use after null when calling .close by lightsofapollo · Pull Request #5982 · nodejs/node

Conversation

@lightsofapollo

@lightsofapollo lightsofapollo commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

Pull Request check-list

Please make sure to review and check all of these items:

  • Does make -j8 test (UNIX) or vcbuild test nosign (Windows) pass with
    this change (including linting)?
  • Is the commit message formatted according to CONTRIBUTING.md?
  • If this change fixes a bug (or a performance problem), is a regression
    test (or a benchmark) included?
  • Is a documentation update included (if this change modifies
    existing APIs, or introduces new ones)?

NOTE: these things are not required to open a PR and can be done
afterwards / while the PR is open.

Affected core subsystem(s)

  • zlib

Description of change

An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@lightsofapollo
zlib: Fix use after null when calling .close
094e34e 
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.
@Fishrock123 Fishrock123 added the zlib Issues and PRs related to the zlib module and its compression dependencies. label Mar 31, 2016
@mscdex

mscdex commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Mar 31, 2016

Copy link
Copy Markdown
Member

LGTM too, if that’s worth anything. Adding a test for this should not be too complicated, I think?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lightsofapollo

lightsofapollo commented Mar 31, 2016

Copy link
Copy Markdown
Contributor Author

I will give a shot adding a test tonight thanks for quick r?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@cjihrig

cjihrig commented Mar 31, 2016

Copy link
Copy Markdown
Contributor

LGTM. +1 to a test.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the lts-watch-v4.x label Apr 1, 2016
@jasnell

jasnell commented Apr 1, 2016

Copy link
Copy Markdown
Member

LGTM with a test
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@headlessme headlessme mentioned this pull request Apr 4, 2016
Zlib InflateRaw null reference #6034
Closed
@xPaw xPaw mentioned this pull request Apr 12, 2016
TypeError: Cannot read property 'close' of null thelounge/thelounge#234
Closed
@jasnell

jasnell commented Apr 13, 2016

Copy link
Copy Markdown
Member

ping @lightsofapollo ... have you had a chance to look at the test yet?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax

addaleax commented Apr 19, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/2962/
I’m going to land this and add a regression test based on the code #6034 if it comes out green.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax mentioned this pull request Apr 19, 2016
test: Add zlib close-after-error regression test #6270
Closed
3 tasks done
@addaleax

addaleax commented Apr 19, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Landed in c7fef3d, and added those as reviewers whose LGTMs I read as not necessarily depending on a test in this PR. PR for the regression test: #6270
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax closed this Apr 19, 2016
addaleax pushed a commit that referenced this pull request Apr 19, 2016
@lightsofapollo @addaleax
zlib: fix use after null when calling .close
c7fef3d 
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: #5982
Fixes: #6034
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@lightsofapollo Myles Borins
zlib: fix use after null when calling .close
bad006f 
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: #5982
Fixes: #6034
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
This was referenced Apr 21, 2016
V5.11.0 proposal #6321
Closed
V5.11.0 proposal #6322
Closed
@MylesBorins

MylesBorins commented Apr 21, 2016

Copy link
Copy Markdown
Contributor

needs to be included with f8e507e when backported
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@lightsofapollo @MylesBorins
zlib: fix use after null when calling .close
4f6f599 
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: #5982
Fixes: #6034
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@lightsofapollo @joelostrowski
zlib: fix use after null when calling .close
8dbd5c5 
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: nodejs#5982
Fixes: nodejs#6034
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@lightsofapollo @jasnell
zlib: fix use after null when calling .close
bd944e3 
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: #5982
Fixes: #6034
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
@lightsofapollo Myles Borins
zlib: fix use after null when calling .close
0cc1e0f 
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: #5982
Fixes: #6034
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels May 17, 2016
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@lightsofapollo Myles Borins
zlib: fix use after null when calling .close
48684af 
An internal zlib error may cause _handle to be set to null.
Close now will check if there is a _handle prior to calling .close on
it.

PR-URL: #5982
Fixes: #6034
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
v4.4.5 proposal #6824
Merged
@fippo fippo mentioned this pull request Jul 7, 2016
crashes in zlib.js fippo/rtcstats-server#149
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

zlib Issues and PRs related to the zlib module and its compression dependencies.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@lightsofapollo @mscdex @addaleax @cjihrig @jasnell @MylesBorins @Fishrock123
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.