GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — punycode: update to v1.3.2 by mathiasbynens · Pull Request #6 · nodejs/node

Conversation

@mathiasbynens

@mathiasbynens mathiasbynens commented Nov 28, 2014

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@rvagg

rvagg commented Nov 28, 2014

Copy link
Copy Markdown
Member

Sweet! LGTM.

Can we have a high-level summary of what this gets us? I see some regex tweaks and domain changes in there.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mathiasbynens

mathiasbynens commented Nov 28, 2014

Copy link
Copy Markdown
Contributor Author
  • Email address support in toASCII and toUnicode
  • punycode.ucs2.encode now no longer mutates the codePoints argument
  • Ensure trailing . in domain names are preserved
  • Some minor code cleanup + bug fixes
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@indutny

indutny commented Nov 28, 2014

Copy link
Copy Markdown
Member

@mathiasbynens could this be put in a commit message? ;)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@mathiasbynens
punycode: update to v1.3.2
abf21ea
Changes since v1.2.3:

* Email address support in `toASCII` and `toUnicode`
* `punycode.ucs2.encode` now no longer mutates the `codePoints`
  argument
* Ensure trailing `.` in domain names are preserved
* Some minor code cleanup + bug fixes
@mathiasbynens

mathiasbynens commented Nov 28, 2014

Copy link
Copy Markdown
Contributor Author

@indutny Done.

I gotta say, I’m impressed by the swift responses! 👍

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@indutny

indutny commented Nov 28, 2014

Copy link
Copy Markdown
Member

This is just a coincidence, don't get used to it ;)

Anyway, thank you very much!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

indutny pushed a commit that referenced this pull request Nov 28, 2014
@mathiasbynens @indutny
punycode: update to v1.3.2
232c4c2
Changes since v1.2.3:

* Email address support in `toASCII` and `toUnicode`
* `punycode.ucs2.encode` now no longer mutates the `codePoints`
  argument
* Ensure trailing `.` in domain names are preserved
* Some minor code cleanup + bug fixes

Reviewed-By: Fedor Indutny <[email protected]>
PR-URL: #6
@indutny

indutny commented Nov 28, 2014

Copy link
Copy Markdown
Member

Landed in 232c4c2, thank you!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@indutny indutny closed this Nov 28, 2014
@rvagg rvagg mentioned this pull request Jan 3, 2015
governance: Add new Collaborators #234
Closed
@yjhjstz yjhjstz mentioned this pull request May 14, 2015
DebuggerAgent: unhandled socket error event #781
Closed
@kvic-z kvic-z mentioned this pull request Oct 27, 2015
compile error ,target=arm7 #3224
Closed
@jianpingw jianpingw mentioned this pull request Dec 13, 2015
node js 5.2.0 segmentation fault after console.log #4261
Closed
@owenallenaz owenallenaz mentioned this pull request Jan 5, 2016
Memoize causes queued callbacks to jump across domains caolan/async#999
Closed
@dmitryame dmitryame mentioned this pull request Mar 10, 2016
Abort trap: 6 #5646
Closed
@rupamkhaitan rupamkhaitan mentioned this pull request Jun 27, 2016
trap invalid opcode ip:fea6f9 #3898
Closed
@jeroenvollenbrock jeroenvollenbrock mentioned this pull request Jul 11, 2016
v8 GC crash on node 4.4.7 #7654
Closed
@mhhf mhhf mentioned this pull request Aug 24, 2016
Assertion failed ../deps/uv/src/unix/stream.c, line 1563 #8258
Closed
minervapanda pushed a commit to minervapanda/node that referenced this pull request Oct 9, 2016
@lfaraone
Check logged-in state before manipulating the search menu
6c91ca7
Thanks @raicabogdan. Fixes nodejs#6.
@rdkgit rdkgit mentioned this pull request Nov 11, 2016
SSL core dump in v6.9.1 #9551
Closed
thlorenz referenced this pull request in thlorenz/node Nov 21, 2016
@matthewloring Matt Loring
Remove dependency on base trace_event_common.h (#6)
b4d49a9
jasongin pushed a commit to jasongin/nodejs that referenced this pull request Dec 8, 2016
@matthewloring Matt Loring
Remove dependency on base trace_event_common.h (nodejs#6)
4d6ec33
@shyhpei shyhpei mentioned this pull request Feb 3, 2017
segmentation fault at v8::internal::StoreBuffer::EnsureSpace () #11156
Closed
@sxa sxa mentioned this pull request Mar 16, 2017
npm --version segfaults on v7.7.3 linux ppc64 (BE) only ON RHEL 7 #11882
Closed
@joyeecheung joyeecheung mentioned this pull request May 31, 2017
Strange exit after updated to node 8.0.0 #13325
Closed
@milesj milesj mentioned this pull request Jun 6, 2017
Node v8 4-5x slower than previous versions #13445
Closed
@kisondu kisondu mentioned this pull request Jul 18, 2017
v8::internal::JSReceiver::DefineOwnProperty exception cause a crash #14335
Closed
@myitcv myitcv mentioned this pull request Aug 1, 2017
Segfault in v8.2.1 #14567
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 26, 2020
make test: use after free: parallel/test-cli-node-options #21383
Closed
@hashseed hashseed mentioned this pull request Jun 26, 2020
ThreadSanitizer: data race at PlatformWorkerThread::trace_event_unique_atomic35 #26100
Closed
@addaleax addaleax mentioned this pull request Jun 28, 2020
There appears to be a bug with the http2 header decoding #28632
Closed
@KungFuJesus KungFuJesus mentioned this pull request Jul 10, 2020
build 12.13.0 on mips64el segfault around mksnapshot #30304
Closed
@mceachen mceachen mentioned this pull request Aug 12, 2020
lib: add UNC support to url.pathToFileURL() #34743
Closed
5 tasks done
@gengjiawen gengjiawen mentioned this pull request Aug 12, 2020
N-API reference management leaks memory #34731
Closed
@Flarna Flarna mentioned this pull request Aug 14, 2020
[v12.x backport] deps: V8: cherry-pick eec10a2fd8fa and #34008 #34776
Closed
@FlorSanders FlorSanders mentioned this pull request Aug 19, 2020
Raspberry Pi OS, malloc() when running script #34828
Closed
@silverwind silverwind mentioned this pull request Aug 20, 2020
https/http2: random crashes on macOS with simple server #34854
Closed
@dislon dislon mentioned this pull request Sep 4, 2020
Debugger crashes with assertion failure while using Chrome DevTools and remote debug #17259
Open
@tnodejs tnodejs mentioned this pull request Mar 25, 2021
use node 12.9.0 cause carsh problem #37902
Closed
targos referenced this pull request in targos/node Apr 27, 2021
@targos
deps: V8: cherry-pick 516b5d3f9cfe
201c2d9
Original commit message:

    Merged: [wasm-simd][x64] Check for register when emitting shuffles

    Some shuffles take have either register or memory operand for second
    input, but the codegen incorrectly assumes that it is always a register.

    Bug: v8:10824
    (cherry picked from commit ddf30bea13902829eeb71aa0ec747155e27e5a68)

    Change-Id: I897c4290a8b91ff2ab839e98b16a9696c0bae511
    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391280
    Reviewed-by: Bill Budge <[email protected]>
    Commit-Queue: Zhi An Ng <[email protected]>
    Cr-Commit-Position: refs/branch-heads/8.6@{#6}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@516b5d3
targos added a commit that referenced this pull request Apr 30, 2021
@targos
deps: V8: cherry-pick 516b5d3f9cfe
31154a5
Original commit message:

    Merged: [wasm-simd][x64] Check for register when emitting shuffles

    Some shuffles take have either register or memory operand for second
    input, but the codegen incorrectly assumes that it is always a register.

    Bug: v8:10824
    (cherry picked from commit ddf30bea13902829eeb71aa0ec747155e27e5a68)

    Change-Id: I897c4290a8b91ff2ab839e98b16a9696c0bae511
    No-Try: true
    No-Presubmit: true
    No-Tree-Checks: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2391280
    Reviewed-by: Bill Budge <[email protected]>
    Commit-Queue: Zhi An Ng <[email protected]>
    Cr-Commit-Position: refs/branch-heads/8.6@{#6}
    Cr-Branched-From: a64aed2333abf49e494d2a5ce24bbd14fff19f60-refs/heads/8.6.395@{#1}
    Cr-Branched-From: a626bc036236c9bf92ac7b87dc40c9e538b087e3-refs/heads/master@{#69472}

Refs: v8/v8@516b5d3

PR-URL: #38275
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
Reviewed-By: Shelley Vohr <[email protected]>
@alvin-7 alvin-7 mentioned this pull request Dec 15, 2021
create coredump with running in inspect #41178
Closed
@mhdawson mhdawson mentioned this pull request Sep 26, 2022
node-api: generalize finalizer second pass callback #44141
Closed
@theanarkh theanarkh mentioned this pull request Oct 18, 2022
crash when trace ic stats #45052
Closed
@khagankhan khagankhan mentioned this pull request Oct 13, 2023
Use of Uninitialized Memory Detected in bytecode_builtins_list_generator by MemorySanitizer #50171
Closed
@alirezaraha3 alirezaraha3 mentioned this pull request Sep 5, 2024
Duplicate of #6h #54778
Closed
@ronking-zhu ronking-zhu mentioned this pull request Oct 13, 2025
Nodejs official released build has conflict with msodbcsql driver due to incompatible openssl version #60240
Closed
@Mohit-Raj-Saxena Mohit-Raj-Saxena mentioned this pull request Oct 16, 2025
Multiple Documentation Issues in fs and fs/promises Modules (Formatting, Consistency, and Clarity) #60280
Closed
@sadan4 sadan4 mentioned this pull request Nov 5, 2025
NodeJS segfaults when trying to debug this code #60580
Closed
@jackzhp jackzhp mentioned this pull request Nov 5, 2025
Large file download (above 50MB, without "range processing") results in HTTP2_PROTOCOL_ERROR in Chrome #59465
Closed
ndossche added a commit to ndossche/node that referenced this pull request May 21, 2026
@ndossche
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR
c6ea900
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    nodejs#1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    nodejs#2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    nodejs#3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    nodejs#4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    nodejs#5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    nodejs#6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    nodejs#7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    nodejs#8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    nodejs#9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    nodejs#10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    nodejs#11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    nodejs#12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <[email protected]>
nodejs-github-bot pushed a commit that referenced this pull request Jun 2, 2026
@ndossche
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR
458c37b
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    #1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    #2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    #3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    #4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    #5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    #6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    #7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    #8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    #9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    #10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    #11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    #12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <[email protected]>
PR-URL: #63476
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request Jun 18, 2026
@ndossche @aduh95
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR
d82d369
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    #1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    #2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    #3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    #4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    #5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    #6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    #7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    #8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    #9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    #10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    #11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    #12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <[email protected]>
PR-URL: #63476
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request Jun 25, 2026
@ndossche @aduh95
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR
2f4e596
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    #1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    #2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    #3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    #4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    #5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    #6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    #7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    #8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    #9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    #10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    #11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    #12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <[email protected]>
PR-URL: #63476
Reviewed-By: Anna Henningsen <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 30, 2026
@ndossche @aduh95
src: fix edge case when deflateInit2() fails with Z_VERSION_ERROR
44976c6
This function call can fail with `Z_VERSION_ERROR` if the compiled
library vs loaded library mismatched in version number or in
stream structure size.
In those cases, zlib doesn't initialize the `strm_.msg` field to
null. Therefore, when a `CompressionError` object is created via
`ErrorForMessage()`, it can read a stale or uninitialized `strm_.msg`
pointer that will cause a crash.

Example ASAN report:
```
AddressSanitizer: SEGV on unknown address
    #0 __strlen_avx2
        string/../sysdeps/x86_64/multiarch/strlen-avx2.S:76
    #1 strlen (/work/node/out/Debug/node+0x1a42ab7)
    #2 v8::(anonymous namespace)::StringLength(char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7581:16
    #3 v8::(anonymous namespace)::StringLength(unsigned char const*)
        /work/node/out/../deps/v8/src/api/api.cc:7587:10
    #4 v8::String::NewFromOneByte(v8::Isolate*,
        unsigned char const*, v8::NewStringType, int)
        /work/node/out/../deps/v8/src/api/api.cc:7677:3
    #5 node::OneByteString(v8::Isolate*,
        char const*, int, v8::NewStringType)
        /work/node/out/../src/util-inl.h:166:10
    #6 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::EmitError(node::(anonymous namespace)
        ::CompressionError const&)
        /work/node/out/../src/node_zlib.cc:565:7
    #7 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::CheckError()
        /work/node/out/../src/node_zlib.cc:519:5
    #8 node::(anonymous namespace)::CompressionStream<
        node::(anonymous namespace)::ZlibContext>
        ::AfterThreadPoolWork(int)
        /work/node/out/../src/node_zlib.cc:543:10
    #9 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::operator()(uv_work_s*, int) const
        /work/node/out/../src/threadpoolwork-inl.h:57:15
    #10 node::ThreadPoolWork::ScheduleWork()
        ::'lambda'(uv_work_s*, int)
        ::__invoke(uv_work_s*, int)
        /work/node/out/../src/threadpoolwork-inl.h:48:7
    #11 uv__work_done /work/libuv-1.51.0/src/threadpool.c:330:5
    #12 uv__async_io.part.0
        /work/libuv-1.51.0/src/unix/async.c:208:5
```

Signed-off-by: ndossche <[email protected]>
PR-URL: #63476
Reviewed-By: Anna Henningsen <[email protected]>
@61465 61465 mentioned this pull request Oct 14, 2026
Buffer.concat and Buffer.copy silently produce invalid results when the operation involves indices equal or greater than 2^32 #55422
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@mathiasbynens @rvagg @indutny
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.