GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: note about Android support by Trott · Pull Request #6040 · nodejs/node

Conversation

@Trott

@Trott Trott commented Apr 4, 2016

Copy link
Copy Markdown
Member

Pull Request check-list

  • Is the commit message formatted according to [CONTRIBUTING.md][0]?

Affected core subsystem(s)

doc build arm

Description of change

Android is not supported at this time, so let's make sure people know that before they get too far.

Refs: #6035

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Trott Trott added doc Issues and PRs related to Node.js documentation. build Issues and PRs related to Node.js builds or CI infrastructure. arm Issues and PRs related to the ARM architecture. labels Apr 4, 2016
@Trott Trott mentioned this pull request Apr 4, 2016
Build from sources for android fails (cctest link failure?) #6035
Closed
@Trott
Trott force-pushed the not-supported branch 2 times, most recently from f5d36fc to 7a2c3bd Compare April 4, 2016 17:55
mscdex
mscdex reviewed Apr 4, 2016
View reviewed changes
Comment thread BUILDING.md Outdated

@mscdex mscdex Apr 4, 2016

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a small nit, but perhaps it should say is not an officially supported platform?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@Trott Trott Apr 5, 2016

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mscdex I agree with your nit. Updating now...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@cjihrig

cjihrig commented Apr 4, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
1 similar comment
@jasnell

jasnell commented Apr 4, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott added 2 commits April 4, 2016 20:28
@Trott
doc: note about Android support
c641fde 
Refs: nodejs#6035
@Trott
fixup per mscdex and cjihrig
59c5bac
@Trott
Trott force-pushed the not-supported branch from 7a2c3bd to 59c5bac Compare April 5, 2016 03:33
@mscdex

mscdex commented Apr 5, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Trott added a commit to Trott/io.js that referenced this pull request Apr 6, 2016
@Trott
doc: note about Android support
0f3c3b4 
PR-URL: nodejs#6040
Refs: nodejs#6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
@Trott

Trott commented Apr 6, 2016

Copy link
Copy Markdown
Member Author

Landed in 0f3c3b4
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott Trott closed this Apr 6, 2016
@jasnell jasnell added the lts-watch-v4.x label Apr 7, 2016
MylesBorins pushed a commit that referenced this pull request Apr 11, 2016
@Trott Myles Borins
doc: note about Android support
f16802f 
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels Apr 11, 2016
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
V4.4.3 proposal #6149
Merged
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@Trott Myles Borins
doc: note about Android support
fa6181c 
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott Myles Borins
doc: note about Android support
fd8e7de 
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
V5.10.2 proposal #6311
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott Myles Borins
doc: note about Android support
bc0ee06 
PR-URL: #6040
Refs: #6035
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Brian White <[email protected]>
This was referenced Apr 21, 2016
V5.11.0 proposal #6321
Closed
V5.11.0 proposal #6322
Closed
@Trott
Trott deleted the not-supported branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM architecture. build Issues and PRs related to Node.js builds or CI infrastructure. doc Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@Trott @cjihrig @jasnell @mscdex @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.