GeezerVison

@@            Coverage Diff             @@
##             main   #60462      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.02%     
==========================================
  Files         704      704              
  Lines      208753   208760       +7     
  Branches    40279    40280       +1     
==========================================
- Hits       184844   184821      -23     
- Misses      15919    15930      +11     
- Partials     7990     8009      +19     

... and 31 files with indirect coverage changes

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

- Loading data for nodejs/node/pull/60462
✔  Done loading data for nodejs/node/pull/60462
----------------------------------- PR info ------------------------------------
Title      sqlite: fix segfault SQLTagStore when db handle is garbage collected (#60462)
Author     Bart Louwers <[email protected]> (@louwers)
Branch     louwers:fix-60448 -> nodejs:main
Labels     c++, sqlite
Commits    3
 - sqlite: change approach to fix segfault SQLTagStore
 - sqlite: add eslint ignore for no-void
 - sqlite: remove redundant parameter
Committers 1
 - Bart Louwers <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/60462
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60462
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
Reviewed-By: Zeyu "Alex" Yang <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 28 Oct 2025 15:01:30 GMT
   ✔  Approvals: 5
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60462#pullrequestreview-3389333091
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/60462#pullrequestreview-3657775960
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/60462#pullrequestreview-3624591879
   ✔  - Gürgün Dayıoğlu (@gurgunday): https://github.com/nodejs/node/pull/60462#pullrequestreview-3684621830
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/60462#pullrequestreview-3684626705
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-01-20T20:59:49Z: https://ci.nodejs.org/job/node-test-pull-request/70927/
- Querying data for job/node-test-pull-request/70927/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 60462
From https://github.com/nodejs/node
 * branch                  refs/pull/60462/merge -> FETCH_HEAD
✔  Fetched commits as 74c365846533..20a0eed2c829
--------------------------------------------------------------------------------
Auto-merging src/node_sqlite.cc
Auto-merging src/node_sqlite.h
Auto-merging test/parallel/test-sqlite-template-tag.js
[main c05ac0c37b] sqlite: change approach to fix segfault SQLTagStore
 Author: Bart Louwers <[email protected]>
 Date: Sat Jan 3 23:19:30 2026 +0100
 3 files changed, 51 insertions(+), 7 deletions(-)
Auto-merging test/parallel/test-sqlite-template-tag.js
[main 7d9121e572] sqlite: add eslint ignore for no-void
 Author: Bart Louwers <[email protected]>
 Date: Sat Jan 3 23:31:19 2026 +0100
 1 file changed, 2 insertions(+), 1 deletion(-)
Auto-merging src/node_sqlite.cc
Auto-merging src/node_sqlite.h
[main 2a32ac0336] sqlite: remove redundant parameter
 Author: Bart Louwers <[email protected]>
 Date: Sun Jan 4 00:25:53 2026 +0100
 2 files changed, 5 insertions(+), 11 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
(node:2364) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
sqlite: change approach to fix segfault SQLTagStore
PR-URL: #60462

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Gürgün Dayıoğlu <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>
[detached HEAD 44bed5cdfc] sqlite: change approach to fix segfault SQLTagStore

Author: Bart Louwers <[email protected]>

Date: Sat Jan 3 23:19:30 2026 +0100

3 files changed, 51 insertions(+), 7 deletions(-)

Rebasing (3/6)

Rebasing (4/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

sqlite: add eslint ignore for no-void
PR-URL: #60462

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Gürgün Dayıoğlu <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>
[detached HEAD 9b9492e455] sqlite: add eslint ignore for no-void

Author: Bart Louwers <[email protected]>

Date: Sat Jan 3 23:31:19 2026 +0100

1 file changed, 2 insertions(+), 1 deletion(-)

Rebasing (5/6)

Rebasing (6/6)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

sqlite: remove redundant parameter
PR-URL: #60462

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>

Reviewed-By: Anna Henningsen <[email protected]>

Reviewed-By: Gürgün Dayıoğlu <[email protected]>

Reviewed-By: Zeyu "Alex" Yang <[email protected]>
[detached HEAD 5c9047f816] sqlite: remove redundant parameter

Author: Bart Louwers <[email protected]>

Date: Sun Jan 4 00:25:53 2026 +0100

2 files changed, 5 insertions(+), 11 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.