GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — doc: remove usage of util.inherits by AugustinMauroy · Pull Request #60817 · nodejs/node

Conversation

AugustinMauroy commented Nov 22, 2025

Copy link

Copy Markdown

Member

Description

Removing legacy api mention in doc
Removing Legacy api usage in test I just found it by doing a search for mention of it

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot added the needs-ci PRs that need a full CI run. label

Nov 22, 2025

codecov Bot commented Nov 22, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.55%. Comparing base (93c2581) to head (100af7f).
⚠️ Report is 874 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #60817      +/-   ##
==========================================
+ Coverage   88.43%   88.55%   +0.11%     
==========================================
  Files         703      703              
  Lines      208235   208254      +19     
  Branches    40085    40159      +74     
==========================================
+ Hits       184162   184424     +262     
+ Misses      16069    15828     -241     
+ Partials     8004     8002       -2

see 53 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

anonrig approved these changes

Nov 23, 2025

View reviewed changes

aduh95 commented Nov 23, 2025

Copy link

Copy Markdown

Contributor

The doc part LGTM, can you remove the test change? IMO we want to validate there are no regressions on legacy APIs

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AugustinMauroy commented Nov 23, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

There are a specific test for this api. I had checked that . (I am on mobile I can't give the name of the test file)

EDIT: file is test-util-inherits.js

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 commented Nov 23, 2025

Copy link

Copy Markdown

Contributor

I would still prefer the test change gets to be discussed separately

AugustinMauroy reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aymen94 approved these changes

Dec 1, 2025

View reviewed changes

aduh95 commented Dec 1, 2025

Copy link

Copy Markdown

Contributor

@AugustinMauroy can you please split the PR as requested?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AugustinMauroy commented Dec 1, 2025

Copy link

Copy Markdown

Member Author

@AugustinMauroy can you please split the PR as requested?

I'm going to do that. kind of busy

aduh95 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AugustinMauroy force-pushed the remove-util.inherits branch from 100af7f to f3cce25 Compare

May 7, 2026 17:10

AugustinMauroy changed the title ~~doc,test: remove usage of util.inherits~~ doc: remove usage of util.inherits

May 7, 2026

AugustinMauroy commented May 7, 2026

Copy link

Copy Markdown

Member Author

yup done x'D

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

AugustinMauroy force-pushed the remove-util.inherits branch from f3cce25 to c3bdd0d Compare

May 7, 2026 20:11

github-actions Bot commented Aug 6, 2026

Copy link

Copy Markdown

Contributor

This pull request has been marked as stale due to 90 days of inactivity.
It will be automatically closed in 30 days if no further activity occurs. If this is still relevant, please leave a comment or update it to keep it open.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

github-actions Bot added the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label

Aug 6, 2026

AugustinMauroy commented Aug 6, 2026

Copy link

Copy Markdown

Member Author

not stale

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 approved these changes

Aug 6, 2026

View reviewed changes


          doc: remove usage of util.inherits

cb31667

Signed-off-by: Augustin Mauroy <[email protected]>

aduh95 force-pushed the remove-util.inherits branch from c3bdd0d to cb31667 Compare

August 6, 2026 22:19

aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label

Aug 6, 2026

aduh95 closed this

Aug 6, 2026

aduh95 reopened this

Aug 6, 2026

github-actions Bot removed the stale Issues and PRs marked stale due to inactivity and scheduled for automatic closure. label

Aug 7, 2026

aduh95 closed this

Aug 7, 2026

aduh95 reopened this

Aug 7, 2026

aduh95 added doc Issues and PRs related to Node.js documentation. and removed needs-ci PRs that need a full CI run. labels

Aug 7, 2026

aduh95 merged commit e43bedc into nodejs:main

Aug 7, 2026

18 checks passed

Uh oh!

There was an error while loading. Please reload this page.

aduh95 commented Aug 7, 2026

Copy link

Copy Markdown

Contributor

Landed in e43bedc

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

aduh95 pushed a commit that referenced this pull request

Aug 13, 2026


          doc: remove usage of util.inherits

96b764c

Signed-off-by: Augustin Mauroy <[email protected]>
PR-URL: #60817
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 25, 2026


          doc: remove usage of util.inherits

c5588d7

Signed-off-by: Augustin Mauroy <[email protected]>
PR-URL: #60817
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

github-actions Bot mentioned this pull request

Aug 25, 2026

2026-08-26, Version 26.8.0 (Current) #65551

Merged

aduh95 pushed a commit that referenced this pull request

Aug 27, 2026


          doc: remove usage of util.inherits

314f9b2

Signed-off-by: Augustin Mauroy <[email protected]>
PR-URL: #60817
Reviewed-By: Yagiz Nizipli <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

github-actions Bot mentioned this pull request

Sep 7, 2026

2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873

Merged

Reviewers

anonrig

anonrig approved these changes

aduh95

aduh95 approved these changes

+1 more reviewer

aymen94

aymen94 approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

doc

Issues and PRs related to Node.js documentation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

AugustinMauroy commented Nov 22, 2025

Description

Uh oh!

codecov Bot commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aduh95 commented Nov 23, 2025

Uh oh!

AugustinMauroy commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 commented Nov 23, 2025

Uh oh!

aduh95 commented Dec 1, 2025

Uh oh!

AugustinMauroy commented Dec 1, 2025

Uh oh!

AugustinMauroy commented May 7, 2026

Uh oh!

github-actions Bot commented Aug 6, 2026

Uh oh!

AugustinMauroy commented Aug 6, 2026

Uh oh!

Uh oh!

aduh95 commented Aug 7, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Nov 22, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

AugustinMauroy commented Nov 23, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.