GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — fs: fix errorOnExist behavior for directory copy in fs.cp by npaun · Pull Request #60946 · nodejs/node

fs: fix errorOnExist behavior for directory copy in fs.cp #60946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

nodejs-github-bot merged 1 commit into nodejs:main from npaun:fix-fs-cp-errorOnExist-directory

Jan 17, 2026

Uh oh!

There was an error while loading. Please reload this page.

Merged

fs: fix errorOnExist behavior for directory copy in fs.cp #60946

Show file tree

Hide file tree

Changes from all commits

Commits

Show all changes

1 commit

Select commit

726ef1f

fs: fix errorOnExist behavior for directory copy in fs.cp

npaun Dec 3, 2025

File filter

Filter by extension .js (1) .mjs (1) All 2 file types selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

There are no files selected for viewing

11 changes: 10 additions & 1 deletion 11 lib/internal/fs/cp/cp.js

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -300,8 +300,17 @@ async function setDestTimestamps(src, dest) {
		return utimes(dest, updatedSrcStat.atime, updatedSrcStat.mtime);
		}

		function onDir(srcStat, destStat, src, dest, opts) {
		async function onDir(srcStat, destStat, src, dest, opts) {
		if (!destStat) return mkDirAndCopy(srcStat.mode, src, dest, opts);
		if (opts.errorOnExist && !opts.force) {
		throw new ERR_FS_CP_EEXIST({
		message: `${dest} already exists`,
		path: dest,
		syscall: 'cp',
		errno: EEXIST,
		code: 'EEXIST',
		});
		}
		return copyDir(src, dest, opts);
		}

Expand Down

30 changes: 30 additions & 0 deletions 30 test/parallel/test-fs-cp-async-dir-exists-error-on-exist.mjs

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,30 @@
		// This tests that cp() returns error if errorOnExist is true, force is false,
		// and the destination directory already exists (even if contents don't conflict).

		import { mustCall } from '../common/index.mjs';
		import { nextdir } from '../common/fs.js';
		import assert from 'node:assert';
		import { cp, mkdirSync, writeFileSync } from 'node:fs';
		import tmpdir from '../common/tmpdir.js';

		tmpdir.refresh();

		const src = nextdir();
		const dest = nextdir();

		// Create source directory with a file
		mkdirSync(src);
		writeFileSync(`${src}/file.txt`, 'test');

		// Create destination directory with different file
		mkdirSync(dest);
		writeFileSync(`${dest}/other.txt`, 'existing');

		// Should fail because dest directory already exists
		cp(src, dest, {
		recursive: true,
		errorOnExist: true,
		force: false,
		}, mustCall((err) => {
		assert.strictEqual(err.code, 'ERR_FS_CP_EEXIST');
		}));

Oops, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.