GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — inspector: fix compressed responses by rubnogueira · Pull Request #61226 · nodejs/node

Conversation

rubnogueira commented Dec 30, 2025

Copy link

Copy Markdown

Contributor

fix: #61222

Using Chrome DevTools inspector tool, the response of the compressed requests is full of garbled symbols.

This PR implements proper compression decryption if the content-encoding header is returned in the response headers.

Repro here: https://github.com/rubnogueira/nodejs-repro-61222

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot commented Dec 30, 2025

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/inspector

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added http2

Issues and PRs related to the http2 subsystem.

inspector

Issues and PRs related to the V8 inspector protocol.

needs-ci PRs that need a full CI run. labels

Dec 30, 2025

rubnogueira commented Dec 30, 2025

Copy link

Copy Markdown

Contributor Author

Tagging you @legendecas because I saw some of your work on the inspector.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Dec 30, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

❌ Patch coverage is 98.76543% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.53%. Comparing base (ce2ec3d) to head (061f1a2).
⚠️ Report is 172 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/inspector/network_http.js	98.48%	1 Missing ⚠️
lib/internal/inspector/network_http2.js	98.48%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61226      +/-   ##
==========================================
- Coverage   88.54%   88.53%   -0.01%     
==========================================
  Files         704      704              
  Lines      208734   208866     +132     
  Branches    40271    40300      +29     
==========================================
+ Hits       184823   184927     +104     
- Misses      15932    15945      +13     
- Partials     7979     7994      +15

Files with missing lines	Coverage Δ
lib/internal/inspector/network.js	`96.89% <100.00%> (+0.93%)`	⬆️
lib/internal/inspector/network_http.js	`95.93% <98.48%> (+0.66%)`	⬆️
lib/internal/inspector/network_http2.js	`89.32% <98.48%> (+1.58%)`	⬆️

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

rubnogueira added 2 commits

December 31, 2025 10:46


          inspector: fix compressed responses

b967c69


          inspector: lint code

cc3f224

rubnogueira force-pushed the main branch from 2a5c76c to cc3f224 Compare

December 31, 2025 10:47

rubnogueira changed the title ~~fix: zipped responses~~ inspector: fix compressed responses

Dec 31, 2025


          inspector: remove irrelevant code

520e278

rubnogueira commented Dec 31, 2025

Copy link

Copy Markdown

Contributor Author

I just removed irrelevant code, improved testing/linting, built locally Node binary, and tested against my repro. Rebased first commit message following guidelines.

Please let me know if something is missing since it's my first contribution in this repo.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          inspector: remove irrelevant file

06183cd

legendecas reviewed

Jan 8, 2026

View reviewed changes

legendecas left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

test/parallel/test-inspector-network-http-compressed.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

test/parallel/test-inspector-network-http2-compressed.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

legendecas added commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

http Issues and PRs related to the http subsystem. labels

Jan 8, 2026


          inspector: fix tests and inline

061f1a2

rubnogueira commented Jan 14, 2026

Copy link

Copy Markdown

Contributor Author

@legendecas can you please review my last changes? thanks!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas approved these changes

Jan 14, 2026

View reviewed changes

legendecas added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Jan 14, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jan 14, 2026

nodejs-github-bot commented Jan 14, 2026

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70803/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

cola119 approved these changes

Jan 17, 2026

View reviewed changes

nodejs-github-bot commented Jan 19, 2026

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70893/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas added the commit-queue PRs queued for automated landing through the Commit Queue. label

Jan 20, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Jan 20, 2026

nodejs-github-bot commented Jan 20, 2026

Copy link

Copy Markdown

Collaborator

Commit Queue failed

- Loading data for nodejs/node/pull/61226
✔  Done loading data for nodejs/node/pull/61226
----------------------------------- PR info ------------------------------------
Title      inspector: fix compressed responses (#61226)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     rubnogueira:main -> nodejs:main
Labels     http, inspector, http2, author ready, needs-ci, commit-queue-squash
Commits    5
 - inspector: fix compressed responses
 - inspector: lint code
 - inspector: remove irrelevant code
 - inspector: remove irrelevant file
 - inspector: fix tests and inline
Committers 1
 - Ruben Nogueira <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/61226
Fixes: https://github.com/nodejs/node/issues/61222
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61226
Fixes: https://github.com/nodejs/node/issues/61222
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 30 Dec 2025 20:14:26 GMT
   ✔  Approvals: 2
   ✔  - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/61226#pullrequestreview-3660965504
   ✔  - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/61226#pullrequestreview-3673245165
   ✘  Last GitHub CI failed
   ℹ  Last Full PR CI on 2026-01-19T18:02:47Z: https://ci.nodejs.org/job/node-test-pull-request/70893/
- Querying data for job/node-test-pull-request/70893/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/21187587953

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas removed the commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. label

Jan 22, 2026

legendecas pushed a commit that referenced this pull request

Jan 22, 2026


          inspector: fix compressed responses

186c7a9

PR-URL: #61226
Fixes: #61222
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>

legendecas commented Jan 22, 2026

Copy link

Copy Markdown

Member

Landed in 186c7a9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas closed this

Jan 22, 2026

legendecas mentioned this pull request

Jan 22, 2026

inspector: add protocol methods retrieving sent/received data #58645

Merged

aduh95 mentioned this pull request

Jan 24, 2026

Revert "inspector: fix compressed responses" #61502

Merged

aduh95 added dont-land-on-v20.x dont-land-on-v22.x

PRs that should not land on the v22.x-staging branch and should not be released in v22.x.

dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels

Jan 24, 2026

aduh95 commented Jan 24, 2026

Copy link

Copy Markdown

Contributor

This PR introduced a flaky test, too bad #61226 (comment) was resumed despite showing the added test failing.

I've opened a revert in #61502.

intellix reacted with confused emoji

All reactions

😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas mentioned this pull request

Apr 8, 2026

inspector: fix compressed responses #62630

Closed

legendecas pushed a commit to legendecas/node that referenced this pull request

Apr 9, 2026


          inspector: fix compressed responses

6f279d8

PR-URL: nodejs#61226
Fixes: nodejs#61222
Reviewed-By: Chengzhong Wu <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>

RafaelGSS mentioned this pull request

Apr 27, 2026

2026-05-05, Version 26.0.0 (Current) #62526

Merged

Reviewers

legendecas

legendecas approved these changes

cola119

cola119 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

dont-land-on-v22.x

PRs that should not land on the v22.x-staging branch and should not be released in v22.x.

dont-land-on-v24.x

PRs that should not land on the v24.x-staging branch and should not be released in v24.x.

http

Issues and PRs related to the http subsystem.

http2

Issues and PRs related to the http2 subsystem.

inspector

Issues and PRs related to the V8 inspector protocol.

needs-ci

PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--experimental-network-inspection not working properly with gzip, br, zstd and response

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

rubnogueira commented Dec 30, 2025

Uh oh!

nodejs-github-bot commented Dec 30, 2025

Uh oh!

rubnogueira commented Dec 30, 2025

Uh oh!

codecov Bot commented Dec 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rubnogueira commented Dec 31, 2025

Uh oh!

legendecas left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rubnogueira commented Jan 14, 2026

Uh oh!

nodejs-github-bot commented Jan 14, 2026

Uh oh!

nodejs-github-bot commented Jan 19, 2026

Uh oh!

nodejs-github-bot commented Jan 20, 2026

Uh oh!

legendecas commented Jan 22, 2026

Uh oh!

aduh95 commented Jan 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov Bot commented Dec 30, 2025 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.