GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test_runner: print coverage and diagnostic info with dot reporter by mag123c · Pull Request #61423 · nodejs/node

Conversation

mag123c commented Jan 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

This PR adds coverage and diagnostic output to the dot reporter in test_runner.

Currently, when using the dot reporter with coverage enabled, if a coverage threshold fails the program exits with code 1 but prints nothing about why. Users have no way to know what went wrong. The spec reporter already handles this correctly.

Changes:

dot.js: handle test:diagnostic events at error level (coverage threshold failure messages)
dot.js: handle test:coverage events (coverage report table)

The dot reporter now behaves consistently with the spec reporter for coverage output.

Fixes: #60884

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

nodejs-github-bot commented Jan 18, 2026

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/test_runner

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added needs-ci

PRs that need a full CI run.

test_runner Issues and PRs related to the test runner subsystem. labels

Jan 18, 2026

mag123c force-pushed the fix-dot-reporter-coverage branch from 83840c7 to 313a274 Compare

January 18, 2026 06:34

codecov Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.13%. Comparing base (1ba3ce4) to head (f27934e).
⚠️ Report is 453 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/test_runner/reporter/dot.js	33.33%	15 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #61423      +/-   ##
==========================================
- Coverage   90.14%   90.13%   -0.02%     
==========================================
  Files         743      743              
  Lines      242415   242438      +23     
  Branches    45651    45655       +4     
==========================================
- Hits       218531   218517      -14     
- Misses      15386    15424      +38     
+ Partials     8498     8497       -1

Files with missing lines	Coverage Δ
lib/internal/test_runner/reporter/dot.js	`74.60% <33.33%> (-25.40%)`	⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pmarchini commented Jan 20, 2026

Copy link

Copy Markdown

Member

Hey @mag123c, could you please add some tests?

mag123c reacted with eyes emoji

All reactions

👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

atlowChemi approved these changes

Jan 20, 2026

View reviewed changes

pmarchini reviewed

Jan 31, 2026

View reviewed changes

Comment thread

test/parallel/test-runner-coverage-thresholds.js

		@@ -170,4 +170,25 @@ for (const coverage of coverages) {
		assert.strictEqual(result.status, 1);
		assert(!findCoverageFileForPid(result.pid));
		});

		test(`test failing ${coverage.flag} with dot reporter`, () => {

pmarchini Jan 31, 2026

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: I would suggest adding a snapshot test too, like as we have done in test/test-runner/test-output-coverage-width-100-uncovered-lines.mjs 👀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mag123c reacted with rocket emoji

mag123c reacted with eyes emoji

All reactions

🚀 1 reaction
👀 1 reaction

mag123c Feb 6, 2026

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmarchini Thanks! I did!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

madkate42 mentioned this pull request

Feb 19, 2026

test_runner: print coverage and diagnostics with dot reporter #61891

Closed

meixg approved these changes

Mar 4, 2026

View reviewed changes

meixg added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Mar 4, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Mar 4, 2026

nodejs-github-bot commented Mar 4, 2026

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71552/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Mar 10, 2026

test_runner: print failed coverage reports with dot runner #62078

Closed

test_runner: print failed coverage reports with dot reporter fixes #60884 #62091

Closed

atlowChemi mentioned this pull request

Jul 8, 2026

test_runner: display diagnostic messages in dot reporter #64331

Closed

mag123c added 3 commits

July 26, 2026 15:15


          test_runner: print coverage and diagnostic info with dot reporter

abc01ac

When using the dot reporter with coverage enabled, coverage threshold
failures and coverage reports were not printed, only an exit code was
returned. This made it impossible to know why the test run failed.

This change adds handling for test:diagnostic and test:coverage events
to the dot reporter, matching the behavior of the spec reporter.

Fixes: nodejs#60884
Signed-off-by: mag123c <[email protected]>


          test: add dot reporter coverage threshold tests

Signed-off-by: mag123c <[email protected]>


          test: add snapshot test for dot reporter coverage threshold

f27934e

Signed-off-by: mag123c <[email protected]>

mag123c force-pushed the fix-dot-reporter-coverage branch from 1f59f26 to f27934e Compare

July 26, 2026 06:28

mag123c commented Jul 26, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor Author

One thing worth flagging for whoever picks this up: several newer PRs now touch the same handler in lib/internal/test_runner/reporter/dot.js — #64695, #64578, #64331, and #62234. They overlap with this one to varying degrees, and it would probably save everyone time to decide which should land rather than reviewing them independently. Happy to close this in favour of another if that is the cleaner path.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

avivkeller approved these changes

Jul 26, 2026

View reviewed changes

avivkeller added author ready

PRs with CI started, the required approvals, and no outstanding review comments.

request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Jul 26, 2026

github-actions Bot added request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels

Jul 26, 2026

github-actions Bot commented Jul 26, 2026

Copy link

Copy Markdown

Contributor

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71552/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/30192660637

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

mcollina added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels

Jul 26, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jul 26, 2026

github-actions Bot added the request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. label

Jul 26, 2026

github-actions Bot commented Jul 26, 2026

Copy link

Copy Markdown

Contributor

Failed to start CI

- Validating Jenkins credentials
✔  Jenkins credentials valid
- Querying data for job/node-test-pull-request/71552/
[SyntaxError: Unexpected token '<', ..."    
  https://github.com/nodejs/node/actions/runs/30195826270

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Aug 22, 2026

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76194/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Aug 22, 2026

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76228/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

trivikr added commit-queue-squash

PRs the Commit Queue should land as one squashed commit.

commit-queue PRs queued for automated landing through the Commit Queue. and removed request-ci-failed Starting CI with the request-ci label failed and requires manual intervention. labels

Aug 22, 2026

nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels

Aug 22, 2026

nodejs-github-bot commented Aug 22, 2026

Copy link

Copy Markdown

Collaborator

Commit Queue failed

   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
   ✘  GitHub CI is still running

The pull request was removed from the Commit Queue and labeled commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. . After resolving the failure, remove that label and add commit-queue PRs queued for automated landing through the Commit Queue. to retry.

Full Commit Queue output

- Loading data for nodejs/node/pull/61423
✔  Done loading data for nodejs/node/pull/61423
----------------------------------- PR info ------------------------------------
Title      test_runner: print coverage and diagnostic info with dot reporter (#61423)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     mag123c:fix-dot-reporter-coverage -> nodejs:main
Labels     author ready, needs-ci, commit-queue, commit-queue-squash, test_runner
Commits    3
 - test_runner: print coverage and diagnostic info with dot reporter
 - test: add dot reporter coverage threshold tests
 - test: add snapshot test for dot reporter coverage threshold
Committers 1
 - mag123c <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/61423
Fixes: https://github.com/nodejs/node/issues/60884
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61423
Fixes: https://github.com/nodejs/node/issues/60884
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 18 Jan 2026 05:51:21 GMT
   ✔  Approvals: 3
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/61423#pullrequestreview-3684244207
   ✔  - Xuguang Mei (@meixg): https://github.com/nodejs/node/pull/61423#pullrequestreview-3886895102
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/61423#pullrequestreview-4781137424
   ✘  GitHub CI is still running
   ℹ  Last Full PR CI on 2026-08-22T17:35:00Z: https://ci.nodejs.org/job/node-test-pull-request/76228/
- Querying data for job/node-test-pull-request/76228/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

View workflow run

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

trivikr removed commit-queue-failed

PRs whose Commit Queue landing failed and need manual intervention before retrying.

commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels

Aug 22, 2026

trivikr pushed a commit that referenced this pull request

Aug 22, 2026


          test_runner: print coverage and diagnostic info with dot reporter

2858f34

When using the dot reporter with coverage enabled, coverage threshold
failures and coverage reports were not printed, only an exit code was
returned. This made it impossible to know why the test run failed.

This change adds handling for test:diagnostic and test:coverage events
to the dot reporter, matching the behavior of the spec reporter.

Fixes: #60884
Signed-off-by: mag123c <[email protected]>
PR-URL: #61423
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>

trivikr commented Aug 22, 2026

Copy link

Copy Markdown

Member

Landed in 2858f34

mag123c reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

trivikr closed this

Aug 22, 2026

aduh95 pushed a commit that referenced this pull request

Aug 25, 2026


          test_runner: print coverage and diagnostic info with dot reporter

e36cc15

When using the dot reporter with coverage enabled, coverage threshold
failures and coverage reports were not printed, only an exit code was
returned. This made it impossible to know why the test run failed.

This change adds handling for test:diagnostic and test:coverage events
to the dot reporter, matching the behavior of the spec reporter.

Fixes: #60884
Signed-off-by: mag123c <[email protected]>
PR-URL: #61423
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 25, 2026


          test_runner: print coverage and diagnostic info with dot reporter

79c39c2

When using the dot reporter with coverage enabled, coverage threshold
failures and coverage reports were not printed, only an exit code was
returned. This made it impossible to know why the test run failed.

This change adds handling for test:diagnostic and test:coverage events
to the dot reporter, matching the behavior of the spec reporter.

Fixes: #60884
Signed-off-by: mag123c <[email protected]>
PR-URL: #61423
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>

github-actions Bot mentioned this pull request

Aug 25, 2026

2026-08-26, Version 26.8.0 (Current) #65551

Merged

aduh95 pushed a commit that referenced this pull request

Aug 27, 2026


          test_runner: print coverage and diagnostic info with dot reporter

When using the dot reporter with coverage enabled, coverage threshold
failures and coverage reports were not printed, only an exit code was
returned. This made it impossible to know why the test run failed.

This change adds handling for test:diagnostic and test:coverage events
to the dot reporter, matching the behavior of the spec reporter.

Fixes: #60884
Signed-off-by: mag123c <[email protected]>
PR-URL: #61423
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>

This was referenced Aug 28, 2026

test_runner: print failed coverage reports with dot runner #65628

Closed

test_runner: display coverage errors in dot reporter #64695

Closed

github-actions Bot mentioned this pull request

Sep 7, 2026

2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873

Merged

aduh95 pushed a commit that referenced this pull request

Sep 7, 2026


          test_runner: print coverage and diagnostic info with dot reporter

2df1681

When using the dot reporter with coverage enabled, coverage threshold
failures and coverage reports were not printed, only an exit code was
returned. This made it impossible to know why the test run failed.

This change adds handling for test:diagnostic and test:coverage events
to the dot reporter, matching the behavior of the spec reporter.

Fixes: #60884
Signed-off-by: mag123c <[email protected]>
PR-URL: #61423
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>

aduh95 pushed a commit that referenced this pull request

Sep 7, 2026


          test_runner: print coverage and diagnostic info with dot reporter

b06c61a

When using the dot reporter with coverage enabled, coverage threshold
failures and coverage reports were not printed, only an exit code was
returned. This made it impossible to know why the test run failed.

This change adds handling for test:diagnostic and test:coverage events
to the dot reporter, matching the behavior of the spec reporter.

Fixes: #60884
Signed-off-by: mag123c <[email protected]>
PR-URL: #61423
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>

Reviewers

pmarchini

pmarchini left review comments

meixg

meixg approved these changes

avivkeller

avivkeller approved these changes

atlowChemi

atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

needs-ci

PRs that need a full CI run.

test_runner

Issues and PRs related to the test runner subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_runner: print failed coverage reports with dot runner

Uh oh!

There was an error while loading. Please reload this page.

8 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

mag123c commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 18, 2026

Uh oh!

codecov Bot commented Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

pmarchini commented Jan 20, 2026

Uh oh!

pmarchini Jan 31, 2026

Choose a reason for hiding this comment

Uh oh!

mag123c Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Mar 4, 2026

Uh oh!

mag123c commented Jul 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jul 26, 2026

Uh oh!

github-actions Bot commented Jul 26, 2026

Uh oh!

nodejs-github-bot commented Aug 22, 2026

Uh oh!

nodejs-github-bot commented Aug 22, 2026

Uh oh!

nodejs-github-bot commented Aug 22, 2026

Commit Queue failed

Uh oh!

trivikr commented Aug 22, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mag123c commented Jan 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

codecov Bot commented Jan 18, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

mag123c commented Jul 26, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.