GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — deps: update V8 to 14.6 by targos · Pull Request #61898 · nodejs/node

Conversation

targos commented Feb 20, 2026

Copy link

Copy Markdown

Member

PR for previous version: #61681

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bricss and worstpractice reacted with thumbs up emoji

bricss, Aditi-1400, and worstpractice reacted with hooray emoji

bricss and worstpractice reacted with heart emoji

bricss, riya-amemiya, H4ad, and worstpractice reacted with rocket emoji

All reactions

👍 2 reactions
🎉 3 reactions
❤️ 2 reactions
🚀 4 reactions

nodejs-github-bot commented Feb 20, 2026

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/gyp
@nodejs/security-wg
@nodejs/v8-update

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

v8 engine Issues and PRs related to the V8 dependency. labels

Feb 20, 2026

targos commented Feb 20, 2026

Copy link

Copy Markdown

Member Author

Compared to version 14.5, there is a new test failure that is not obvious. Local run:

=== release test-repl-mode ===                                                
Path: parallel/test-repl-mode
node:internal/assert/utils:146
  throw error;
  ^

AssertionError [ERR_ASSERTION]: The input did not match the regular expression /ReferenceError: x is not defined/. Input:

'> 3\n> '

    at testStrictMode (/home/targos/git/nodejs/v8-next-update/test/parallel/test-repl-mode.js:38:10)
    at /home/targos/git/nodejs/v8-next-update/test/parallel/test-repl-mode.js:18:3
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/targos/git/nodejs/v8-next-update/test/parallel/test-repl-mode.js:17:7)
    at Module._compile (node:internal/modules/cjs/loader:1811:14)
    at Object..js (node:internal/modules/cjs/loader:1951:10)
    at Module.load (node:internal/modules/cjs/loader:1532:32)
    at Module._load (node:internal/modules/cjs/loader:1334:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
    at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: '> 3\n> ',
  expected: /ReferenceError: x is not defined/,
  operator: 'match',
  diff: 'simple'
}

Node.js v26.0.0-pre
Command: out/Release/node /home/targos/git/nodejs/v8-next-update/test/parallel/test-repl-mode.js

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Feb 20, 2026

deps: update V8 to 14.4 #61002

Closed

deps: update V8 to 14.5 #61681

Closed

targos added the semver-major PRs that contain breaking changes and should be released in the next major version. label

Feb 20, 2026

targos force-pushed the v8-146 branch from 1e241d1 to 25c85aa Compare

February 20, 2026 11:10

targos commented Feb 20, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member Author

Additionally, snapshot is no longer reproducible:

Edit: not macOS-specific: https://github.com/nodejs/node/actions/runs/22221811293/job/64279253109

=== release test-snapshot-reproducible ===
Path: parallel/test-snapshot-reproducible
Error: --- stderr ---
node:internal/assert/utils:146
  throw error;
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
+ actual - expected
... Skipped lines

  [
    '#include <cstddef>',
    '#include "env.h"',
    '#include "node_snapshot_builder.h"',
    '#include "v8.h"',
...
    'namespace node {',
+   'static const char v8_snapshot_blob_data[] = {4,0,0,0,1,0,0,0,3,126,58,75,100,19,-88,-44,49,52,46,54,46,50,48,50,46,52,45,110,111,100,101,46,54,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,  // 0',
-   'static const char v8_snapshot_blob_data[] = {4,0,0,0,1,0,0,0,-72,125,-78,63,100,19,-88,-44,49,52,46,54,46,50,48,50,46,52,45,110,111,100,101,46,54,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,  // 0',
    '0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,32,-95,18,0,40,-48,24,0,104,-6,28,0,-48,-8,29,0,-24,-11,30,0,-48,-15,31,0,-88,6,-34,-64,-80,-96,18,0,-95,24,96,0,0,0,0,83,0,0,0,96,0,0,0,0,  // 1',
    '0,0,0,0,96,0,0,0,0,0,0,0,0,96,0,0,0,0,-61,1,0,0,96,0,0,0,0,60,0,0,0,96,0,0,0,0,-28,1,0,0,96,0,0,0,0,0,0,0,0,96,0,0,0,0,36,1,0,0,11,5,24,-30,-1,1,  // 2',
    '5,24,-94,0,2,5,24,98,1,2,5,24,34,2,2,5,24,-30,2,2,5,24,-94,3,2,5,24,98,4,2,5,24,34,5,2,5,24,-30,5,2,5,24,-94,6,2,5,24,98,7,2,5,24,34,8,2,5,24,-30,8,2,1,76,7,101,  // 3',
    '15,69,64,97,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,64,98,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,1,0,0,0,64,96,0,0,0,0,0,0,0,0,7,-123,2,64,96,0,0,0,  // 4',
    '0,8,0,0,0,-127,0,91,64,1,20,83,69,97,0,0,0,0,96,0,0,0,0,0,0,0,1,0,0,0,93,1,20,83,69,97,0,0,0,0,96,0,0,0,0,0,0,0,1,0,0,0,93,1,20,83,69,97,0,0,0,0,96,0,  // 5',
...
    '0,0,0,4,0,0,0,0,0,0,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,-124,0,7,33,10,1,28,-108,-128,27,31,16,5,24,-94,-65,2,6,77,31,4,-67,52,1,12,7,29,1,64,32,109,18,96,  // 34655',
+   '0,0,0,0,0,2,0,0,7,13,13,1,28,4,40,-128,27,31,20,5,24,-94,-65,2,6,81,31,-109,1,12,-108,64,32,113,18,96,0,0,0,0,0,1,0,0,91,96,0,0,0,0,-45,31,0,0,1,28,4,33,53,1,-128,-111,102,0,  // 34656',
-   '0,0,0,0,0,2,0,0,7,13,13,1,28,4,40,-128,27,31,20,5,24,-94,-65,2,6,81,31,-109,1,12,-108,64,32,113,18,96,0,0,0,0,0,1,0,0,91,96,0,0,0,0,-122,33,0,0,1,28,4,33,53,1,-128,-111,102,0,  // 34656',
    '0,0,0,30,0,0,0,0,0,0,0,3,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,8,0,0,0,0,0,0,0,4,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,-115,0,9,53,8,1,12,7,1,  // 34657',
    '15,1,28,-106,-128,27,32,4,6,5,1,1,40,4,92,96,0,0,0,0,8,0,0,0,6,9,1,4,100,1,28,-106,-128,27,31,8,5,24,-94,-65,2,6,85,31,-109,1,12,-108,64,32,117,18,9,-107,2,1,32,4,-124,-128,27,32,81,15,  // 34658',
    '6,-31,27,4,61,59,4,29,47,65,1,28,-106,-128,27,32,85,15,6,-27,27,-108,4,37,47,64,1,28,4,40,-128,27,32,89,15,6,-23,27,-108,4,45,47,4,49,47,66,96,0,0,0,0,1,3,0,0,71,7,117,16,96,0,0,0,0,  // 34659',
    '13,2,0,0,72,7,121,16,96,0,0,0,0,13,1,0,0,91,32,93,15,6,-19,27,-108,4,53,47,1,28,-105,-128,27,31,8,5,24,-94,-65,2,6,89,31,4,-67,52,1,12,7,29,1,64,32,121,18,1,32,4,-124,-128,27,31,20,5,  // 34660',
    '24,-94,-65,2,6,93,31,-107,1,12,-106,64,32,125,18,65,1,32,-105,-128,27,31,12,5,24,-94,-65,2,6,97,31,-107,1,12,-106,64,32,-127,18,65,1,32,-105,-128,27,31,16,5,24,-94,-65,2,6,101,31,-107,1,12,-106,64,32,-123,18,65,  // 34661',

    at Object.<anonymous> (/Users/runner/work/node/node/node/test/parallel/test-snapshot-reproducible.js:47:8)
    at Module._compile (node:internal/modules/cjs/loader:1811:14)
    at Object..js (node:internal/modules/cjs/loader:1951:10)
    at Module.load (node:internal/modules/cjs/loader:1532:32)
    at Module._load (node:internal/modules/cjs/loader:1334:12)
    at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
    at Module.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:154:5)
    at node:internal/main/run_main_module:33:47 {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: [
    '#include <cstddef>',
    '#include "env.h"',
    '#include "node_snapshot_builder.h"',
    '#include "v8.h"',
    '',
    '// This file is generated by tools/snapshot. Do not edit.',
    '',
    'namespace node {',
    'static const char v8_snapshot_blob_data[] = {4,0,0,0,1,0,0,0,3,126,58,75,100,19,-88

sxa reacted with confused emoji

All reactions

😕 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos added the help wanted Issues that need assistance from volunteers or PRs that need help to proceed. label

Feb 20, 2026

Renegade334 commented Feb 21, 2026

Copy link

Copy Markdown

Member

Note that this changeset does not compile with GCC <14.1, unless the following patch is applied:

diff --git a/deps/v8/src/objects/js-duration-format.cc b/deps/v8/src/objects/js-duration-format.cc
index 41bdbc2cc6..c9ef451713 100644
--- a/deps/v8/src/objects/js-duration-format.cc
+++ b/deps/v8/src/objects/js-duration-format.cc
@@ -807,7 +807,7 @@ void OutputFractional(const char* type, int64_t integer, int32_t powerOfTen,
   // Pass in the value as int64_t and ask ICU to scale down.
   nfOpts = nfOpts.scale(icu::number::Scale::powerOfTen(-powerOfTen));

-  int64_t factor = static_cast<int64_t>(std::powl(10, powerOfTen));
+  int64_t factor = static_cast<int64_t>(std::pow(10.0L, powerOfTen));
   int64_t bound = std::numeric_limits<int64_t>::max() / factor - 1;
   UErrorCode status = U_ZERO_ERROR;
   // Use faster ICU API formatInt if the value fit the precision int64_t,

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sxa commented Feb 22, 2026

Copy link

Copy Markdown

Member

Additionally, snapshot is no longer reproducible:

FYI @joyeecheung

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

sxa commented Feb 22, 2026

Copy link

Copy Markdown

Member

For what it's worth this branch seems to build ok with a RISC-V cross compiler too 👍🏻 (An experimental platform but I thought I'd mention it anyway ;-) )

Renegade334 and igk-flamingo reacted with laugh emoji

All reactions

😄 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos force-pushed the v8-146 branch from 25c85aa to c63c70d Compare

March 13, 2026 14:08

targos commented Mar 13, 2026

Copy link

Copy Markdown

Member Author

@nodejs/platform-windows Can you please have a look at the Windows build failure?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Mar 13, 2026

Copy link

Copy Markdown

Member Author

There's still this REPL strict mode issue: #61898 (comment)

@nodejs/repl

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Mar 13, 2026

Copy link

Copy Markdown

Member Author

And the reproducible snapshot: #61898 (comment)

@nodejs/startup (for lack of a more specific team)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Renegade334 commented Mar 13, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

There's still this REPL strict mode issue: #61898 (comment)

It's not so much a REPL issue as an issue with the VM global sandbox interceptors, introduced as a regression with 113b5cfbeb3dee1c81391d920e535cebe4792cc8. Previously, we were simulating CheckContextualStoreToJSGlobalObject-esque behaviour by rejecting interceptions on global proxy properties in strict mode if the receiver was not the global object. Now that we can no longer observe the receiver, that mechanism doesn't exist, and statements like nonExistantGlobalVariable = 42 are setting a property on the global sandbox instead of throwing in strict mode.

(We should probably have VM tests for this.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Renegade334 commented Mar 13, 2026

Copy link

Copy Markdown

Member

Note that this changeset does not compile with GCC <14.1, unless the following patch is applied:

diff --git a/deps/v8/src/objects/js-duration-format.cc b/deps/v8/src/objects/js-duration-format.cc
index 41bdbc2cc6..c9ef451713 100644
--- a/deps/v8/src/objects/js-duration-format.cc
+++ b/deps/v8/src/objects/js-duration-format.cc
@@ -807,7 +807,7 @@ void OutputFractional(const char* type, int64_t integer, int32_t powerOfTen,
   // Pass in the value as int64_t and ask ICU to scale down.
   nfOpts = nfOpts.scale(icu::number::Scale::powerOfTen(-powerOfTen));

-  int64_t factor = static_cast<int64_t>(std::powl(10, powerOfTen));
+  int64_t factor = static_cast<int64_t>(std::pow(10.0L, powerOfTen));
   int64_t bound = std::numeric_limits<int64_t>::max() / factor - 1;
   UErrorCode status = U_ZERO_ERROR;
   // Use faster ICU API formatInt if the value fit the precision int64_t,

We will either need to merge (or upstream) this, or change the GCC build requirement to >=14.1.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Mar 13, 2026

Copy link

Copy Markdown

Member Author

Would you like to try and upstream it?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Renegade334 commented Mar 13, 2026

Copy link

Copy Markdown

Member

It would be easier if someone with existing Chromium contributor status did the honours, I'd rather not jump through the hoops for a one-liner!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung commented Mar 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Locally this fixes the snapshot reproducibility test for me

See diff

diff --git a/deps/v8/src/builtins/builtins-proxy-gen.cc b/deps/v8/src/builtins/builtins-proxy-gen.cc
index 0bc45bac300..f0047f044f2 100644
--- a/deps/v8/src/builtins/builtins-proxy-gen.cc
+++ b/deps/v8/src/builtins/builtins-proxy-gen.cc
@@ -63,6 +63,10 @@ TNode<JSProxy> ProxiesCodeStubAssembler::AllocateProxy(
   StoreObjectFieldNoWriteBarrier(proxy, JSProxy::kTargetOffset, target);
   StoreObjectFieldNoWriteBarrier(proxy, JSProxy::kHandlerOffset, handler);
   StoreObjectFieldNoWriteBarrier(proxy, JSProxy::kFlagsOffset, flags);
+#if TAGGED_SIZE_8_BYTES
+  StoreObjectFieldNoWriteBarrier(proxy, JSProxy::kPaddingOffset,
+                                 Int32Constant(0));
+#endif
 
   return CAST(proxy);
 }
diff --git a/deps/v8/src/heap/factory.cc b/deps/v8/src/heap/factory.cc
index b6f6938450c..e0117df19f9 100644
--- a/deps/v8/src/heap/factory.cc
+++ b/deps/v8/src/heap/factory.cc
@@ -3945,6 +3945,9 @@ Handle<JSProxy> Factory::NewJSProxy(DirectHandle<JSReceiver> target,
   result->set_target(*target, SKIP_WRITE_BARRIER);
   result->set_handler(*handler, SKIP_WRITE_BARRIER);
   result->set_flags(JSProxy::IsRevocableBit::encode(revocable));
+#if TAGGED_SIZE_8_BYTES
+  result->set_padding(0);
+#endif
   return handle(result, isolate());
 }

Uploaded https://chromium-review.googlesource.com/c/v8/v8/+/7666243

targos reacted with heart emoji

All reactions

❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung commented Mar 14, 2026

Copy link

Copy Markdown

Member

It would be easier if someone with existing Chromium contributor status did the honours, I'd rather not jump through the hoops for a one-liner!

Also uploaded https://chromium-review.googlesource.com/c/v8/v8/+/7666244 (IIUC, it was a libstdc++ issue fixed by https://gcc.gnu.org/pipermail/libstdc++/2023-February/055493.html)

Renegade334 and targos reacted with heart emoji

All reactions

❤️ 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StefanStojanovic commented Mar 16, 2026

Copy link

Copy Markdown

Contributor

@nodejs/platform-windows Can you please have a look at the Windows build failure?

I'll take a look. Thanks for the ping.

targos reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

StefanStojanovic commented Mar 16, 2026

Copy link

Copy Markdown

Contributor

@nodejs/platform-windows Can you please have a look at the Windows build failure?

Will look into it. Thanks for the ping.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

hubot pushed a commit to v8/v8 that referenced this pull request

Mar 16, 2026


          Zero-initialize proxy padding

edeb0a4

So that snapshots with proxies can be reproducible.

Refs: nodejs/node#61898
Change-Id: I01fac5e18c73cd482a1ae63750dbadf42a12e08a
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7666243
Reviewed-by: Jakob Kummerow <[email protected]>
Commit-Queue: Joyee Cheung <[email protected]>
Cr-Commit-Position: refs/heads/main@{#105830}

StefanStojanovic commented Mar 17, 2026

Copy link

Copy Markdown

Contributor

@targos, here is the patch to enable building on Windows: v8-146-fix.patch. Two small changes were needed.

targos reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

targos commented Mar 17, 2026

Copy link

Copy Markdown

Member Author

Thanks @StefanStojanovic and @joyeecheung. I pushed your fixes. Let's see how it goes on GH runners.

StefanStojanovic reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Apr 24, 2026

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7144/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Apr 24, 2026

Copy link

Copy Markdown

Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7144/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot commented Apr 24, 2026

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72900/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

panva approved these changes

Apr 24, 2026

View reviewed changes

targos added a commit that referenced this pull request

Apr 24, 2026


          deps: update V8 to 14.6.202.33

f1e0b83

PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos added a commit that referenced this pull request

Apr 24, 2026


          build: reset embedder string to "-node.0"

72bc9b4

PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos added a commit that referenced this pull request

Apr 24, 2026


          src: update NODE_MODULE_VERSION to 147

34408ae

Major V8 updates are usually API/ABI incompatible with previous
versions. This commit adapts NODE_MODULE_VERSION for V8 14.6.

Refs: https://github.com/nodejs/CTC/blob/master/meetings/2016-09-28.md
PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos added a commit that referenced this pull request

Apr 24, 2026


          deps: patch V8 to avoid duplicated zlib symbol

b6a9674

PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos pushed a commit that referenced this pull request

Apr 24, 2026


          deps: define V8_PRESERVE_MOST as no-op on Windows

add506a

It's causing linker errors with node.lib in node-gyp and potentially
breaks other 3rd party tools

Refs: #55784
PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos added a commit that referenced this pull request

Apr 24, 2026


          deps: remove problematic comment from v8-internal

232fc89

GCC emits warnings because of the trailing backslashes.

PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos pushed a commit that referenced this pull request

Apr 24, 2026


          deps: patch V8 for illumos

593bb51

illumos pointers are VA48, can allocate from the top of the 64-bit range
as well.

PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos pushed a commit that referenced this pull request

Apr 24, 2026


          deps: support madvise(3C) across ALL illumos revisions

2bae6ac

In illumos, madvise(3C) now takes `void *` for its first argument
post-illumos#14418, but uses `caddr_t` pre-illumos#14418. This fix will
detect if the illumos mman.h file in use is pre-or-post-illumos#14418 so
builds can work either way.

PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos pushed a commit that referenced this pull request

Apr 24, 2026


          deps: V8: cherry-pick highway@989a498fdf3

4ec8aa0

Original commit message:

    GCC 15 removed avx10.2-512 target

    PiperOrigin-RevId: 823560321

Refs: google/highway@989a498
Fixes: #60566
PR-URL: #61898
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
Reviewed-By: Chengzhong Wu <[email protected]>

targos commented Apr 24, 2026

Copy link

Copy Markdown

Member Author

Landed in 9c4ca0a...fcff458

shrujalshah28, richardlau, SuperchupuDev, legendecas, riya-amemiya, bricss, robpalme, BethGriggs, gameroman, IlyasShabi, and 12 more reacted with hooray emoji

ctcpip, rektide, justingrant, azrdn, Renegade334, and lin72h reacted with rocket emoji

All reactions

🎉 22 reactions
🚀 6 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

legendecas mentioned this pull request

Apr 24, 2026

src: remove outdated comments in contextify #62932

Merged

gameroman mentioned this pull request

Apr 24, 2026

Temporal support (TC39 stage 3 proposal) oven-sh/bun#15853

Closed

IlyasShabi mentioned this pull request

Apr 30, 2026

parallel.test-process-finalization is flaky #63056

Closed

Xstoudi mentioned this pull request

Apr 30, 2026

Use Temporal for time stamps eemeli/yaml#668

Open

aduh95 mentioned this pull request

May 5, 2026

2026-05-07, Version 26.1.0 #63137

Merged

legendecas mentioned this pull request

Jun 6, 2026

V8 deprecates passing receiver to interceptor callbacks #60616

Closed

This was referenced Jul 27, 2026

chore(mise): upgrade local tools jylenhof/mise-update-tool#18

Closed

chore(mise): upgrade local tools jylenhof/mise-update-tool#23

Closed

ghappforreleaseplease Bot mentioned this pull request

Aug 10, 2026

chore(mise): upgrade local tools jylenhof/mise-update-tool#28

Closed

aduh95 mentioned this pull request

Aug 19, 2026

src: remove --harmony-import-attributes #65396

Merged

caugner mentioned this pull request

Sep 15, 2026

Node.js 26 adds WebAssembly.Memory buffer methods mdn/browser-compat-data#30541

Merged

richardlau mentioned this pull request

Sep 18, 2026

Revert "deps: V8: override depot_tools version" #66110

Merged

This was referenced Oct 7, 2026

wpt/test-wasm-jsapi sometimes crashes on AIX #62647

Open

[v24.x] deps: V8: cherry-pick ea9c016f26ad #66570

Closed

mikinovation mentioned this pull request

Nov 1, 2026

chore(deps): update dependency node to v26 mikinovation/mikinovation#445

Merged

1 task

github-actions Bot mentioned this pull request

Nov 2, 2026

Update dependency node to v26 claytono/infra#3367

Merged

1 task

Reviewers

panva

panva approved these changes

legendecas

legendecas approved these changes

aduh95

aduh95 approved these changes

RafaelGSS

RafaelGSS approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

build

Issues and PRs related to Node.js builds or CI infrastructure.

needs-ci

PRs that need a full CI run.

semver-major

PRs that contain breaking changes and should be released in the next major version.

v8 engine

Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

V8 deprecates passing receiver to interceptor callbacks

Uh oh!

There was an error while loading. Please reload this page.

19 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

targos commented Feb 20, 2026

Uh oh!

nodejs-github-bot commented Feb 20, 2026

Uh oh!

targos commented Feb 20, 2026

Uh oh!

targos commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Renegade334 commented Feb 21, 2026

Uh oh!

sxa commented Feb 22, 2026

Uh oh!

sxa commented Feb 22, 2026

Uh oh!

targos commented Mar 13, 2026

Uh oh!

targos commented Mar 13, 2026

Uh oh!

targos commented Mar 13, 2026

Uh oh!

Renegade334 commented Mar 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Renegade334 commented Mar 13, 2026

Uh oh!

targos commented Mar 13, 2026

Uh oh!

Renegade334 commented Mar 13, 2026

Uh oh!

joyeecheung commented Mar 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joyeecheung commented Mar 14, 2026

Uh oh!

StefanStojanovic commented Mar 16, 2026

Uh oh!

StefanStojanovic commented Mar 16, 2026

Uh oh!

StefanStojanovic commented Mar 17, 2026

Uh oh!

targos commented Mar 17, 2026

Uh oh!

nodejs-github-bot commented Apr 24, 2026

Uh oh!

nodejs-github-bot commented Apr 24, 2026

Uh oh!

nodejs-github-bot commented Apr 24, 2026

Uh oh!

targos commented Apr 24, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

19 participants

targos commented Feb 20, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

Renegade334 commented Mar 13, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.

joyeecheung commented Mar 14, 2026 •

edited

Loading

Uh oh!

There was an error while loading. Please reload this page.