GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — sqlite: bind Boolean by mike-git374 · Pull Request #62001 · nodejs/node

Conversation

mike-git374 commented Feb 26, 2026

Copy link

Copy Markdown

Contributor

Fixes: #57862

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

thisalihassan and jlarmstrongiv reacted with heart emoji

thisalihassan and jlarmstrongiv reacted with rocket emoji

All reactions

❤️ 2 reactions
🚀 2 reactions


          sqlite: bind Boolean

2d62a37

nodejs-github-bot commented Feb 26, 2026

Copy link

Copy Markdown

Collaborator

Review requested:

@nodejs/sqlite

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

nodejs-github-bot added c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

sqlite Issues and PRs related to the SQLite subsystem. labels

Feb 26, 2026


          Simplify

ecd3d0c

louwers reviewed

Feb 26, 2026

View reviewed changes

Comment thread

src/node_sqlite.cc Resolved

Uh oh!

There was an error while loading. Please reload this page.

mike-git374 added 3 commits

February 26, 2026 07:03


          Update comment

7e8f43d


          comment update

881fb94

Reword comments for clarity regarding JS types and SQLite.


          test consolidate

ac38ba9

mike-git374 mentioned this pull request

Feb 27, 2026

sqlite: inconsistent undefined bind to null #61824

Closed

mike-git374 added 2 commits

February 27, 2026 15:15


          test break line

4d8fcc6


          test break line

dc18b64

thisalihassan reviewed

Mar 6, 2026

View reviewed changes

thisalihassan left a comment

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

himself65 approved these changes

Mar 6, 2026

View reviewed changes

trivikr added request-ci

Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review.

author ready PRs with CI started, the required approvals, and no outstanding review comments. labels

Jul 25, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label

Jul 26, 2026

This comment was marked as outdated.

mike-git374 mentioned this pull request

Aug 4, 2026

SQLite bind booleans #57862

Closed

TrevorBurnham mentioned this pull request

Aug 4, 2026

stabilization of node:sqlite module #57445

Open

This comment was marked as outdated.

nodejs-github-bot commented Aug 6, 2026

Copy link

Copy Markdown

Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75552/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

trivikr pushed a commit that referenced this pull request

Aug 6, 2026


          sqlite: bind Boolean

de333e8

PR-URL: #62001
Fixes: #57862
Reviewed-By: Zeyu "Alex" Yang <[email protected]>

trivikr commented Aug 6, 2026

Copy link

Copy Markdown

Member

Landed in de333e8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

trivikr closed this

Aug 6, 2026

araujogui mentioned this pull request

Aug 6, 2026

doc: document sqlite parameter binding #65089

Merged

nodejs-github-bot pushed a commit that referenced this pull request

Aug 8, 2026


          doc: document sqlite parameter binding

114e356

Signed-off-by: Guilherme Araújo <[email protected]>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 13, 2026


          sqlite: bind Boolean

4aa40e7

PR-URL: #62001
Fixes: #57862
Reviewed-By: Zeyu "Alex" Yang <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 13, 2026


          doc: document sqlite parameter binding

67829bb

Signed-off-by: Guilherme Araújo <[email protected]>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 25, 2026


          sqlite: bind Boolean

49fb028

PR-URL: #62001
Fixes: #57862
Reviewed-By: Zeyu "Alex" Yang <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 25, 2026


          doc: document sqlite parameter binding

e52e573

Signed-off-by: Guilherme Araújo <[email protected]>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

github-actions Bot mentioned this pull request

Aug 25, 2026

2026-08-26, Version 26.8.0 (Current) #65551

Merged

aduh95 pushed a commit that referenced this pull request

Aug 27, 2026


          sqlite: bind Boolean

c154225

PR-URL: #62001
Fixes: #57862
Reviewed-By: Zeyu "Alex" Yang <[email protected]>

aduh95 pushed a commit that referenced this pull request

Aug 27, 2026


          doc: document sqlite parameter binding

b7932e6

Signed-off-by: Guilherme Araújo <[email protected]>
PR-URL: #65089
Refs: #62001
Refs: #62061
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Trivikram Kamat <[email protected]>

github-actions Bot mentioned this pull request

Sep 7, 2026

2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873

Merged

coderabbitai Bot mentioned this pull request

Sep 21, 2026

Round 10: real value from history — scores, forecast, money in vs out, restore paging, savings rollover henzard/AccountingV2#148

Merged

This was referenced Oct 7, 2026

[Bug]: Pairing fails with HTTP 500 since #10298 because the consume query binds a boolean pingdotgg/t3code#16797

Closed

fix(server): pairing links no longer fail with HTTP 500 pingdotgg/t3code#16799

Closed

robobun mentioned this pull request

Oct 17, 2026

node:sqlite: bind an ArrayBuffer or a SharedArrayBuffer as a BLOB oven-sh/bun#45646

Open

Reviewers

himself65

himself65 approved these changes

+2 more reviewers

louwers

louwers left review comments

thisalihassan

thisalihassan left review comments

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready

PRs with CI started, the required approvals, and no outstanding review comments.

c++

Issues and PRs that require attention from people who are familiar with C++.

needs-ci

PRs that need a full CI run.

sqlite

Issues and PRs related to the SQLite subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

SQLite bind booleans

Uh oh!

There was an error while loading. Please reload this page.

6 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.