GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — test_runner: avoid reading process state directly in run() by murataslan1 · Pull Request #62377 · nodejs/node

test_runner: avoid reading process state directly in run() #62377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open

murataslan1 wants to merge 3 commits into nodejs:main

base: main

from murataslan1:fix/test-runner-process-state

Uh oh!

There was an error while loading. Please reload this page.

Open

test_runner: avoid reading process state directly in run() #62377

Changes from 1 commit

Commits

Show all changes

3 commits

Select commit Hold shift + click to select a range

e1746a9

test_runner: avoid reading process state directly in run()

murataslan1 Mar 21, 2026

acf2faa

test_runner: address review feedback

murataslan1 Mar 22, 2026

37fc25a

test_runner: validate globPatterns as string array

murataslan1 Apr 1, 2026

File filter

Filter by extension .js (1) All 1 file type selected

Viewed files

Clear filters

Conversations

Failed to load comments.

Uh oh!

There was an error while loading. Please reload this page.

Jump to

Jump to file

Failed to load files.

Uh oh!

There was an error while loading. Please reload this page.

Diff view

Unified

Split

Hide whitespace

Diff view

Unified

Split

Hide whitespace

Previous commit

test_runner: validate globPatterns as string array

Loading branch information

Uh oh!

There was an error while loading. Please reload this page.

murataslan1 committed Apr 1, 2026

commit 37fc25a903a0351b2edd1567a0c58aaf3e601575

Some comments aren't visible on the classic Files Changed page.

There are no files selected for viewing

2 changes: 1 addition & 1 deletion 2 lib/internal/test_runner/runner.js

Show comments

View file

Open in desktop

Original file line number	Diff line number	Diff line change
Expand Up		@@ -686,7 +686,7 @@ function run(options = kEmptyObject) {
		validateBoolean(only, 'options.only');
		}
		if (globPatterns != null) {
		validateArray(globPatterns, 'options.globPatterns');
		validateStringArray(globPatterns, 'options.globPatterns');
		}

		validateString(cwd, 'options.cwd');
Expand Down

Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.