GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: use upstream version of OpenSSL in `test-shared` by aduh95 · Pull Request #62679 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

With 25.x in maintenance mode, there's no reason to keep pinning the version of OpenSSL, we can use the version maintained in nixpkgs like we do for other deps.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Apr 10, 2026
panva
panva approved these changes Apr 10, 2026
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Apr 10, 2026
@aduh95
tools: use upstream version of OpenSSL in test-shared
7f45cc2 
Signed-off-by: Antoine du Hamel <[email protected]>
@aduh95
aduh95 force-pushed the upstream-openssl-nixpkgs branch from 15d3f28 to 7f45cc2 Compare April 15, 2026 09:23
panva
panva approved these changes Apr 15, 2026
View reviewed changes
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 18, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 18, 2026
@nodejs-github-bot
nodejs-github-bot merged commit aacf750 into nodejs:main Apr 18, 2026
26 of 27 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 18, 2026

Copy link
Copy Markdown
Collaborator

Landed in aacf750
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
aduh95 added a commit that referenced this pull request May 5, 2026
@aduh95
tools: use upstream version of OpenSSL in test-shared
1eedbdd 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #62679
Reviewed-By: Filip Skokan <[email protected]>
@aduh95 aduh95 mentioned this pull request May 5, 2026
2026-05-07, Version 26.1.0 #63137
Merged
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x labels May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@aduh95 @nodejs-github-bot @panva
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.