GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: simplify and fix FFI ArrayBuffer accesses by addaleax · Pull Request #62857 · nodejs/node

Conversation

@addaleax

@addaleax addaleax commented Apr 20, 2026

Copy link
Copy Markdown
Member

ArrayBufferViewContents supports ArrayBuffers, so we do not need to provide special treatment for those.

Also, small typed arrays may not have backing stores until their corresponding ArrayBuffers are accessed, so do that in order to avoid accidentally accessing arbitrary stack memory.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@addaleax
src: simplify and fix FFI ArrayBuffer accesses
147fc50 
`ArrayBufferViewContents` supports `ArrayBuffer`s, so we do not
need to provide special treatment for those.

Also, small typed arrays may not have backing stores until their
corresponding `ArrayBuffer`s are accessed, so do that in order
to avoid accidentally accessing arbitrary stack memory.

Signed-off-by: Anna Henningsen <[email protected]>
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 20, 2026
@addaleax addaleax added the ffi Issues and PRs related to experimental Foreign Function Interface support. label Apr 20, 2026
@addaleax
fixup! src: simplify and fix FFI ArrayBuffer accesses
b6651d8
@codecov

codecov Bot commented Apr 20, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.00000% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.62%. Comparing base (e02087c) to head (b6651d8).
⚠️ Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/ffi/data.cc 65.00% 2 Missing and 5 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62857      +/-   ##
==========================================
- Coverage   89.64%   89.62%   -0.03%     
==========================================
  Files         706      706              
  Lines      219137   219124      -13     
  Branches    41999    41981      -18     
==========================================
- Hits       196453   196386      -67     
- Misses      14574    14619      +45     
- Partials     8110     8119       +9
Files with missing lines Coverage Δ
src/ffi/data.cc 73.63% <65.00%> (+0.34%) ⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax
addaleax requested a review from ShogunPanda April 20, 2026 21:50
ShogunPanda
ShogunPanda approved these changes Apr 21, 2026
View reviewed changes
@addaleax addaleax added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Apr 21, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Apr 21, 2026
@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72812/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daeyeon
daeyeon approved these changes Apr 21, 2026
View reviewed changes
@nodejs-github-bot

nodejs-github-bot commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/72814/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@addaleax addaleax added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels Apr 21, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Apr 22, 2026
@nodejs-github-bot
nodejs-github-bot merged commit c69c6f1 into nodejs:main Apr 22, 2026
79 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Apr 22, 2026

Copy link
Copy Markdown
Collaborator

Landed in c69c6f1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot mentioned this pull request Apr 22, 2026
[Vulnerability] nodejs/node: Out-of-bounds Memory Read / Stack Memory Information disclosure spaceraccoon/vulnerability-spoiler-alert#131
Open
aduh95 pushed a commit that referenced this pull request May 5, 2026
@addaleax @aduh95
src: simplify and fix FFI ArrayBuffer accesses
faaccfb 
`ArrayBufferViewContents` supports `ArrayBuffer`s, so we do not
need to provide special treatment for those.

Also, small typed arrays may not have backing stores until their
corresponding `ArrayBuffer`s are accessed, so do that in order
to avoid accidentally accessing arbitrary stack memory.

Signed-off-by: Anna Henningsen <[email protected]>
PR-URL: #62857
Reviewed-By: Paolo Insogna <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
@aduh95 aduh95 mentioned this pull request May 5, 2026
2026-05-07, Version 26.1.0 #63137
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes
@daeyeon daeyeon daeyeon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. ffi Issues and PRs related to experimental Foreign Function Interface support. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@addaleax @nodejs-github-bot @ShogunPanda @daeyeon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.