GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: add tests for console.assert by evanlucas · Pull Request #6302 · nodejs/node

Conversation

@evanlucas

@evanlucas evanlucas commented Apr 20, 2016 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
Checklist
  • tests and code linting passes
  • a test and/or benchmark is included
  • the commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

There were previously no tests where console.assert failed

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@evanlucas
test: add tests for console.assert
268a3bc 
There were previously no tests where console.assert failed
@evanlucas evanlucas added test Issues and PRs related to Node.js core tests and test infrastructure. console Issues and PRs related to the console subsystem. labels Apr 20, 2016
@evanlucas

evanlucas commented Apr 20, 2016

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/2338/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@santigimeno

santigimeno commented Apr 20, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
3 similar comments
@cjihrig

cjihrig commented Apr 20, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mscdex

mscdex commented Apr 20, 2016

Copy link
Copy Markdown
Contributor

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Trott

Trott commented Apr 20, 2016

Copy link
Copy Markdown
Member

LGTM
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell pushed a commit that referenced this pull request Apr 22, 2016
@evanlucas @jasnell
test: add tests for console.assert
84ebf2b 
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@jasnell

jasnell commented Apr 22, 2016

Copy link
Copy Markdown
Member

Landed in 84ebf2b
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this Apr 22, 2016
@jasnell jasnell added the lts-watch-v4.x label Apr 22, 2016
@evanlucas

evanlucas commented Apr 25, 2016

Copy link
Copy Markdown
Contributor Author

Thanks @jasnell!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@evanlucas
evanlucas deleted the addconsoleasserttests branch April 25, 2016 01:47
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@evanlucas @joelostrowski
test: add tests for console.assert
89d75cb 
There were previously no tests where console.assert failed

PR-URL: nodejs#6302
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@evanlucas @jasnell
test: add tests for console.assert
591ebe7 
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels May 18, 2016
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@evanlucas Myles Borins
test: add tests for console.assert
fb44f5c 
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@evanlucas Myles Borins
test: add tests for console.assert
06e5faf 
There were previously no tests where console.assert failed

PR-URL: #6302
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Brian White <[email protected]>
Reviewed-By: Rich Trott <[email protected]>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
v4.4.5 proposal #6824
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

console Issues and PRs related to the console subsystem. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@evanlucas @santigimeno @cjihrig @mscdex @Trott @jasnell @MylesBorins
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.