GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — fs: cancel in-flight stat on abort by mertcanaltin · Pull Request #63142 · nodejs/node

Conversation

@mertcanaltin

@mertcanaltin mertcanaltin commented May 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The AbortError behavior was landed in main with #63143, leaving only the uv_cancel call that actually dropped the request from the threadpool queue in this PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Nokel81 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@mertcanaltin mertcanaltin mentioned this pull request May 6, 2026
fs: extend signal option to lstat, fstat and promises API #63143
Merged
@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. labels May 6, 2026
@mertcanaltin
mertcanaltin force-pushed the mert/fs-stat-inflight-fix branch from 4425502 to e4d317e Compare May 6, 2026 05:18
@mertcanaltin mertcanaltin mentioned this pull request May 6, 2026
fs: add signal option to fs.stat() #57775
Merged
@bakkot

bakkot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Drive-by: this looks like it's still not actually canceling the underlying call, which would involve invoking uv_cancel somewhere.
mertcanaltin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin
mertcanaltin force-pushed the mert/fs-stat-inflight-fix branch from e4d317e to 8149c79 Compare May 7, 2026 19:42
@codecov

codecov Bot commented May 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 90.06%. Comparing base (46a7dbd) to head (e404ca2).
⚠️ Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
src/node_file.cc 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63142      +/-   ##
==========================================
- Coverage   90.21%   90.06%   -0.16%     
==========================================
  Files         751      751              
  Lines      253550   254427     +877     
  Branches    47813    47973     +160     
==========================================
+ Hits       228733   229140     +407     
- Misses      16076    16486     +410     
- Partials     8741     8801      +60
Files with missing lines Coverage Δ
lib/fs.js 98.43% <100.00%> (-0.01%) ⬇️
src/node_file.cc 74.15% <83.33%> (+0.01%) ⬆️

... and 68 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin
mertcanaltin force-pushed the mert/fs-stat-inflight-fix branch 2 times, most recently from fc73958 to 6d3d629 Compare May 8, 2026 20:30
@mertcanaltin

mertcanaltin commented May 8, 2026

Copy link
Copy Markdown
Member Author

Thanks for review @bakkot I added a new binding function for cancel
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr

trivikr commented Jul 16, 2026

Copy link
Copy Markdown
Member

cc @nodejs/fs
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr trivikr mentioned this pull request Jul 16, 2026
Support providing AbortSignal to the fs.stat functions #57751
Open
@mertcanaltin

mertcanaltin commented Aug 13, 2026

Copy link
Copy Markdown
Member Author

@Renegade334, could you review this pr?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell
jasnell approved these changes Aug 15, 2026
View reviewed changes
@mertcanaltin
mertcanaltin force-pushed the mert/fs-stat-inflight-fix branch from 6d3d629 to 4913c16 Compare August 20, 2026 10:26
@MikeMcC399 MikeMcC399 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 20, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 20, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@MikeMcC399 MikeMcC399 added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 22, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 22, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76286/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin

mertcanaltin commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

I measuring uv_cancel.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr

trivikr commented Aug 24, 2026

Copy link
Copy Markdown
Member

@mertcanaltin Merge commits don't work with Node.js tooling. Can you please rebase?
mertcanaltin reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin
mertcanaltin force-pushed the mert/fs-stat-inflight-fix branch from 4eb1ce8 to 2d21670 Compare August 24, 2026 14:25
@mertcanaltin

mertcanaltin commented Aug 24, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Thanks @trivikr, I've rebased now and measured.

UV_THREADPOOL_SIZE=1, pool blocked by a pbkdf2 job, all 10,000 stadiums that were aborted while the pool was clogged are actually cancelled.

executed canceled settled
without cancel 10000 0 528 ms
with cancel 0 10000 14 ms
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin mertcanaltin changed the title fs: abort in-flight stat operations fs: cancel in-flight stat on abort Aug 24, 2026
@MikeMcC399 MikeMcC399 removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 25, 2026
@MikeMcC399

This comment was marked as outdated.

Sign in to view
atlowChemi
atlowChemi approved these changes Aug 26, 2026
View reviewed changes

@atlowChemi atlowChemi left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be some new test ensuring this works?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mertcanaltin
mertcanaltin force-pushed the mert/fs-stat-inflight-fix branch from 2d21670 to 2a3e1e5 Compare August 26, 2026 05:47
@mertcanaltin

mertcanaltin commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Should there be some new test ensuring this works?

Thanks, added.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin
mertcanaltin force-pushed the mert/fs-stat-inflight-fix branch from 2a3e1e5 to 6e2fc83 Compare August 26, 2026 06:52
gurgunday
gurgunday approved these changes Aug 26, 2026
View reviewed changes

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@MikeMcC399 MikeMcC399 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 26, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 26, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
atlowChemi
atlowChemi reviewed Aug 26, 2026
View reviewed changes
Comment thread test/parallel/test-fs-stat-cancel-inflight.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread test/parallel/test-fs-stat-cancel-inflight.js Resolved

Uh oh!

There was an error while loading. Please reload this page.
@mertcanaltin
fs: cancel in-flight stat on abort
e404ca2 
Signed-off-by: Mert Can Altin <[email protected]>
@mertcanaltin
mertcanaltin force-pushed the mert/fs-stat-inflight-fix branch from 6e2fc83 to e404ca2 Compare August 26, 2026 13:24
atlowChemi
atlowChemi approved these changes Aug 26, 2026
View reviewed changes
@trivikr trivikr added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 27, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 27, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76616/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@trivikr trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 28, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 2cb8064 into nodejs:main Aug 28, 2026
90 of 93 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Landed in 2cb8064
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 28, 2026
aduh95 pushed a commit that referenced this pull request Aug 29, 2026
@mertcanaltin @aduh95
fs: cancel in-flight stat on abort
8220c19 
Signed-off-by: Mert Can Altin <[email protected]>
PR-URL: #63142
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 3, 2026
@mertcanaltin @aduh95
fs: cancel in-flight stat on abort
1918001 
Signed-off-by: Mert Can Altin <[email protected]>
PR-URL: #63142
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Version 26.9.0 (Current) #65881
Merged
aduh95 pushed a commit that referenced this pull request Sep 15, 2026
@mertcanaltin @aduh95
fs: cancel in-flight stat on abort
ea372bf 
Signed-off-by: Mert Can Altin <[email protected]>
PR-URL: #63142
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Gürgün Dayıoğlu <[email protected]>
@robobun robobun mentioned this pull request Oct 29, 2026
node:fs: honor options.signal in the async stat family oven-sh/bun#47310
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes
@gurgunday gurgunday gurgunday approved these changes
@jasnell jasnell Awaiting requested review from jasnell

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@mertcanaltin @bakkot @trivikr @nodejs-github-bot @MikeMcC399 @jasnell @atlowChemi @gurgunday
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.