GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — quic: ignore coverage for quic files by jasnell · Pull Request #63149 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented May 6, 2026

Copy link
Copy Markdown
Member

Since they aren't built by default

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot

nodejs-github-bot commented May 6, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/quic
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation. labels May 6, 2026
@jasnell jasnell mentioned this pull request May 6, 2026
Revert "quic: complete the internal implementation of QUIC" #63148
Closed
@jasnell
jasnell requested a review from aduh95 May 6, 2026 11:29
@jasnell
quic: ignore coverage for quic files
3d65005 
Since they aren't built by default

Signed-off-by: James M Snell <[email protected]>
@jasnell
jasnell force-pushed the jasnell/ignore-quic-coverage branch from 1f7a03e to 3d65005 Compare May 6, 2026 11:30
@jasnell jasnell added the fast-track PRs proposed for a shorter-than-standard waiting period before landing. label May 6, 2026
@github-actions

github-actions Bot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.
mcollina, panva, and pimterry reacted with thumbs up emoji
All reactions
  • 👍 3 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell
jasnell requested a review from mcollina May 6, 2026 11:31
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@jasnell jasnell mentioned this pull request May 6, 2026
quic: complete the QUIC/HTTP3 implementation #62876
Closed
mcollina
mcollina approved these changes May 6, 2026
View reviewed changes

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
panva
panva approved these changes May 6, 2026
View reviewed changes
MoLow
MoLow approved these changes May 6, 2026
View reviewed changes
pimterry
pimterry approved these changes May 6, 2026
View reviewed changes
aymen94
aymen94 approved these changes May 6, 2026
View reviewed changes
@codecov

codecov Bot commented May 6, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.06%. Comparing base (e80b5d2) to head (3d65005).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63149      +/-   ##
==========================================
+ Coverage   89.66%   90.06%   +0.39%     
==========================================
  Files         713      713              
  Lines      224076   224257     +181     
  Branches    42308    42396      +88     
==========================================
+ Hits       200912   201970    +1058     
+ Misses      14996    14099     -897     
- Partials     8168     8188      +20
Files with missing lines Coverage Δ
lib/internal/quic/diagnostics.js 100.00% <100.00%> (ø)
lib/internal/quic/state.js 100.00% <100.00%> (+48.39%) ⬆️
lib/internal/quic/stats.js 100.00% <100.00%> (+45.36%) ⬆️
lib/internal/quic/symbols.js 100.00% <100.00%> (ø)

... and 63 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 6, 2026
@jasnell

jasnell commented May 6, 2026

Copy link
Copy Markdown
Member Author

fedora build agents on jenkins are moving painfully slowly today because apparently the ccache was cleared. 3+ hrs and counting and it's not even yet completely done with the v8 part of the build. Once that finally does finish, and once I'm able to resume to clear up the one flaky failure that's there, I'll be able to get this landed.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented May 6, 2026 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73209/ 💛
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jasnell added a commit that referenced this pull request May 6, 2026
@jasnell
quic: ignore coverage for quic files
3c2d2e3 
Since they aren't built by default

Signed-off-by: James M Snell <[email protected]>
PR-URL: #63149
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
@jasnell

jasnell commented May 6, 2026

Copy link
Copy Markdown
Member Author

Landed in 3c2d2e3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell closed this May 6, 2026
aduh95 pushed a commit that referenced this pull request May 19, 2026
@jasnell @aduh95
quic: ignore coverage for quic files
3852884 
Since they aren't built by default

Signed-off-by: James M Snell <[email protected]>
PR-URL: #63149
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
aduh95 pushed a commit that referenced this pull request May 19, 2026
@jasnell @aduh95
quic: ignore coverage for quic files
83f0d37 
Since they aren't built by default

Signed-off-by: James M Snell <[email protected]>
PR-URL: #63149
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
@github-actions github-actions Bot mentioned this pull request May 19, 2026
2026-05-20, Version 26.2.0 (Current) #63440
Merged
@aduh95 aduh95 mentioned this pull request Jul 22, 2026
[v24.x backport] node:stream/iter and QUIC backports #64675
Closed
aduh95 pushed a commit to aduh95/node that referenced this pull request Jul 30, 2026
@jasnell @aduh95
quic: ignore coverage for quic files
d71880a 
Since they aren't built by default

Signed-off-by: James M Snell <[email protected]>
PR-URL: nodejs#63149
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
aduh95 pushed a commit to aduh95/node that referenced this pull request Aug 3, 2026
@jasnell @aduh95
quic: ignore coverage for quic files
ada938d 
Since they aren't built by default

Signed-off-by: James M Snell <[email protected]>
PR-URL: nodejs#63149
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 6, 2026
@jasnell @aduh95
quic: ignore coverage for quic files
bea62a1 
Since they aren't built by default

Signed-off-by: James M Snell <[email protected]>
PR-URL: #63149
Backport-PR-URL: #64675
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Tim Perry <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 21, 2026
2026-08-26, Version 24.20.0 'Krypton' (LTS) #65461
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes
@panva panva panva approved these changes
@pimterry pimterry pimterry approved these changes
@MoLow MoLow MoLow approved these changes
@aduh95 aduh95 Awaiting requested review from aduh95
+1 more reviewer
@aymen94 aymen94 aymen94 approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. fast-track PRs proposed for a shorter-than-standard waiting period before landing. needs-ci PRs that need a full CI run. quic Issues and PRs related to the QUIC transport implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@jasnell @nodejs-github-bot @mcollina @panva @pimterry @MoLow @aymen94
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.