GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — crypto: enable ML-DSA, ML-KEM, AES-KW, and ChaCha20-Poly1305 on BoringSSL by panva · Pull Request #63255 · nodejs/node

Conversation

@panva

@panva panva commented May 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This PR wires up the following when using BoringSSL:

  • AES-KW in Web Cryptography
  • ChaCha20-Poly1305 in Web Cryptography experimental Issues and PRs related to experimental features.
  • ML-DSA and ML-KEM in Web Cryptography experimental Issues and PRs related to experimental features.
  • ML-DSA and ML-KEM in node:crypto

Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@panva
panva requested review from anonrig, codebytere and jasnell May 11, 2026 16:17
@panva panva added crypto Issues and PRs related to the crypto subsystem. webcrypto Issues and PRs related to the Web Crypto API. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. labels May 11, 2026
@nodejs-github-bot

nodejs-github-bot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/performance
  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels May 11, 2026
@panva
panva requested a review from addaleax May 11, 2026 16:17
@panva panva mentioned this pull request May 11, 2026
chore: add Phase Three (node smoke tests) to Node.js upgrade skill electron/electron#51127
Merged
5 tasks done
@codecov

codecov Bot commented May 11, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.24390% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.05%. Comparing base (6482073) to head (a1d227f).
⚠️ Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/crypto/webidl.js 50.00% 5 Missing ⚠️
src/crypto/crypto_pqc.cc 92.00% 0 Missing and 2 partials ⚠️
src/crypto/crypto_keys.cc 97.61% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #63255      +/-   ##
==========================================
+ Coverage   90.04%   90.05%   +0.01%     
==========================================
  Files         714      714              
  Lines      225352   225371      +19     
  Branches    42605    42621      +16     
==========================================
+ Hits       202909   202954      +45     
+ Misses      14234    14191      -43     
- Partials     8209     8226      +17
Files with missing lines Coverage Δ
lib/internal/crypto/util.js 97.08% <100.00%> (+0.10%) ⬆️
src/crypto/crypto_aes.cc 54.16% <ø> (+0.34%) ⬆️
src/crypto/crypto_aes.h 33.33% <ø> (ø)
src/crypto/crypto_argon2.cc 64.13% <ø> (ø)
src/crypto/crypto_argon2.h 50.00% <ø> (ø)
src/crypto/crypto_chacha20_poly1305.cc 58.13% <ø> (ø)
src/crypto/crypto_cipher.cc 77.43% <ø> (ø)
src/crypto/crypto_kem.cc 80.74% <ø> (ø)
src/crypto/crypto_kem.h 33.33% <ø> (ø)
src/crypto/crypto_kmac.cc 56.66% <ø> (ø)
... and 7 more

... and 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
panva added 3 commits May 15, 2026 09:47
@panva
src: simplify OpenSSL feature gates
45d5040 
Add OPENSSL_WITH_* feature macros for crypto capabilities that vary by
OpenSSL version and use those instead of repeating version checks.

Signed-off-by: Filip Skokan <[email protected]>
@panva
crypto: wire AES-KW in Web Cryptography when using BoringSSL
9a007e4 
Signed-off-by: Filip Skokan <[email protected]>
@panva
crypto: wire ChaCha20-Poly1305 in Web Cryptography when using BoringSSL
556bcb3 
Signed-off-by: Filip Skokan <[email protected]>
@panva
panva force-pushed the make-crypto-boring-again branch from 96d0932 to fbb81c2 Compare May 15, 2026 07:47
@panva
crypto: wire ML-DSA and ML-KEM for use when using BoringSSL
a1d227f 
Signed-off-by: Filip Skokan <[email protected]>
@panva
panva force-pushed the make-crypto-boring-again branch from fbb81c2 to a1d227f Compare May 15, 2026 09:51
jasnell
jasnell approved these changes May 15, 2026
View reviewed changes
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels May 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label May 15, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented May 15, 2026 •
edited by panva
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/73471/ 💚

More importantly for the change here: https://github.com/nodejs/node/actions/runs/25911580593/job/76158001919?pr=63255 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. dont-land-on-v25.x labels May 16, 2026
anonrig
anonrig approved these changes May 17, 2026
View reviewed changes
@panva panva added the commit-queue PRs queued for automated landing through the Commit Queue. label May 17, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label May 17, 2026
panva added a commit to panva/node that referenced this pull request Jun 19, 2026
@panva
src: simplify OpenSSL feature gates
deb2ea8 
Add OPENSSL_WITH_* feature macros for crypto capabilities that vary by
OpenSSL version and use those instead of repeating version checks.

Signed-off-by: Filip Skokan <[email protected]>
PR-URL: nodejs#63255
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
panva added a commit to panva/node that referenced this pull request Jun 19, 2026
@panva
crypto: wire AES-KW in Web Cryptography when using BoringSSL
a355fd2 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: nodejs#63255
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
panva added a commit to panva/node that referenced this pull request Jun 19, 2026
@panva
crypto: wire ChaCha20-Poly1305 in Web Cryptography when using BoringSSL
e1d941d 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: nodejs#63255
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
panva added a commit to panva/node that referenced this pull request Jun 19, 2026
@panva
crypto: wire ML-DSA and ML-KEM for use when using BoringSSL
20811d6 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: nodejs#63255
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sxa pushed a commit that referenced this pull request Jun 22, 2026
@panva @sxa
src: simplify OpenSSL feature gates
9b14b7c 
Add OPENSSL_WITH_* feature macros for crypto capabilities that vary by
OpenSSL version and use those instead of repeating version checks.

Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #63255
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sxa pushed a commit that referenced this pull request Jun 22, 2026
@panva @sxa
crypto: wire AES-KW in Web Cryptography when using BoringSSL
eafcd59 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #63255
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sxa pushed a commit that referenced this pull request Jun 22, 2026
@panva @sxa
crypto: wire ChaCha20-Poly1305 in Web Cryptography when using BoringSSL
8924fd6 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #63255
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sxa pushed a commit that referenced this pull request Jun 22, 2026
@panva @sxa
crypto: wire ML-DSA and ML-KEM for use when using BoringSSL
144ed78 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: #63255
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
@sxa sxa mentioned this pull request Jun 22, 2026
2026-06-23, Version 24.18.0 'Krypton' (LTS) #64062
Merged
sxa pushed a commit to sxa/node that referenced this pull request Jun 23, 2026
@panva @sxa
src: simplify OpenSSL feature gates
677ca7e 
Add OPENSSL_WITH_* feature macros for crypto capabilities that vary by
OpenSSL version and use those instead of repeating version checks.

Signed-off-by: Filip Skokan <[email protected]>
PR-URL: nodejs#63255
Backport-PR-URL: nodejs#63563
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sxa pushed a commit to sxa/node that referenced this pull request Jun 23, 2026
@panva @sxa
crypto: wire AES-KW in Web Cryptography when using BoringSSL
1bff901 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: nodejs#63255
Backport-PR-URL: nodejs#63563
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
sxa pushed a commit to sxa/node that referenced this pull request Jun 23, 2026
@panva @sxa
crypto: wire ChaCha20-Poly1305 in Web Cryptography when using BoringSSL
3bac77f 
Signed-off-by: Filip Skokan <[email protected]>
PR-URL: nodejs#63255
Backport-PR-URL: nodejs#63563
Refs: electron/electron#36256
Refs: electron/electron#41720
Refs: electron/electron#51127
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
This was referenced Jul 27, 2026
chore(mise): upgrade local tools jylenhof/mise-update-tool#18
Closed
chore(mise): upgrade local tools jylenhof/mise-update-tool#23
Closed
@ghappforreleaseplease ghappforreleaseplease Bot mentioned this pull request Aug 10, 2026
chore(mise): upgrade local tools jylenhof/mise-update-tool#28
Closed
@dsanders11 dsanders11 mentioned this pull request Oct 16, 2026
test: replace fix_crypto_tests_to_run_with_bssl.patch with upstream backport electron/electron#55043
Merged
3 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@anonrig anonrig anonrig approved these changes
@codebytere codebytere Awaiting requested review from codebytere
@addaleax addaleax Awaiting requested review from addaleax

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. backported-to-v24.x PRs backported to the v24.x-staging branch. commit-queue-rebase PRs the Commit Queue should land as multiple self-contained commits. crypto Issues and PRs related to the crypto subsystem. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. webcrypto Issues and PRs related to the Web Crypto API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@panva @nodejs-github-bot @jasnell @anonrig
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.