GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — doc: fix promise nomenclature in `stream_iter.md` by aduh95 · Pull Request #63406 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented May 18, 2026

Copy link
Copy Markdown
Contributor

According to https://tc39.es/ecma262/#sec-promise-objects:

An unresolved promise is always in the pending state. A resolved promise may be pending, fulfilled or rejected.

Using "resolve" is ambiguous and is not what we actually mean in most cases.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
doc: fix promise nomenclature in stream_iter.md
2a9feac 
Signed-off-by: Antoine du Hamel <[email protected]>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to Node.js documentation. label May 18, 2026
@Renegade334

Renegade334 commented May 18, 2026

Copy link
Copy Markdown
Member

The fs.md stream/iter methods are also using the unsupported T<...> syntax: https://github.com/search?q=repo%3Anodejs%2Fnode+path%3A%2F%5Edoc%5C%2Fapi%5C%2F%2F+%2F%5C%7B%5B%5E%7D%5Cs%5D%2B%3C%2F&type=code
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Renegade334 Renegade334 mentioned this pull request May 18, 2026
doc: remove unsupported template type from v8.md #63410
Merged
@aduh95
fixup! doc: fix promise nomenclature in stream_iter.md
2498b47
Renegade334
Renegade334 approved these changes May 18, 2026
View reviewed changes
@aduh95 aduh95 added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label May 18, 2026
lpinca
lpinca approved these changes May 19, 2026
View reviewed changes
@aduh95 aduh95 added commit-queue PRs queued for automated landing through the Commit Queue. fast-track PRs proposed for a shorter-than-standard waiting period before landing. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels May 19, 2026
@github-actions

github-actions Bot commented May 20, 2026 •
edited by aduh95
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fast-track has been requested by @aduh95 to include in the upcoming release. Please 👍 to approve.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 merged commit 701f735 into nodejs:main May 20, 2026
27 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@aduh95

aduh95 commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

Landed in 701f735
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@aduh95
aduh95 deleted the stream-iter-promise branch May 20, 2026 07:55
aduh95 added a commit that referenced this pull request May 20, 2026
@aduh95
doc: fix promise nomenclature in stream_iter.md
b2ec188 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #63406
Reviewed-By: René <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@aduh95 aduh95 mentioned this pull request Jul 22, 2026
[v24.x backport] node:stream/iter and QUIC backports #64675
Closed
aduh95 added a commit to aduh95/node that referenced this pull request Jul 30, 2026
@aduh95
doc: fix promise nomenclature in stream_iter.md
60fb975 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: nodejs#63406
Reviewed-By: René <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
aduh95 added a commit that referenced this pull request Aug 6, 2026
@aduh95
doc: fix promise nomenclature in stream_iter.md
cc425bc 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #63406
Backport-PR-URL: #64675
Reviewed-By: René <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 21, 2026
2026-08-26, Version 24.20.0 'Krypton' (LTS) #65461
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes
@Renegade334 Renegade334 Renegade334 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. doc Issues and PRs related to Node.js documentation. fast-track PRs proposed for a shorter-than-standard waiting period before landing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@aduh95 @Renegade334 @lpinca @nodejs-github-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.