GeezerVison

- Loading data for nodejs/node/pull/63915
✔  Done loading data for nodejs/node/pull/63915
----------------------------------- PR info ------------------------------------
Title      fs: cache glob matcher functions in path.matchesGlob (#63915)
Author     Adam Haglund <[email protected]> (@beeequeue, first-time contributor)
Branch     beeequeue:matchesGlob-perf -> nodejs:main
Labels     fs, author ready
Commits    2
 - path: add benchmarks for path.matchesGlob()
 - fs: add pattern cache for matchGlobPattern()
Committers 1
 - bq <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/63915
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/63915
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 14 Jun 2026 13:41:33 GMT
   ✔  Approvals: 2
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/63915#pullrequestreview-4630220976
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/63915#pullrequestreview-4688113820
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-07-15T15:29:50Z: https://ci.nodejs.org/job/node-test-pull-request/74839/
- Querying data for job/node-test-pull-request/74839/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 63915
From https://github.com/nodejs/node
 * branch                  refs/pull/63915/merge -> FETCH_HEAD
✔  Fetched commits as 874e96ee4cd0..f87f628b4e4b
--------------------------------------------------------------------------------
[main d9c89a650e] path: add benchmarks for path.matchesGlob()
 Author: bq <[email protected]>
 Date: Sun Jun 14 14:53:03 2026 +0200
 2 files changed, 57 insertions(+)
 create mode 100644 benchmark/path/matchesGlob-posix.js
 create mode 100644 benchmark/path/matchesGlob-win32.js
[main a3e8124ad7] fs: add pattern cache for matchGlobPattern()
 Author: bq <[email protected]>
 Date: Sat Jun 13 18:06:10 2026 +0200
 1 file changed, 20 insertions(+), 10 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:395) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
path: add benchmarks for path.matchesGlob()
Signed-off-by: Adam Haglund <[email protected]>

PR-URL: #63915

Reviewed-By: Aviv Keller <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>
[detached HEAD 39c08b796c] path: add benchmarks for path.matchesGlob()

Author: bq <[email protected]>

Date: Sun Jun 14 14:53:03 2026 +0200

2 files changed, 57 insertions(+)

create mode 100644 benchmark/path/matchesGlob-posix.js

create mode 100644 benchmark/path/matchesGlob-win32.js

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

fs: add pattern cache for matchGlobPattern()
Signed-off-by: Adam Haglund <[email protected]>

PR-URL: #63915

Reviewed-By: Aviv Keller <[email protected]>

Reviewed-By: Matteo Collina <[email protected]>
[detached HEAD a1983d94de] fs: add pattern cache for matchGlobPattern()

Author: bq <[email protected]>

Date: Sat Jun 13 18:06:10 2026 +0200

1 file changed, 20 insertions(+), 10 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.