GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: use libuv clock for immediate queue test by trivikr · Pull Request #64889 · nodejs/node

Conversation

@trivikr

@trivikr trivikr commented Aug 1, 2026

Copy link
Copy Markdown
Member

Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-timers-immediate-queue

Use getLibuvNow() when waiting for the timeout to expire. Date.now() may have different precision from libuv's clock, causing the immediate queue to run an extra iteration on platforms with coarse timers.

Assisted-by: codex:gpt-5.6-sol

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@trivikr
test: use libuv clock for immediate queue test
cacefac 
Use getLibuvNow() when waiting for the timeout to expire. Date.now()
may have different precision from libuv's clock, causing the immediate
queue to run an extra iteration on platforms with coarse timers.

Signed-off-by: Kamat, Trivikram <[email protected]>
Assisted-by: codex:gpt-5.6-sol
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 1, 2026
@trivikr trivikr added flaky-test Issues and PRs involving tests that fail intermittently in CI. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 1, 2026
@trivikr

trivikr commented Aug 1, 2026

Copy link
Copy Markdown
Member Author

Stress tests:

  • main: https://ci.nodejs.org/job/node-stress-single-test/813/
  • PR: https://ci.nodejs.org/job/node-stress-single-test/814/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@codecov

codecov Bot commented Aug 1, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (8a1ca0f) to head (cacefac).
⚠️ Report is 137 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #64889      +/-   ##
==========================================
- Coverage   90.14%   90.13%   -0.01%     
==========================================
  Files         746      746              
  Lines      242849   242849              
  Branches    45771    45771              
==========================================
- Hits       218906   218895      -11     
  Misses      15438    15438              
- Partials     8505     8516      +11

see 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
pimterry
pimterry approved these changes Aug 3, 2026
View reviewed changes
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 3, 2026
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@trivikr trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75638/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 8, 2026
panva pushed a commit that referenced this pull request Aug 8, 2026
@trivikr @panva
test: use libuv clock for immediate queue test
73236f3 
Use getLibuvNow() when waiting for the timeout to expire. Date.now()
may have different precision from libuv's clock, causing the immediate
queue to run an extra iteration on platforms with coarse timers.

Signed-off-by: Kamat, Trivikram <[email protected]>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #64889
Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-timers-immediate-queue
Reviewed-By: Tim Perry <[email protected]>
@panva

panva commented Aug 8, 2026

Copy link
Copy Markdown
Member

Landed in 73236f3
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@panva panva closed this Aug 8, 2026
@trivikr
trivikr deleted the flaky-test-timers-immediate-queue branch August 8, 2026 12:17
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@trivikr @aduh95
test: use libuv clock for immediate queue test
e0aaa32 
Use getLibuvNow() when waiting for the timeout to expire. Date.now()
may have different precision from libuv's clock, causing the immediate
queue to run an extra iteration on platforms with coarse timers.

Signed-off-by: Kamat, Trivikram <[email protected]>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #64889
Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-timers-immediate-queue
Reviewed-By: Tim Perry <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@trivikr @aduh95
test: use libuv clock for immediate queue test
7f3a420 
Use getLibuvNow() when waiting for the timeout to expire. Date.now()
may have different precision from libuv's clock, causing the immediate
queue to run an extra iteration on platforms with coarse timers.

Signed-off-by: Kamat, Trivikram <[email protected]>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #64889
Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-timers-immediate-queue
Reviewed-By: Tim Perry <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@trivikr @aduh95
test: use libuv clock for immediate queue test
cf7680e 
Use getLibuvNow() when waiting for the timeout to expire. Date.now()
may have different precision from libuv's clock, causing the immediate
queue to run an extra iteration on platforms with coarse timers.

Signed-off-by: Kamat, Trivikram <[email protected]>
Assisted-by: codex:gpt-5.6-sol
PR-URL: #64889
Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-timers-immediate-queue
Reviewed-By: Tim Perry <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pimterry pimterry pimterry approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

flaky-test Issues and PRs involving tests that fail intermittently in CI. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@trivikr @nodejs-github-bot @panva @pimterry
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.