GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — esm: only register text format when enabled by efekrskl · Pull Request #64992 · nodejs/node

Conversation

@efekrskl

@efekrskl efekrskl commented Aug 3, 2026

Copy link
Copy Markdown
Member

#62300 broke userland text loaders (more details 1, 2)

This PR aims to fix this by only conditionally adding text import if the feature flag is enabled (similarly to initializeExtensionFormatMap) and adds a regression test

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@efekrskl
esm: only register text format when enabled
c1640e8
Signed-off-by: Efe Karasakal <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/loaders
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot added esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem. labels Aug 3, 2026
@codecov

codecov Bot commented Aug 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (f00fb75) to head (609ea7d).
⚠️ Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #64992      +/-   ##
==========================================
+ Coverage   90.27%   90.29%   +0.02%     
==========================================
  Files         762      759       -3     
  Lines      247534   247643     +109     
  Branches    46694    46692       -2     
==========================================
+ Hits       223457   223615     +158     
+ Misses      15529    15480      -49     
  Partials     8548     8548              
Files with missing lines Coverage Δ
lib/internal/modules/esm/assert.js 100.00% <100.00%> (ø)

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JakobJingleheimer
JakobJingleheimer approved these changes Aug 4, 2026
View reviewed changes

@JakobJingleheimer JakobJingleheimer left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix! LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

efekrskl reacted with heart emoji
All reactions
  • ❤️ 1 reaction
aduh95
aduh95 reviewed Aug 4, 2026
View reviewed changes
Comment thread lib/internal/modules/esm/assert.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

aduh95
aduh95 reviewed Aug 4, 2026
View reviewed changes
Comment thread lib/internal/modules/esm/assert.js Resolved

Uh oh!

There was an error while loading. Please reload this page.

@efekrskl
esm: apply review changes
c26da19
Signed-off-by: Efe Karasakal <[email protected]>
JakobJingleheimer
JakobJingleheimer approved these changes Aug 4, 2026
View reviewed changes
@efekrskl
efekrskl requested a review from aduh95 August 4, 2026 15:33
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 4, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 4, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75468/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95

aduh95 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
 # Note: loading more builtins at run time can lead to startup performance regression.
  - Consider lazy loading builtins that are not used universally.

  --- These could be added to expected.atRunTime ---
  [
    'NativeModule internal/modules/esm/assert'
  ]


  7 !== 0

      at Object.<anonymous> (/home/iojs/build/workspace/node/test/parallel/test-bootstrap-modules.js:268:8)
efekrskl reacted with eyes emoji
All reactions
  • 👀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@efekrskl
esm: lazy init import attributes
609ea7d
Signed-off-by: Efe Karasakal <[email protected]>
@efekrskl

efekrskl commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Ok, I guess we can't call initializeImportAttributes in pre_execution.js so I moved it back to validateAttributes

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@efekrskl
efekrskl requested a review from JakobJingleheimer August 5, 2026 21:19
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75626/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JakobJingleheimer
JakobJingleheimer approved these changes Aug 8, 2026
View reviewed changes
@JakobJingleheimer JakobJingleheimer added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 8, 2026
aduh95
aduh95 approved these changes Aug 8, 2026
View reviewed changes
@aduh95 aduh95 added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 8, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 8, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/64992
✔  Done loading data for nodejs/node/pull/64992
----------------------------------- PR info ------------------------------------
Title      esm: only register text format when enabled (#64992)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     efekrskl:esm/fix-userland-text-loaders -> nodejs:main
Labels     process, esm, author ready, needs-ci
Commits    3
 - esm: only register text format when enabled
 - esm: apply review changes
 - esm: lazy init import attributes
Committers 1
 - Efe Karasakal <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/64992
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/64992
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 03 Aug 2026 22:28:12 GMT
   ✔  Approvals: 2
   ✔  - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/64992#pullrequestreview-4888461248
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/64992#pullrequestreview-4888524064
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-08-07T17:46:49Z: https://ci.nodejs.org/job/node-test-pull-request/75626/
- Querying data for job/node-test-pull-request/75626/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
   b65015adc8..ce275f1dc8  main       -> origin/main
✔  origin/main is now up-to-date
main is out of sync with origin/main. Mismatched commits:
 - 35bdeca82c test: update passphrases to comply with the next OpenSSL FIPS mode
 - ce275f1dc8 test: update passphrases to comply with the next OpenSSL FIPS mode
--------------------------------------------------------------------------------
HEAD is now at ce275f1dc8 test: update passphrases to comply with the next OpenSSL FIPS mode
   ✔  Reset to origin/main
- Downloading patch for 64992
From https://github.com/nodejs/node
 * branch                  refs/pull/64992/merge -> FETCH_HEAD
✔  Fetched commits as f538f11faf6c..609ea7ddb7ca
--------------------------------------------------------------------------------
[main fa1b34cc11] esm: only register text format when enabled
 Author: Efe Karasakal <[email protected]>
 Date: Tue Aug 4 00:21:08 2026 +0200
 3 files changed, 36 insertions(+), 7 deletions(-)
 create mode 100644 test/es-module/test-esm-loader-text-format.mjs
[main eb2a891143] esm: apply review changes
 Author: Efe Karasakal <[email protected]>
 Date: Tue Aug 4 17:32:21 2026 +0200
 1 file changed, 2 insertions(+), 2 deletions(-)
[main 7ba0a81bf0] esm: lazy init import attributes
 Author: Efe Karasakal <[email protected]>
 Date: Wed Aug 5 23:16:40 2026 +0200
 2 files changed, 11 insertions(+), 6 deletions(-)
   ✔  Patches applied
There are 3 commits in the PR. Attempting autorebase.
(node:792) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
esm: only register text format when enabled

Signed-off-by: Efe Karasakal <[email protected]>
PR-URL: #64992
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

[detached HEAD f745e11c7b] esm: only register text format when enabled
Author: Efe Karasakal <[email protected]>
Date: Tue Aug 4 00:21:08 2026 +0200
3 files changed, 36 insertions(+), 7 deletions(-)
create mode 100644 test/es-module/test-esm-loader-text-format.mjs
Rebasing (3/6)
Rebasing (4/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
esm: apply review changes

Signed-off-by: Efe Karasakal <[email protected]>
PR-URL: #64992
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

[detached HEAD fa99940f65] esm: apply review changes
Author: Efe Karasakal <[email protected]>
Date: Tue Aug 4 17:32:21 2026 +0200
1 file changed, 2 insertions(+), 2 deletions(-)
Rebasing (5/6)
Rebasing (6/6)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
esm: lazy init import attributes

Signed-off-by: Efe Karasakal <[email protected]>
PR-URL: #64992
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>

[detached HEAD 2b8871db79] esm: lazy init import attributes
Author: Efe Karasakal <[email protected]>
Date: Wed Aug 5 23:16:40 2026 +0200
2 files changed, 11 insertions(+), 6 deletions(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/31256774273

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

jasnell
jasnell approved these changes Aug 8, 2026
View reviewed changes
@jasnell jasnell added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 8, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 8, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 4df7d44 into nodejs:main Aug 8, 2026
83 of 85 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Landed in 4df7d44

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@aduh95 aduh95 mentioned this pull request Aug 11, 2026
24.19.0: --experimental-import-text breaks loader hooks that own with { type: 'text' } #65210
Closed
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@efekrskl @aduh95
esm: only register text format when enabled
07587f5
Signed-off-by: Efe Karasakal <[email protected]>
PR-URL: #64992
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@efekrskl @aduh95
esm: only register text format when enabled
b1770bc
Signed-off-by: Efe Karasakal <[email protected]>
PR-URL: #64992
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@efekrskl @aduh95
esm: only register text format when enabled
cd84d55
Signed-off-by: Efe Karasakal <[email protected]>
PR-URL: #64992
Reviewed-By: Jacob Smith <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@AugustinMauroy

AugustinMauroy commented Sep 2, 2026

Copy link
Copy Markdown
Member

when did the backport will happened for v24?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
@JakobJingleheimer JakobJingleheimer mentioned this pull request Sep 15, 2026
setup(deps): bump step-security/harden-runner from 2.20.0 to 2.21.1 nodejs-loaders/nodejs-loaders#386
Merged
JakobJingleheimer added a commit to nodejs-loaders/nodejs-loaders that referenced this pull request Sep 27, 2026
@JakobJingleheimer
setup(ci): kick stuck runner cache & update text-laoder's pjson engines
4d180c2
Account for breakage introduced in nodejs/node#62300 and fixed in nodejs/node#64992
@JakobJingleheimer JakobJingleheimer mentioned this pull request Sep 27, 2026
setup(ci): kick stuck runner cache & update text-loader's pjson engines nodejs-loaders/nodejs-loaders#391
Merged
@pdeveltere pdeveltere mentioned this pull request Nov 5, 2026
module: unflag --experimental-import-text? #67267
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@JakobJingleheimer JakobJingleheimer JakobJingleheimer approved these changes
@aduh95 aduh95 aduh95 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. esm Issues and PRs related to the ECMAScript Modules implementation. needs-ci PRs that need a full CI run. process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@efekrskl @nodejs-github-bot @aduh95 @AugustinMauroy @jasnell @JakobJingleheimer
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.