GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||
GeezerVison is showing github.com — esm: only register text format when enabled by efekrskl · Pull Request #64992 · nodejs/node Conversation
Member
#62300 broke userland text loaders (more details 1, 2) This PR aims to fix this by only conditionally adding text import if the feature flag is enabled (similarly to initializeExtensionFormatMap) and adds a regression test
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsSigned-off-by: Efe Karasakal <[email protected]>
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #64992 +/- ## ========================================== + Coverage 90.27% 90.29% +0.02% ========================================== Files 762 759 -3 Lines 247534 247643 +109 Branches 46694 46692 -2 ========================================== + Hits 223457 223615 +158 + Misses 15529 15480 -49 Partials 8548 8548
🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix! LGTM
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Signed-off-by: Efe Karasakal <[email protected]>
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Efe Karasakal <[email protected]>
|
Ok, I guess we can't call |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Commit Queue failed- Loading data for nodejs/node/pull/64992 ✔ Done loading data for nodejs/node/pull/64992 ----------------------------------- PR info ------------------------------------ Title esm: only register text format when enabled (#64992) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch efekrskl:esm/fix-userland-text-loaders -> nodejs:main Labels process, esm, author ready, needs-ci Commits 3 - esm: only register text format when enabled - esm: apply review changes - esm: lazy init import attributes Committers 1 - Efe Karasakal <[email protected]> PR-URL: https://github.com/nodejs/node/pull/64992 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/64992 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 03 Aug 2026 22:28:12 GMT ✔ Approvals: 2 ✔ - Jacob Smith (@JakobJingleheimer): https://github.com/nodejs/node/pull/64992#pullrequestreview-4888461248 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/64992#pullrequestreview-4888524064 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-08-07T17:46:49Z: https://ci.nodejs.org/job/node-test-pull-request/75626/ - Querying data for job/node-test-pull-request/75626/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD b65015adc8..ce275f1dc8 main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 35bdeca82c test: update passphrases to comply with the next OpenSSL FIPS mode - ce275f1dc8 test: update passphrases to comply with the next OpenSSL FIPS mode -------------------------------------------------------------------------------- HEAD is now at ce275f1dc8 test: update passphrases to comply with the next OpenSSL FIPS mode ✔ Reset to origin/main - Downloading patch for 64992 From https://github.com/nodejs/node * branch refs/pull/64992/merge -> FETCH_HEAD ✔ Fetched commits as f538f11faf6c..609ea7ddb7ca -------------------------------------------------------------------------------- [main fa1b34cc11] esm: only register text format when enabled Author: Efe Karasakal <[email protected]> Date: Tue Aug 4 00:21:08 2026 +0200 3 files changed, 36 insertions(+), 7 deletions(-) create mode 100644 test/es-module/test-esm-loader-text-format.mjs [main eb2a891143] esm: apply review changes Author: Efe Karasakal <[email protected]> Date: Tue Aug 4 17:32:21 2026 +0200 1 file changed, 2 insertions(+), 2 deletions(-) [main 7ba0a81bf0] esm: lazy init import attributes Author: Efe Karasakal <[email protected]> Date: Wed Aug 5 23:16:40 2026 +0200 2 files changed, 11 insertions(+), 6 deletions(-) ✔ Patches applied There are 3 commits in the PR. Attempting autorebase. (node:792) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated. (Use `node --trace-deprecation ...` to show where the warning was created) Rebasing (2/6) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- esm: only register text format when enabledhttps://github.com/nodejs/node/actions/runs/31256774273 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Landed in 4df7d44 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Efe Karasakal <[email protected]> PR-URL: #64992 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Signed-off-by: Efe Karasakal <[email protected]> PR-URL: #64992 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Signed-off-by: Efe Karasakal <[email protected]> PR-URL: #64992 Reviewed-By: Jacob Smith <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
when did the backport will happened for v24? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Account for breakage introduced in nodejs/node#62300 and fixed in nodejs/node#64992
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.