GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — stream: use validateNumber for BYOB reader options.min by greenheadHQ · Pull Request #65014 · nodejs/node

Conversation

@greenheadHQ

@greenheadHQ greenheadHQ commented Aug 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Replace the open-coded typeof check for options.min in ReadableStreamBYOBReader.prototype.read() with validateNumber. Called without min/max bounds it performs the same check and constructs ERR_INVALID_ARG_TYPE with the same arguments, so the rejection type, code, and message are unchanged.

The added test covers all three validation branches (type, integer/positive, out-of-range), which no existing test pinned, and passes with and without the lib change.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Aug 4, 2026
@greenheadHQ
greenheadHQ force-pushed the readablestream-validate-number branch from b6208dc to 8416524 Compare August 4, 2026 14:16
@greenheadHQ
stream: use validateNumber for BYOB reader options.min
6925505 
The error thrown for a non-number min is unchanged.

Signed-off-by: greenhead <[email protected]>
@greenheadHQ
greenheadHQ force-pushed the readablestream-validate-number branch from 8416524 to 6925505 Compare August 4, 2026 14:21
@codecov

codecov Bot commented Aug 4, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.28%. Comparing base (31cde9f) to head (6925505).
⚠️ Report is 202 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65014      +/-   ##
==========================================
- Coverage   90.30%   90.28%   -0.02%     
==========================================
  Files         759      759              
  Lines      247621   247634      +13     
  Branches    46672    46686      +14     
==========================================
- Hits       223603   223570      -33     
- Misses      15473    15523      +50     
+ Partials     8545     8541       -4
Files with missing lines Coverage Δ
lib/internal/webstreams/readablestream.js 98.21% <100.00%> (+0.05%) ⬆️

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
daeyeon
daeyeon approved these changes Aug 11, 2026
View reviewed changes
@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 11, 2026
@daeyeon daeyeon mentioned this pull request Aug 11, 2026
stream: use validateNumber for options.min #65193
Closed
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 11, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75759/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@daeyeon daeyeon added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 17, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 26398a9 into nodejs:main Aug 17, 2026
83 of 87 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Landed in 26398a9
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 17, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@greenheadHQ @aduh95
stream: use validateNumber for BYOB reader options.min
93e7e6e 
The error thrown for a non-number min is unchanged.

Signed-off-by: greenhead <[email protected]>
PR-URL: #65014
Reviewed-By: Daeyeon Jeong <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@greenheadHQ @aduh95
stream: use validateNumber for BYOB reader options.min
4f6f2cf 
The error thrown for a non-number min is unchanged.

Signed-off-by: greenhead <[email protected]>
PR-URL: #65014
Reviewed-By: Daeyeon Jeong <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@greenheadHQ @aduh95
stream: use validateNumber for BYOB reader options.min
3a174ce 
The error thrown for a non-number min is unchanged.

Signed-off-by: greenhead <[email protected]>
PR-URL: #65014
Reviewed-By: Daeyeon Jeong <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daeyeon daeyeon daeyeon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@greenheadHQ @nodejs-github-bot @daeyeon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.