GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — typings: add internal_only_v8 binding types by HoonDongKang · Pull Request #65071 · nodejs/node

Conversation

@HoonDongKang

@HoonDongKang HoonDongKang commented Aug 6, 2026

Copy link
Copy Markdown
Member

Add typings for the internal_only_v8 internal binding.

Changes:

  • Added typings/internalBinding/internal_only_v8.d.ts
  • Added internal_only_v8 to InternalBindingMap
  • Typed queryObjects()

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added the typings Issues and PRs related to internal TypeScript declarations. label Aug 6, 2026
@HoonDongKang
typings: add internal_only_v8 binding typeis
6f39e0e 
Add an InternalOnlyV8Binding declaration for
internalBinding('internal_only_v8') and wire it into
InternalBindingMap.

Signed-off-by: HoonDongKang <[email protected]>
@HoonDongKang
HoonDongKang force-pushed the typings-internal-only-v8-binding branch from d25d4c0 to 6f39e0e Compare August 6, 2026 07:18
daeyeon
daeyeon reviewed Aug 9, 2026
View reviewed changes
Comment thread typings/internalBinding/internal_only_v8.d.ts Resolved

Uh oh!

There was an error while loading. Please reload this page.
@HoonDongKang
typings: update internal_only_v8 queryObjects type
6583bd1 
Signed-off-by: HoonDongKang <[email protected]>
daeyeon
daeyeon approved these changes Aug 11, 2026
View reviewed changes
@daeyeon daeyeon added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 11, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 5e7bd32 into nodejs:main Aug 14, 2026
26 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 14, 2026

Copy link
Copy Markdown
Collaborator

Landed in 5e7bd32
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 14, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@HoonDongKang @aduh95
typings: add internal_only_v8 binding typeis
f87540d 
Add an InternalOnlyV8Binding declaration for
internalBinding('internal_only_v8') and wire it into
InternalBindingMap.

Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65071
Reviewed-By: Daeyeon Jeong <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@HoonDongKang @aduh95
typings: add internal_only_v8 binding typeis
eb095a9 
Add an InternalOnlyV8Binding declaration for
internalBinding('internal_only_v8') and wire it into
InternalBindingMap.

Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65071
Reviewed-By: Daeyeon Jeong <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@HoonDongKang @aduh95
typings: add internal_only_v8 binding typeis
c57c83b 
Add an InternalOnlyV8Binding declaration for
internalBinding('internal_only_v8') and wire it into
InternalBindingMap.

Signed-off-by: HoonDongKang <[email protected]>
PR-URL: #65071
Reviewed-By: Daeyeon Jeong <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daeyeon daeyeon daeyeon approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. typings Issues and PRs related to internal TypeScript declarations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@HoonDongKang @nodejs-github-bot @daeyeon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.