GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — process: validate resource stats array offsets by Archkon · Pull Request #65098 · nodejs/node

Conversation

@Archkon

@Archkon Archkon commented Aug 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Assert that the internally allocated Float64Array views used by CPU, thread CPU, memory, and resource statistics have zero byte offsets.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Aug 7, 2026
@codecov

codecov Bot commented Aug 7, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (985aa07) to head (2f7a8b0).
⚠️ Report is 42 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #65098   +/-   ##
=======================================
  Coverage   90.31%   90.31%           
=======================================
  Files         759      759           
  Lines      248299   248289   -10     
  Branches    46854    46858    +4     
=======================================
- Hits       224251   224243    -8     
- Misses      15468    15469    +1     
+ Partials     8580     8577    -3
Files with missing lines Coverage Δ
src/node_process_methods.cc 88.55% <100.00%> (+0.02%) ⬆️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Renegade334
Renegade334 requested changes Aug 7, 2026
View reviewed changes

@Renegade334 Renegade334 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We define the only ABVs that are ever passed to these bindings. A simple CHECK_EQ(arr->ByteOffset(), 0) is all that's needed here.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Archkon
process: validate resource stats array offsets
2f7a8b0 
Assert that the internally allocated Float64Array views used by CPU,
thread CPU, memory, and resource statistics have zero byte offsets.

Signed-off-by: Archkon <[email protected]>
@Archkon
Archkon force-pushed the process6 branch from 40ee688 to 2f7a8b0 Compare August 7, 2026 10:07
@Archkon

This comment was marked as spam.

Sign in to view
@Archkon
Archkon requested a review from Renegade334 August 7, 2026 10:09
@Archkon Archkon changed the title process: respect Float64Array byte offsets process: validate resource stats array offsets Aug 7, 2026
Renegade334
Renegade334 approved these changes Aug 7, 2026
View reviewed changes
@Renegade334 Renegade334 added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 7, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 7, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75612/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 7, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75613/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 9, 2026
@avivkeller

avivkeller commented Aug 9, 2026

Copy link
Copy Markdown
Member
Commit Queue failed
- Loading data for nodejs/node/pull/65098
✔  Done loading data for nodejs/node/pull/65098
----------------------------------- PR info ------------------------------------
Title      process: validate resource stats array offsets  (#65098)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Archkon:process6 -> nodejs:main
Labels     c++, author ready, needs-ci, commit-queue
Commits    1
 - process: validate resource stats array offsets
Committers 1
 - Archkon <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/65098
Reviewed-By: René <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65098
Reviewed-By: René <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 07 Aug 2026 07:58:58 GMT
   ✔  Approvals: 1
   ✔  - René (@Renegade334): https://github.com/nodejs/node/pull/65098#pullrequestreview-4882184408
   ✘  This PR needs to wait 106 more hours to land (or 0 minutes if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-08-07T12:47:06Z: https://ci.nodejs.org/job/node-test-pull-request/75613/
- Querying data for job/node-test-pull-request/75613/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /Users/avivkeller/Documents/projects/nodejs/node/.ncu
/nodejs/node/actions/runs/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
avivkeller
avivkeller approved these changes Aug 9, 2026
View reviewed changes
avivkeller pushed a commit that referenced this pull request Aug 9, 2026
@Archkon @nodejs-github-bot
process: validate resource stats array offsets
f6db7bc 
Assert that the internally allocated Float64Array views used by CPU,
thread CPU, memory, and resource statistics have zero byte offsets.

Signed-off-by: Archkon <[email protected]>
PR-URL: #65098
Reviewed-By: René <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
@avivkeller

avivkeller commented Aug 9, 2026

Copy link
Copy Markdown
Member

Landed in f6db7bc
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller closed this Aug 9, 2026
@Archkon
Archkon deleted the process6 branch August 10, 2026 03:59
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@Archkon @aduh95
process: validate resource stats array offsets
d7b720d 
Assert that the internally allocated Float64Array views used by CPU,
thread CPU, memory, and resource statistics have zero byte offsets.

Signed-off-by: Archkon <[email protected]>
PR-URL: #65098
Reviewed-By: René <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@Archkon @aduh95
process: validate resource stats array offsets
8765afd 
Assert that the internally allocated Float64Array views used by CPU,
thread CPU, memory, and resource statistics have zero byte offsets.

Signed-off-by: Archkon <[email protected]>
PR-URL: #65098
Reviewed-By: René <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@Archkon @aduh95
process: validate resource stats array offsets
dff2b67 
Assert that the internally allocated Float64Array views used by CPU,
thread CPU, memory, and resource statistics have zero byte offsets.

Signed-off-by: Archkon <[email protected]>
PR-URL: #65098
Reviewed-By: René <[email protected]>
Reviewed-By: Aviv Keller <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Renegade334 Renegade334 Renegade334 approved these changes
@avivkeller avivkeller avivkeller approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Archkon @nodejs-github-bot @avivkeller @Renegade334
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.