GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — src: use concepts where appropriate by jasnell · Pull Request #65148 · nodejs/node

Conversation

@jasnell

@jasnell jasnell commented Aug 8, 2026

Copy link
Copy Markdown
Member

Some general modernizations of templates.

Use concept/requires in a range of places.

Signed-off-by: James M Snell [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
jasnell added 3 commits August 8, 2026 14:58
@jasnell
src: use concepts where appropriate
dde7b1d 
Some general modernizations of templates

Signed-off-by: James M Snell <[email protected]>
@jasnell
src: apply more template/concept modernizations
679745a 
Signed-off-by: James M Snell <[email protected]>
@jasnell
src: apply more concept modernizations
5613c5c 
Signed-off-by: James M Snell <[email protected]>
@jasnell
jasnell requested review from addaleax and tniessen August 8, 2026 22:42
@nodejs-github-bot

nodejs-github-bot commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/gyp
  • @nodejs/realm
  • @nodejs/single-executable
  • @nodejs/startup
  • @nodejs/wasi
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run. labels Aug 8, 2026
avivkeller
avivkeller approved these changes Aug 8, 2026
View reviewed changes
@codecov

codecov Bot commented Aug 9, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (c32ea43) to head (5613c5c).
⚠️ Report is 55 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65148      +/-   ##
==========================================
- Coverage   90.32%   90.30%   -0.02%     
==========================================
  Files         759      759              
  Lines      248326   248322       -4     
  Branches    46859    46866       +7     
==========================================
- Hits       224293   224258      -35     
- Misses      15481    15507      +26     
- Partials     8552     8557       +5
Files with missing lines Coverage Δ
src/aliased_buffer-inl.h 93.97% <ø> (ø)
src/aliased_buffer.h 100.00% <ø> (ø)
src/blob_serializer_deserializer-inl.h 66.09% <100.00%> (ø)
src/blob_serializer_deserializer.h 100.00% <ø> (ø)
src/crypto/crypto_aes.cc 53.95% <ø> (ø)
src/crypto/crypto_util.h 67.43% <ø> (ø)
src/debug_utils-inl.h 76.37% <ø> (ø)
src/json_utils.h 97.27% <ø> (ø)
src/memory_tracker-inl.h 63.41% <ø> (-10.57%) ⬇️
src/memory_tracker.h 100.00% <ø> (ø)
... and 16 more

... and 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
bjohansebas
bjohansebas approved these changes Aug 9, 2026
View reviewed changes
@bjohansebas bjohansebas added author ready PRs with CI started, the required approvals, and no outstanding review comments. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 9, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 9, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2026 •
edited by jasnell
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75697/ 💚
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jasnell jasnell added commit-queue PRs queued for automated landing through the Commit Queue. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Aug 10, 2026
tniessen
tniessen approved these changes Aug 11, 2026
View reviewed changes
@nodejs-github-bot
nodejs-github-bot merged commit 2fa068a into nodejs:main Aug 11, 2026
93 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Landed in 2fa068a
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 11, 2026
aduh95 pushed a commit that referenced this pull request Aug 13, 2026
@jasnell @aduh95
src: use concepts where appropriate
b356fff 
Some general modernizations of templates

Signed-off-by: James M Snell <[email protected]>
PR-URL: #65148
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@jasnell @aduh95
src: use concepts where appropriate
3cfe194 
Some general modernizations of templates

Signed-off-by: James M Snell <[email protected]>
PR-URL: #65148
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tniessen tniessen tniessen approved these changes
@avivkeller avivkeller avivkeller approved these changes
@addaleax addaleax Awaiting requested review from addaleax
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash PRs the Commit Queue should land as one squashed commit. lib / src Issues and PRs involving general changes in the lib/ or src/ directories. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@jasnell @nodejs-github-bot @tniessen @avivkeller @bjohansebas
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.