GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — tools: fix quote escaping in `update-nixpkgs-pin.sh` by aduh95 · Pull Request #65166 · nodejs/node

Conversation

@aduh95

@aduh95 aduh95 commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

To fix https://github.com/nodejs/node/actions/runs/31286321519/job/93175721719#step:5:131, which was introduced in #64962

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@aduh95
tools: fix quote escaping in update-nixpkgs-pin.sh
ff795b9 
Signed-off-by: Antoine du Hamel <[email protected]>
@nodejs-github-bot

nodejs-github-bot commented Aug 9, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/security-wg
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Aug 9, 2026
panva
panva approved these changes Aug 9, 2026
View reviewed changes
@aduh95 aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 9, 2026
atlowChemi
atlowChemi approved these changes Aug 9, 2026
View reviewed changes
@avivkeller avivkeller added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 9, 2026
@avivkeller

avivkeller commented Aug 9, 2026

Copy link
Copy Markdown
Member
Commit Queue failed
- Loading data for nodejs/node/pull/65166
✔  Done loading data for nodejs/node/pull/65166
----------------------------------- PR info ------------------------------------
Title      tools: fix quote escaping in `update-nixpkgs-pin.sh` (#65166)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     aduh95:fix-update-nixpkgs-pin.sh -> nodejs:main
Labels     tools, author ready, commit-queue
Commits    1
 - tools: fix quote escaping in `update-nixpkgs-pin.sh`
Committers 1
 - Antoine du Hamel <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/65166
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65166
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 09 Aug 2026 15:58:55 GMT
   ✔  Approvals: 2
   ✔  - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/65166#pullrequestreview-4891893387
   ✔  - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/65166#pullrequestreview-4892469917
   ✘  This PR needs to wait 42 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /Users/avivkeller/Documents/projects/nodejs/node/.ncu
/nodejs/node/actions/runs/
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@avivkeller avivkeller added commit-queue PRs queued for automated landing through the Commit Queue. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. labels Aug 9, 2026
cjihrig
cjihrig approved these changes Aug 10, 2026
View reviewed changes
@nodejs-github-bot
nodejs-github-bot merged commit 6a447d7 into nodejs:main Aug 11, 2026
33 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot

nodejs-github-bot commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Landed in 6a447d7
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 11, 2026
aduh95 added a commit that referenced this pull request Aug 13, 2026
@aduh95
tools: fix quote escaping in update-nixpkgs-pin.sh
a63962b 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #65166
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
aduh95 added a commit that referenced this pull request Aug 25, 2026
@aduh95
tools: fix quote escaping in update-nixpkgs-pin.sh
53d5273 
Signed-off-by: Antoine du Hamel <[email protected]>
PR-URL: #65166
Reviewed-By: Filip Skokan <[email protected]>
Reviewed-By: Chemi Atlow <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Aug 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@panva panva panva approved these changes
@cjihrig cjihrig cjihrig approved these changes
@atlowChemi atlowChemi atlowChemi approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@aduh95 @nodejs-github-bot @avivkeller @panva @cjihrig @atlowChemi
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.