GeezerVison

- Loading data for nodejs/node/pull/65229
✔  Done loading data for nodejs/node/pull/65229
----------------------------------- PR info ------------------------------------
Title      typings: add signal_wrap internal binding types (#65229)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     leah-1ee:typings-signal-wrap -> nodejs:main
Labels     author ready, commit-queue, typings
Commits    2
 - typings: add signal_wrap internal binding types
 - typings: fix signal_wrap Start return type
Committers 2
 - leah-1ee <[email protected]>
 - leah-1ee <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/65229
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65229
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 11 Aug 2026 23:48:33 GMT
   ✔  Approvals: 2
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/65229#pullrequestreview-4944189389
   ✔  - Daeyeon Jeong (@daeyeon): https://github.com/nodejs/node/pull/65229#pullrequestreview-4949499018
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 65229
From https://github.com/nodejs/node
 * branch                  refs/pull/65229/merge -> FETCH_HEAD
✔  Fetched commits as 977c20ed675e..47e11921ff09
--------------------------------------------------------------------------------
Auto-merging typings/globals.d.ts
[main 33bcc191d0] typings: add signal_wrap internal binding types
 Author: leah-1ee <[email protected]>
 Date: Wed Aug 12 08:47:39 2026 +0900
 2 files changed, 18 insertions(+)
 create mode 100644 typings/internalBinding/signal_wrap.d.ts
[main b9bbd58835] typings: fix signal_wrap Start return type
 Author: leah-1ee <[email protected]>
 Date: Mon Aug 17 15:37:02 2026 +0900
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
(node:468) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
typings: add signal_wrap internal binding types
Add a SignalWrapBinding declaration for internalBinding('signal_wrap')

and wire it into InternalBindingMap.
Signed-off-by: leah-1ee <[email protected]>

PR-URL: #65229

Reviewed-By: James M Snell <[email protected]>

Reviewed-By: Daeyeon Jeong <[email protected]>
[detached HEAD 83de3b0979] typings: add signal_wrap internal binding types

Author: leah-1ee <[email protected]>

Date: Wed Aug 12 08:47:39 2026 +0900

2 files changed, 18 insertions(+)

create mode 100644 typings/internalBinding/signal_wrap.d.ts

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

typings: fix signal_wrap Start return type
Signed-off-by: leah-1ee <[email protected]>

PR-URL: #65229

Reviewed-By: James M Snell <[email protected]>

Reviewed-By: Daeyeon Jeong <[email protected]>
[detached HEAD 93bb8c6d23] typings: fix signal_wrap Start return type

Author: leah-1ee <[email protected]>

Date: Mon Aug 17 15:37:02 2026 +0900

1 file changed, 1 insertion(+), 1 deletion(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.