GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||
GeezerVison is showing github.com — test: convert test-messageevent-brandcheck forEach to for...of loop by nachiketap11 · Pull Request #65279 · nodejs/node Conversation
Contributor
Author
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
avivkeller
approved these changes
Ethan-Arrowood
approved these changes
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great work!
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
bjohansebas
approved these changes
Collaborator
All reactions
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page.
|
There was an error while loading. Please reload this page.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@ ## main #65279 +/- ## ========================================== - Coverage 90.31% 90.13% -0.19% ========================================== Files 751 752 +1 Lines 249776 251569 +1793 Branches 47173 47277 +104 ========================================== + Hits 225587 226740 +1153 - Misses 15585 16184 +599 - Partials 8604 8645 +41 🚀 New features to boost your workflow:
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Nachiketa Pathak <[email protected]>
d335b90 to
233097b
Compare
Commit Queue failed- Loading data for nodejs/node/pull/65279 ✔ Done loading data for nodejs/node/pull/65279 ----------------------------------- PR info ------------------------------------ Title test: convert test-messageevent-brandcheck forEach to for...of loop (#65279) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nachiketap11:test-messageevent-brandcheck-convert-foreach -> nodejs:main Labels test, code-and-learn, author ready, needs-ci, commit-queue Commits 1 - test: convert forEach to for of test-messageevent-brandcheck file Committers 1 - Nachiketa Pathak <[email protected]> PR-URL: https://github.com/nodejs/node/pull/65279 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/65279 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Aug 2026 04:31:29 GMT ✔ Approvals: 3 ✔ - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65279#pullrequestreview-4934053345 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/65279#pullrequestreview-4939394602 ✔ - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/65279#pullrequestreview-4951770119 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2026-08-15T14:59:27Z: https://ci.nodejs.org/job/node-test-pull-request/75861/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - test: convert forEach to for of test-messageevent-brandcheck file - Querying data for job/node-test-pull-request/75861/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/32430348514 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
Landed in 7072d76 |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Signed-off-by: Nachiketa Pathak <[email protected]> PR-URL: #65279 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Signed-off-by: Nachiketa Pathak <[email protected]> PR-URL: #65279 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Signed-off-by: Nachiketa Pathak <[email protected]> PR-URL: #65279 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Signed-off-by: Nachiketa Pathak <[email protected]> PR-URL: #65279 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Signed-off-by: Nachiketa Pathak <[email protected]> PR-URL: #65279 Reviewed-By: Aviv Keller <[email protected]> Reviewed-By: Ethan Arrowood <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.