GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — test: convert test-messageevent-brandcheck forEach to for...of loop by nachiketap11 · Pull Request #65279 · nodejs/node

Conversation

@nachiketap11

@nachiketap11 nachiketap11 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Updated the forEach loop in test-messageevent-brandcheck.js to a for...of loop for a cleaner stack trace.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Aug 14, 2026
@nachiketap11

nachiketap11 commented Aug 14, 2026

Copy link
Copy Markdown
Contributor Author

@jasnell, tagging you for review.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@avivkeller avivkeller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Aug 14, 2026
avivkeller
avivkeller approved these changes Aug 14, 2026
View reviewed changes
Ethan-Arrowood
Ethan-Arrowood approved these changes Aug 14, 2026
View reviewed changes

@Ethan-Arrowood Ethan-Arrowood left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
bjohansebas
bjohansebas approved these changes Aug 14, 2026
View reviewed changes
@avivkeller avivkeller added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Aug 15, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 15, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/75861/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@codecov

codecov Bot commented Aug 15, 2026 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.13%. Comparing base (1662b69) to head (233097b).
⚠️ Report is 168 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65279      +/-   ##
==========================================
- Coverage   90.31%   90.13%   -0.19%     
==========================================
  Files         751      752       +1     
  Lines      249776   251569    +1793     
  Branches    47173    47277     +104     
==========================================
+ Hits       225587   226740    +1153     
- Misses      15585    16184     +599     
- Partials     8604     8645      +41     

see 95 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@avivkeller avivkeller removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 15, 2026
@nachiketap11
test: convert forEach to for of test-messageevent-brandcheck file
233097b
Signed-off-by: Nachiketa Pathak <[email protected]>
@nachiketap11
nachiketap11 force-pushed the test-messageevent-brandcheck-convert-foreach branch from d335b90 to 233097b Compare August 16, 2026 03:51
cjihrig
cjihrig approved these changes Aug 17, 2026
View reviewed changes
@trivikr trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 20, 2026
@nodejs-github-bot nodejs-github-bot added commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. and removed commit-queue PRs queued for automated landing through the Commit Queue. labels Aug 20, 2026
@nodejs-github-bot

nodejs-github-bot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/65279
✔  Done loading data for nodejs/node/pull/65279
----------------------------------- PR info ------------------------------------
Title      test: convert test-messageevent-brandcheck forEach to for...of  loop (#65279)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nachiketap11:test-messageevent-brandcheck-convert-foreach -> nodejs:main
Labels     test, code-and-learn, author ready, needs-ci, commit-queue
Commits    1
 - test: convert forEach to for of test-messageevent-brandcheck file
Committers 1
 - Nachiketa Pathak <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/65279
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/65279
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 14 Aug 2026 04:31:29 GMT
   ✔  Approvals: 3
   ✔  - Aviv Keller (@avivkeller): https://github.com/nodejs/node/pull/65279#pullrequestreview-4934053345
   ✔  - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/65279#pullrequestreview-4939394602
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/65279#pullrequestreview-4951770119
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2026-08-15T14:59:27Z: https://ci.nodejs.org/job/node-test-pull-request/75861/
   ⚠  Commits were pushed after the last Full PR CI run:
   ⚠  - test: convert forEach to for of test-messageevent-brandcheck file
- Querying data for job/node-test-pull-request/75861/
✔  Build data downloaded
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/32430348514
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@trivikr trivikr added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed commit-queue-failed PRs whose Commit Queue landing failed and need manual intervention before retrying. request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. labels Aug 21, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

nodejs-github-bot commented Aug 22, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76238/

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@trivikr trivikr added the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 7072d76 into nodejs:main Aug 23, 2026
81 checks passed

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot

nodejs-github-bot commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Landed in 7072d76

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Aug 23, 2026
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@nachiketap11 @aduh95
test: convert forEach to for of test-messageevent-brandcheck file
daac551
Signed-off-by: Nachiketa Pathak <[email protected]>
PR-URL: #65279
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
aduh95 pushed a commit that referenced this pull request Aug 25, 2026
@nachiketap11 @aduh95
test: convert forEach to for of test-messageevent-brandcheck file
01cb4f9
Signed-off-by: Nachiketa Pathak <[email protected]>
PR-URL: #65279
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@github-actions github-actions Bot mentioned this pull request Aug 25, 2026
2026-08-26, Version 26.8.0 (Current) #65551
Merged
aduh95 pushed a commit that referenced this pull request Aug 27, 2026
@nachiketap11 @aduh95
test: convert forEach to for of test-messageevent-brandcheck file
6842e76
Signed-off-by: Nachiketa Pathak <[email protected]>
PR-URL: #65279
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
2026-09-08, Version 24.21.0 'Krypton' (LTS) #65873
Merged
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@nachiketap11 @aduh95
test: convert forEach to for of test-messageevent-brandcheck file
515b5c5
Signed-off-by: Nachiketa Pathak <[email protected]>
PR-URL: #65279
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
aduh95 pushed a commit that referenced this pull request Sep 7, 2026
@nachiketap11 @aduh95
test: convert forEach to for of test-messageevent-brandcheck file
7d135d2
Signed-off-by: Nachiketa Pathak <[email protected]>
PR-URL: #65279
Reviewed-By: Aviv Keller <[email protected]>
Reviewed-By: Ethan Arrowood <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjihrig cjihrig cjihrig approved these changes
@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes
@avivkeller avivkeller avivkeller approved these changes
+1 more reviewer
@bjohansebas bjohansebas bjohansebas approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@nachiketap11 @nodejs-github-bot @cjihrig @Ethan-Arrowood @avivkeller @bjohansebas @trivikr
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.